Ambermoon open source remake in progress

[Pyrdacor]

Originally Posted by dlfrsilver

Pyrdacor, can you please hint me on your recompressor tool ?

I have extracted the file to path from the archive 1map_data.amb, i did the modifications, and now i do that :

AmbermoonPack REPACK 00D.amb 00D-.amb

Am i doing something wrong ?

Use "AMNP" instead of "REPACK". REPACK can re-pack an already packed container to a different format (for example AMBR to AMNP or JH to LOB).

But in your case you want to pack single files into a container. This is simply done by specifying the container format. AMNP is used for most data files like map data, etc.

Use something like this: AmbermoonPack.exe AMNP 1Map_data 1Map_data.amb
Here 1Map_data is the relative path to the folder with the single files.

[Pyrdacor]

In general you do:

Unpacking:
AmbermoonPack.exe UNPACK <the_amb_file> <output_path>

Packing:
AmbermoonPack.exe <format> <input_path> <the_amb_file>


Example:
AmbermoonPack.exe UNPACK 1Map_data.amb My/Files/For/1Map_data
AmbermoonPack.exe AMNP My/Files/For/1Map_data 1Map_data.amb

[Pyrdacor]

Originally Posted by dlfrsilver

Ok, i have finished the extro translation for Ambermoon in french, at last !

Now, i will implement the patches that Pyrdacor found (the others are already done, plus my owns fixes).

Great! So you managed to fix the extro yourself? Can you tell me how you did that? Do you have the source code or something? Maybe your tools/knowledge can be valuable for me and the upcoming Mod and the original AM2_XXX fixes as well.

[dlfrsilver]

Originally Posted by Pyrdacor

Great! So you managed to fix the extro yourself? Can you tell me how you did that? Do you have the source code or something? Maybe your tools/knowledge can be valuable for me and the upcoming Mod and the original AM2_XXX fixes as well.

I have ressourced the executables, the installer, the loader and intro/extro.

Basically, i stopped on the extro because i was unsure of the text formatting.
With your help, i found that 42 characters are the maximum in order to get no errors on screen.

I have the extro file fully ressourced in ASM68K. I use Barfly to assemble the files. CFOU also made me a ressourcer dedicated to the texts AMB files.

What i lacked was the LOB packer (i have it, it runs on Atari ST, but it's proprietary and i can't release it).

here is how it looks :

TextBlk01.MSG db 12 ;0C
db 0 ;00
db 0 ;00
db "Des pierres chutent du plafond, s'ecrasant",0,$C,0,0 ; 42 characters max !
db "au sol tout autour de vous, alors que vous",0,$C,0,0
db "fuyez la salle de la machine et remontez",0,$3C,0,0
db "l'escalier qui mene a la surface.",0,$C,0
db 0
db "Tout le monde reussit a echapper au brasier",0,$C,0,0
db "provoque par la fuite d'energie de la",0,$3C,0,0
db "machine detruite.",0,$C,0
db 0
db "Les explosions sont de plus en plus fortes",0,$3C,0,0
db "jusqu'a ce que l'ile toute entiere tremble.",0,$C,0
db 0
db "Vous decidez d'invoquer un aigle geant afin",0,$C,0,0
db "que vous puissiez quitter le Temple de la",0,$3C,0,0
db "Confrerie aussi rapidement que possible.",0,$C,0
db 0
db "A peine les puissantes ailes de l'Aigle vous",0,$C,0,0
db "emportent, qu'une enorme detonation",0,$C,0,0
db "eventre le temple a moitie! Votre souffle",0,$C,0,0
db "est coupe lorsque que le hangar a",0,$3C,0,0
db "aeronef tremble et s'effondre a terre.",0,$C,0
db 0
db "Puis l'energie destructrice de la machine",0,$C,0,0
db "Moranienne s'eteint et le silence revient.",0,$C,0,0
db "Une fumee huileuse s'eleve du complexe",0,$3C,0,0
db "souterrain du temple.",0,$FE,0
db 0
db "L'aeronef est secoue, mais sans degats!",$21,0,$08,0,0,0,$0C,$86
db 0
db "<CLIQUEZ>",0,$FF
Textblk02.MSG db 12 ;0C
db 0 ;00
db 0 ;00
db "La fin spectaculaire de la confrerie de",0,$C,0,0
db "Tarbos attire rapidement l'attention des",0,$5A,0,0
db "dirigeants des humains et des elfes.",0,$C,0
db 0
db "Vous les emmenez sur l'ile a dos",0,$C,0,0
db "d'aigle et leur expliquez ce qui s'est",0,$5A,0,0
db "reellement passe dans le temple.",0,$C,0
db 0
db "Vos aventures et l'existence d'une",0,$C,0,0
db "culture etrangere sur la lune desertique ont",0,$C,0,0
db "provoque des discussions agitees et des voix",0,$5A,0,0
db "hurlent a la guerre contre les moraniens!",0,$C,0
db 0
db "Mais vos poignantes histoires a propos des",0,$C,0,0
db "problemes de la race lezard calment tout le",0,$C,0,0
db "monde et les plans d'un traite de paix avec",0,$5A,0,0
db "la lune desertique voient le jour.",0,$C,0
db 0
db "Une delegation des iles Lyramioniques part",0,$C,0,0
db "avec vous sur Morag et commence a negocier",0,$C,0,0
db "avec le gouvernement provisoire qui s'est",0,$C,0,0
db "forme apres la destruction du conseil de",0,$5A,0,0
db "guerre.",0,$C,0
db 0
db "Valdyn reste a S'Angrila, ou les savants",0,$C,0,0
db "Moraniens cherchent un moyen de faire",0,$C,0,0
db "fonctionner le teleporteur des mondes du",0,$C,0,0
db "fin fond de la zone antique sur la lune",0,$5A,0,0
db "de Kire pour le renvoyer chez lui.",0,$C,0
db 0
db "Il fut decide que l'eau serait acheminee",0,$C,0,0
db "sur Morag en utilisant un gros aeronef de la",0,$C,0,0
db "flotte Moranienne, et bientot le jour de la",0,$FE,0,0
db "signature du traite de paix arrive...",0,$08,0,0,0,$0C,$86
db 0
db "<CLIQUEZ>",0,$FF

[dlfrsilver]

Originally Posted by Pyrdacor

In general you do:

Unpacking:
AmbermoonPack.exe UNPACK <the_amb_file> <output_path>

Packing:
AmbermoonPack.exe <format> <input_path> <the_amb_file>


Example:
AmbermoonPack.exe UNPACK 1Map_data.amb My/Files/For/1Map_data
AmbermoonPack.exe AMNP My/Files/For/1Map_data 1Map_data.amb

I see what the problem is. AmbermoonPack v1.0.6 for windows 32 bits doesn't work. the UNPACK command doesn't work or exist in this version.

[Pyrdacor]

Strange. I released 1.0.7 today. Should work.

[dlfrsilver]

Let me see.

[dlfrsilver]

Originally Posted by Pyrdacor

Strange. I released 1.0.7 today. Should work.

now it works ! v1.0.6 was not working, v1.0.7 works fine

[dlfrsilver]

Originally Posted by Pyrdacor

In general you do:

Unpacking:
AmbermoonPack.exe UNPACK <the_amb_file> <output_path>

Packing:
AmbermoonPack.exe <format> <input_path> <the_amb_file>


Example:
AmbermoonPack.exe UNPACK 1Map_data.amb My/Files/For/1Map_data
AmbermoonPack.exe AMNP My/Files/For/1Map_data 1Map_data.amb

Pyrdacor, the unpack command works, but the recompression doesn't work.
Basically, AmbermoonPack.exe never compress and never gives me back the hand.

Can you please check the problem ? Thanks

[Pyrdacor]

It might take quiet a while. Be patient. Especially the map data containers take several minutes to compress. Especially 1Map_data.amb as it has 256 50x50 maps.

My LOB compression does a good job in compressing but might not be the fastest one.

[Pyrdacor]

Did you try a smaller container yet?

[dlfrsilver]

Originally Posted by Pyrdacor

Did you try a smaller container yet?

OK thanks, i will then need to wait. but it is strange.

It's fast on xMAP_texts.amb files, and very slow on xMAP_data.amb files.

There's something wrong somewhere. It should be then slow on both type of files.

[Pyrdacor]

It depends. 1Map_texts.amb is only 5kB versus 525kB for the 1Map_data. So this is a factor of 100. If the text file needs 5 seconds, you will wait almost 9 and a half minute for the data file.

Maybe I can improve the LOB packer when I have some time for it. But I guess waiting for it isn't too bad as you won't do it that often. Except for me who currently fixes the Lyramion world map door bugs. :(((( But at least I found a way to make it happen.

[dlfrsilver]

Originally Posted by Pyrdacor

It depends. 1Map_texts.amb is only 5kB versus 525kB for the 1Map_data. So this is a factor of 100. If the text file needs 5 seconds, you will wait almost 9 and a half minute for the data file.

Maybe I can improve the LOB packer when I have some time for it. But I guess waiting for it isn't too bad as you won't do it that often. Except for me who currently fixes the Lyramion world map door bugs. ((( But at least I found a way to make it happen.

what i mean pyrdacor, is that big files _texts.amb are processed quickly, and not the other files. Very strange......

ah tell me, what type of bugs are you working on ? which place is it happening on lyramion ?

[Pyrdacor]

I work on several simultaneously. The doors to the temple of gala, crypt and Lebab's tower can be skipped with the broom or eagle. You can just dismount on the upper tile of the door and therefore skip the lock screen. It isn't much of a problem for the crypt and temple of gala as you won't have either of the items when you first enter. But it is for Lebab's tower and in theory you can get the broom or flute from the secret room before the mentioned locations.

I could fix the crypt and temple with my map editor and cli event editor. But Lebab's tower is a bit more complex as it triggers a battle on opening. Another bug I found while trying to fixing it is, that you can simply flee this battle and it won't happen a second time. So the gargoyles vanish.

I will try to fix both issues in one go. But only next week.

I also fixed two wrongly connected event chains. When you observe the sign of the Burnville healer a second popup is shown afterwards which is for some store. This was fixed. Moreover in the palace of S'Endar when you got hit by the spike traps a chest is shown afterwards. This is also fixed. You can copy map 447 (the palace) from my current bugfixes but not the Burnville map as it contains go-to point names which would destroy your translation. But you might take my fixed map and copy the text area over. The format can be found on my Ambermoon GitHub page.

I will also try to fix the wall stuck problem in Mera's cellar and in the Mine on Kire's moon.

Also the Lebab tower broom collision, avoiding broom smuggling onto Morag and finally we will try to fix some code bugs as well. For example the SP stealer bug is only a change of 1 byte as kermitfrog found out just today.

[alexh]

Originally Posted by dlfrsilver

ah tell me, what type of bugs are you working on ? which place is it happening on lyramion ?

The bugs for quite a while are all in xMap_data.amb. Very subtle bugs in the data structures. Pyradcor has the working knowledge of all Ambermoon map data structures and the tools to fix them. He's incredibly quick. Just not enough hours in the day at the moment.

Originally Posted by Pyrdacor

Finally we will try to fix some code bugs as well. For example the SP stealer bug is only a change of 1 byte as kermitfrog found out just today.

These bugs only affect the Amiga executables. Nice find. The 1-byte is probably not the same byte offset in each of the 4 files (AM2_CPU, AM2_BLT, DE/ENG)?

[Pyrdacor]

Originally Posted by alexh

These bugs only affect the Amiga executables. Nice find. The 1-byte is probably not the same byte offset in each of the 4 files (AM2_CPU, AM2_BLT, DE/ENG)?

That is no problem. We can find it easily with ghidra I guess. And often if you take a whole sequence of bytes around it, this is only existent once in both languages. It's all about identifying patterns.

The fix for the disease effect is also only one byte and I have great hopes that we even can fix the uncursing.

[dlfrsilver]

@AlexH : Please modify this bug entry, as otherwise it will cause problems in the amiga executables :

In the english v1.0x, it's labelled "MOTHER-OF-PEARL CHAI".

And this for a reason : Only 19 characters are allowed. Instead of this, replace in english by MOTHER PEARL CHAIN (18 characters).

MOTHER OF PEARL CHAIN is 20 characters, it's 1 character too long.

Check bellow in the ressourced part of the executable i have :

;Structure for Item or PLayer Statut named: MOTHER PEARL CHAIN
_OBJ_Start
_OBJ_ItemGFX $01
_OBJ_ItemType _ItemType_Brooch
_OBJ_Unknown $01,$00
_OBJ_Gender _USER_MaleAndFemale
_OBJ_Hands_Fingers $00,$00
_OBJ_LPMax_SPMax $00,$00
_OBJ_Attibute _AttributeType_Speed,$05
_OBJ_Ability _AbilityType_Attack,$00
_OBJ_Protection_Damage $00,$00
_OBJ_Unknown $00
_OBJ_Unknown $00,$00,$00,$00,$00,$00,$00,$00
_OBJ_Unknown $00,$00,$00,$00,$00,$00
_OBJ_MBR_MBW $00,$00
_OBJ_SpecialAttribute 1<<_ItemSpecialAttribute_Bit3
_OBJ_Unknown $00
_OBJ_Classes $7F,$FF
_OBJ_Price $00,$00
_OBJ_Weight $00,$C8
_OBJ_ItemName MOTHER PEARL CHAIN
_OBJ_End ; ******************* ; Guide for objet name length (19 letters max)

[alexh]

You can't use my comments to determine exactly how a bug fix was actually implemented. They are just notes. I've tried to be as accurate as possible but in some circumstances I've never seen the bugfix as a diff file.

In this case you need to get the latest AM2_CPU/BLT binary, decompress and find the string.

The person who fixed this knew 19 characters was the maximum string length for objects, so if what is written on the spreadsheet note is more than 19 characters then I've made a typo that's not what they actually did.

I've a feeling that Pyradcor has not changed this string in the English data files within Ambermoon.net

[dlfrsilver]

Originally Posted by alexh

You can't use my comments to determine how a bug fix was actually implemented. They are just notes.

When something is wrong, it has to be corrected.

You need to look at the latest AM2_CPU/BLT binary, decompress and find the string.

I have ressourced each program of Ambermoon since 2013 (and CFOU! helped me). Already done.

The person who fixed this knew 19 characters was the maximum string length for objects, so if what is written on the spreadsheet is more than 19 then I've made a typo that's not what they actually did.

That is not only in the notes on the Thalion Webshrine. I was not specifically targeting the excel spreadsheet.

I've a feeling that Pyradcor has not changed this string in the data files within Ambermoon.net

I don't know what Pyrdacor did on his side related to this. I have noticed a few hours ago the problem while reviewing back my ressourced files.

I have the executables fully ressourced. My point was that the original fix asking to change "Mother-of-pearl chai" to "Mother of pearl chain" is a bad idea, as it shifts the offset inside the executable by 1 byte (leading to bugs later in the game....).

i posted this simpled to get the note modified and updated. And nothing more.