ADFScan 1.8e - Page 4

TCD · 02 December 2010, 09:08

Also on the file server in 'Misc/Various/PC' now. Thanks barkingboy

prowler · 02 December 2010, 21:21

Thanks, barkingboy!

I had thought I'd never get another chance to see that file!

derSammler · 18 May 2014, 13:39

You can now download ADFScan and the source code of the last 1.9 beta version at:
http://oldstuff.amigabase.de/

I'm also going to make some of my other old Amiga projects open source.

Thalion · 18 May 2014, 14:28

Thats really nice

What older projects do you have btw?

derSammler · 18 May 2014, 16:26

Good question, but there were a few.

The most noteworthy other one is probably Project32, which was the first non-commercial CD32 emulator (based on WinUAE).

Dan · 14 August 2020, 18:46

Hi, i just took the AdfScan 19b1 sourcecode and compiled it with small changes.

The checkbox Quiet, Log only is now always checked.
There is a new button, Show log, which opens the log file with notepad.exe (didn't know how to open the extension without the executable, so it had to be notepad.exe)

I made a small change to the deepscan.dll - recompiled the sourcecode, the message box for extendend adf's does not show up anymore.

p.s. - The VB sourcecode had an missing label, which i had to place somewhere. It looks ok where it is now.

The changed sourcecode, the exe and the dll is attached. The exe only is downloadable in few posts later.

derSammler · 14 August 2020, 19:09

Nice that someone still cares. But what are the advantages of your changes?

Especially this:

Quote:

Originally Posted by Dan

I made a small change to the deepscan.dll - recompiled the sourcecode, the message box for extendend adf's does not show up anymore.

makes not much sense. ADFScan should never trigger that message, as it is not supposed to pass Extended ADFs to the DeepScan.dll. So you did actually disable a safety check for incorrect usage of the dll. Well, in the 1.9 beta it's actually the line:

If LOF(1) < 11264 Or LOF(1) > 923648 Then GoTo NextFile

which was commented out in the code for testing, but that should be in for any release version and will make sure it won't ever deal with non-standard ADFs.

Dan · 14 August 2020, 20:26

Quote:

ADFScan should never trigger that message, as it is not supposed to pass Extended ADFs to the DeepScan.dll

The message box was triggered few times in a row, here, even with "Quiet, Log only" turned on.

So i removed it, because it was annoying to click that ok button, while it actually displayed only an useless click away message.

The advantages are minor. I did not wanted to seek the log file, and i did not wanted to check that quiet scanning box every time.
And few times i did forget ...

derSammler · 14 August 2020, 20:29

Read the rest of my post coming after the sentence you quoted.

Correct way is to simply reactivate the commented-out line of code, not disabling the message in the dll.

Dan · 14 August 2020, 20:47

Ah, i see.

Thanks, iv compiled it again, now with this line added back.

(The new archive is uploaded few posts later, again)

derSammler · 14 August 2020, 21:56

btw, instead of hard-coding notepad.exe, you can simply issue the "start" command followed by the log file name. "start somefile.txt" will automatically open the associated application.

Some other ideas (apart from adding more virus sigs):
* save the state of the checkboxes to the registry, so it will remember the last user settings
* port it to .NET
* add a virus library with additional infos about the virus found (was always a planned feature)
* make DeepScan aware of the BitMap

Superman · 14 August 2020, 23:45

Thanks for the update I have used this program for a while now and its extremely useful when downloading files for the Gotek. One thing I have found though is that one of my own disks I made into an ADF flags up as having a virus on it but no other virus scanner on the amiga picks it up as such. I suspect it may be a false positive for the sinister syndicate virus.

derSammler · 15 August 2020, 09:03

Most likely a deleted file that was infected. Since DeepScan does not read the BitMap, it will scan all blocks and may report a false positive because of that, as the virus signature is still on the disk.

Dan · 15 August 2020, 10:07

I have some programming experience, mostly in Blitzbasic (pc), AutoIt3, Qbasic etc and few languages on the Amiga.
VB is not a Language which i would choose to use *1. Net ? Not !

You can imagine that i have compiled a VB program, yesterday, for the 5th/6th time, at most.

The start command does not exists in this version of VB (at least it is not in the help file), but i have found some script/function which calls the shell execute.
Iv added this change, and now the text editor assigned with .txt files will open.
(The exe and the vbp/frx is included in this archive)

And, for the improvements, these are great ideas (part from that i would use an ini file instead of the Registry).
But someone who has a better experiece with VB than me, should do them.

If it were up to me, i would convert the code to AutoIt, and continue from there.

*1 Sidenote: What is impressive with VB, is the filesize. The executable has as little as 86kb ...

derSammler · 15 August 2020, 10:09

Quote:

Originally Posted by Dan

The start command does not exists in this version of VB, but i have found some script/function which calls the shell execute.

That's because "start" is a Windows command.

You can issue it from VB using Shell().

Shell("start " & Chr(34) & App.Path & "" & LOGFILE & Chr(34))

should work.

(LOGFILE is a constant, no need to use the actual file name here)

Quote:

*1 Sidenote: What is impressive with VB, is the filesize. The executable has as little as 86kb ...

True, but it requires the MSVBVM50.DLL runtime dll, as the .exe is pure bytecode only.

Dan · 15 August 2020, 10:38

Quote:

Shell("start " & Chr(34) & App.Path & "" & LOGFILE & Chr(34))

Hmm, the Shell + start command just won't do it. Neither on XP nor on Win10.

And if i replace the filename with the LOGFILE, the shellexecute opens the folder instead of the file.

derSammler · 15 August 2020, 10:44

The forum ate the backslash.

Shell("start " & Chr(34) & App.Path & "\" & LOGFILE & Chr(34))

Dan · 15 August 2020, 10:50

I was copying the code from your script (anyway), so the backslash was included.

The Shell command does not want to open the start, and app crashes with file not found.

I have tested it as Shell ("start") only, it is the same.

derSammler · 15 August 2020, 10:51

What version of VB are you using? Works fine with VB 5.0 Pro on Windows 7.

derSammler · 15 August 2020, 10:54

Please try:

Shell("cmd /c start " & Chr(34) & App.Path & "\" & LOGFILE & Chr(34))

This would break Win9x compatibility, however.

18 May 2014, 16:26	#65
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	Good question, but there were a few. The most noteworthy other one is probably Project32, which was the first non-commercial CD32 emulator (based on WinUAE). Last edited by derSammler; 18 May 2014 at 20:30.

14 August 2020, 18:46	#66
Dan Registered User Join Date: Nov 2004 Location: Germany Posts: 629	Hi, i just took the AdfScan 19b1 sourcecode and compiled it with small changes. The checkbox Quiet, Log only is now always checked. There is a new button, Show log, which opens the log file with notepad.exe (didn't know how to open the extension without the executable, so it had to be notepad.exe) I made a small change to the deepscan.dll - recompiled the sourcecode, the message box for extendend adf's does not show up anymore. p.s. - The VB sourcecode had an missing label, which i had to place somewhere. It looks ok where it is now. The changed sourcecode, the exe and the dll is attached. The exe only is downloadable in few posts later. Last edited by Dan; 14 August 2020 at 20:48.

14 August 2020, 20:47	#70
Dan Registered User Join Date: Nov 2004 Location: Germany Posts: 629	Ah, i see. Thanks, iv compiled it again, now with this line added back. (The new archive is uploaded few posts later, again) Last edited by Dan; 15 August 2020 at 09:59.

02 December 2010, 09:08	#61
TCD HOL/FTP busy bee Join Date: Sep 2006 Location: Germany Age: 46 Posts: 31,522	Also on the file server in 'Misc/Various/PC' now. Thanks barkingboy

02 December 2010, 21:21	#62
prowler Global Moderator Join Date: Aug 2008 Location: Sidcup, England Posts: 10,300	Thanks, barkingboy! I had thought I'd never get another chance to see that file!

18 May 2014, 13:39	#63
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	You can now download ADFScan and the source code of the last 1.9 beta version at: http://oldstuff.amigabase.de/ I'm also going to make some of my other old Amiga projects open source.

18 May 2014, 14:28	#64
Thalion Amiga Collector Join Date: Jan 2005 Location: Germany Age: 41 Posts: 679	Thats really nice What older projects do you have btw?

14 August 2020, 20:29	#69
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	Read the rest of my post coming after the sentence you quoted. Correct way is to simply reactivate the commented-out line of code, not disabling the message in the dll.

14 August 2020, 21:56	#71
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	btw, instead of hard-coding notepad.exe, you can simply issue the "start" command followed by the log file name. "start somefile.txt" will automatically open the associated application. Some other ideas (apart from adding more virus sigs): * save the state of the checkboxes to the registry, so it will remember the last user settings * port it to .NET * add a virus library with additional infos about the virus found (was always a planned feature) * make DeepScan aware of the BitMap

14 August 2020, 23:45	#72
Superman Super Member Join Date: Sep 2014 Location: Wakefield Age: 48 Posts: 1,334	Thanks for the update I have used this program for a while now and its extremely useful when downloading files for the Gotek. One thing I have found though is that one of my own disks I made into an ADF flags up as having a virus on it but no other virus scanner on the amiga picks it up as such. I suspect it may be a false positive for the sinister syndicate virus.

15 August 2020, 09:03	#73
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	Most likely a deleted file that was infected. Since DeepScan does not read the BitMap, it will scan all blocks and may report a false positive because of that, as the virus signature is still on the disk.

15 August 2020, 10:44	#77
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	The forum ate the backslash. Shell("start " & Chr(34) & App.Path & "\" & LOGFILE & Chr(34))

15 August 2020, 10:50	#78
Dan Registered User Join Date: Nov 2004 Location: Germany Posts: 629	I was copying the code from your script (anyway), so the backslash was included. The Shell command does not want to open the start, and app crashes with file not found. I have tested it as Shell ("start") only, it is the same.

15 August 2020, 10:51	#79
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	What version of VB are you using? Works fine with VB 5.0 Pro on Windows 7.

15 August 2020, 10:54	#80
derSammler Senior Member Join Date: Jun 2001 Location: Germany Posts: 1,645	Please try: Shell("cmd /c start " & Chr(34) & App.Path & "\" & LOGFILE & Chr(34)) This would break Win9x compatibility, however.

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)