Calling assembly from C++, values returned on stack

[deimos]

I'm trying to relearn C++ after more than 20 years of being smart enough to not touch it.

I'm trying to write a wrapper around Motorola's 68343 floating point code, just to see if I can make it transparently supported as if it was part of the language, and maybe, possibly, improving on what's in mathffp.library and amiga.lib.

What I have works, mostly, but I'm getting weirdness when I convert to ascii.

This is with the bartman vscode environment, so I don't have amiga.lib and the fpa function in it, but I do have the FFPFPA function from Motorola, so I'm doing this:

    inline void fpa(char * const buffer, const FFP value) {
        __asm volatile (
            "       movel   %[value], %%d7              \n"
            "                                           \n"
            "       jsr     FFPFPA                      \n"
            "                                           \n"
            "       moveal  %%sp, %%a0                  \n"
            "       moveal  %[buffer], %%a1             \n"
            "       moveq   #13, %%d7                   \n"
            "1:     moveb   (%%a0)+, (%%a1)+            \n"
            "       dbra    %%d7, 1b                    \n"
            "       moveb   #0, (%%a1)                  \n"
            "       lea     (14, %%sp), %%sp            \n"

            : // outputs
            
            : // inputs
                [value] "g" (value),
                [buffer] "g" (buffer)
            
            : // clobbers
                "d7", "a0", "a1",
                "cc"
        );
    }

The interface to FFPFPA is:

*                     FFPFPA                          *
*                 FLOAT TO ASCII                      *
*                                                     *
*    INPUT:  D7 - FLOATING POINT NUMBER               *
*                                                     *
*    OUTPUT: D7 - THE BASE TEN EXPONENT IN BINARY     *
*                 FOR THE RETURNED FORMAT             *
*            SP - DECREMENTED BY 14 AND               *
*                 POINTING TO THE CONVERTED           *
*                 NUMBER IN ASCII FORMAT              *
*                                                     *
*            ALL OTHER REGISTERS UNAFFECTED           *
*                                                     *
*    CONDITION CODES:                                 *
*            N - SET IF THE RESULT IS NEGATIVE        *
*            Z - SET IF THE RESULT IS ZERO            *
*            V - CLEARED                              *
*            C - CLEARED                              *
*            X - UNDEFINED                            *

Trouble is, it's not working. Some values seem to work ok, others just return an empty string.

Can anyone check the wrapper code above?

[Samurai_Crow]

Have you tried extern "C" {} in your header? C++ has hidden members like a "this" pointer in them.

[deimos]

Originally Posted by Samurai_Crow

Have you tried extern "C" {} in your header? C++ has hidden members like a "this" pointer in them.

That doesn't seem to help, and the bit where the problem appears doesn't deal with any objects. Also, I've now discovered that my code just blows up if I remove one of my debugging print statements, so maybe I've just written a bunch of junk that can never work.

[deimos]

Found it. Fixed it.