Open-source dos.library - Page 3

_mandark_ · 26 July 2011, 01:19

Quote:

Originally Posted by Don_Adan

Next version is available.
Next my bug fixed, more routines reworked to ASM or optimised.

This is the first version which boots properly into Workbench on my machine. Running well, no issues so far..

mfilos · 26 July 2011, 08:57

A lot better than last time but on my custom 3.9 kickstart loading Workbench 3.9 (using this new dos.library) gives the following error lines:

Code:

BindDrivers: Unknown command
SetEnv: not enough memory available
SetEnv: not enough memory available
SetEnv: not enough memory available
object not found
object not found

... after these lines workbench boots okey but with 4 colors (instead of 16) and missing every visual customization.

daxb · 26 July 2011, 11:28

Booting starts (at least some lines after SetPatch) but got MuForce hits (started in S-S) and system freeze.

Don_Adan · 26 July 2011, 12:52

Next version is available.
Some changes, more routines converted to ASM.

mfilos · 26 July 2011, 13:42

Constant reboots in blank screen with the new one

_mandark_ · 26 July 2011, 20:52

Quote:

Originally Posted by mfilos

Constant reboots in blank screen with the new one

I can confirm this. Additionally I get after each reboot:

--------------------------------------------------------------------------------
Date : Tuesday 26-Jul-11 01:10:59
Task : 0828BDC8 "Shell Process"
Error : 80000038 (DEADEND)
By : System: no alert occured
Cause : MMU configuration error
--------------------------------------------------------------------------------

PeterK · 27 July 2011, 01:52

@Don_Adan
Guru: dos.library, file handle closed twice

And I ask you again, please update the revision number of the dos.library and add your build number to Lib_ID string. Thank you!

Or, do you prefer comments like Dos31_new works pretty well, but the latest Dos31_new just crashes. Let's see what the next Dos31_new will do ??

BuZz · 27 July 2011, 01:55

would be nice with diffs between each release. due to the "nature" of this project, you could always just use rcs on your amiga, or host a local svn server on a pc or something.

Don_Adan · 27 July 2011, 16:28

Next version is available, more routines converted to ASM, reboot problem perhaps solved.

Don_Adan · 27 July 2011, 16:59

Quote:

Originally Posted by PeterK

@Don_Adan
Guru: dos.library, file handle closed twice

And I ask you again, please update the revision number of the dos.library and add your build number to Lib_ID string. Thank you!

Or, do you prefer comments like Dos31_new works pretty well, but the latest Dos31_new just crashes. Let's see what the next Dos31_new will do ??

I made many changes/bugs inside source. At first I must fix all my bugs and understanding how the code works, I hope that new version can works. Which revision is OK for you? For me every version which don't works 100% correctly is still beta only. But I put it online, mostly for finding my or original library bugs and for checking my code optimisations.

BuZz · 27 July 2011, 17:01

Quote:

Originally Posted by Don_Adan

Which revision is OK for you?

I guess that's the issue.

any comments regarding my source control stuff above?

_mandark_ · 27 July 2011, 20:56

Quote:

Originally Posted by Don_Adan

Next version is available, more routines converted to ASM, reboot problem perhaps solved.

Nope, reboot problem is still there.

Ezrec · 28 July 2011, 00:16

Quote:

Originally Posted by Don_Adan

Resourcing code and understanding the code are two different things for me. Especialy code written in C, anyway I started to find and optimise dos routines one after one. Here is the one of the shortest, maybe useful for someone:

; SYNOPSIS
; status = IsInteractive( file )
; D0 D1
;
; BOOL IsInteractive(BPTR)

lbC0222DA ; _LVOIsInteractive
; MOVE.L D7,-(SP)
; MOVE.L D1,D7
; MOVE.L D7,D0
; ASL.L #2,D0
; MOVEA.L D0,A0
; MOVE.L (4,A0),D1
; MOVE.L D1,D0
; MOVE.L (SP)+,D7

asl.l #2,D1
move.l D1,A0
move.l 4(A0),D0

RTS

Evidently GCC doesn't suck too hard these days.

From AROS m68k:

Code:

(gdb) x /10i Dos_36_IsInteractive 
   0xf9427c <Dos_36_IsInteractive>:	moveal %d1,%a0
   0xf9427e <Dos_36_IsInteractive+2>:	addal %d1,%a0
   0xf94280 <Dos_36_IsInteractive+4>:	movel %a0@(0000000000000004,%a0:l),%d0
   0xf94284 <Dos_36_IsInteractive+8>:	rts

NovaCoder · 28 July 2011, 01:58

Quote:

Originally Posted by Don_Adan

I made many changes/bugs inside source. At first I must fix all my bugs and understanding how the code works, I hope that new version can works. Which revision is OK for you? For me every version which don't works 100% correctly is still beta only. But I put it online, mostly for finding my or original library bugs and for checking my code optimisations.

Even BETA's need version numbers

Don_Adan · 28 July 2011, 12:12

Quote:

Originally Posted by BuZz

I guess that's the issue.

any comments regarding my source control stuff above?

I don't know english and I'm too lazy.

Don_Adan · 28 July 2011, 12:28

Quote:

Originally Posted by Ezrec

Evidently GCC doesn't suck too hard these days.

From AROS m68k:

Code:

(gdb) x /10i Dos_36_IsInteractive 
   0xf9427c <Dos_36_IsInteractive>:    moveal %d1,%a0
   0xf9427e <Dos_36_IsInteractive+2>:    addal %d1,%a0
   0xf94280 <Dos_36_IsInteractive+4>:    movel %a0@(0000000000000004,%a0:l),%d0
   0xf94284 <Dos_36_IsInteractive+8>:    rts

AROS version looks better for this one, I added also check if input D1 is equal zero.
Here is my version of FreeDos object routine:

Code:

; _LVOFreeDosObject (final version)
; input   D1/D2
; output  D0 ?
; changed D0/D1/A0/A1

;    MOVEM.L    D2/D7/A3,-(SP)
;    MOVEA.L    D2,A3
;    MOVE.L    D1,D7
;    MOVE.L    A3,D0
;    BEQ.B    lbC022B5E
;    MOVEQ    #6,D0
;    CMP.L    D0,D7
;    BCC.B    lbC022B5E
;    MOVE.L    D7,D0
;    SUBQ.L    #3,D0
;    BEQ.B    lbC022B48
;    SUBQ.L    #1,D0
;    BEQ.B    lbC022B56
;    BRA.B    lbC022B4E

;lbC022B48    MOVEA.L    A3,A3
;    SUBA.W    #$14,A3
;lbC022B4E    MOVEA.L    A3,A1
;    JSR    (FreeVec,PC)
;    BRA.B    lbC022B5E

;lbC022B56    MOVEQ    #0,D0
;    MOVEA.L    A3,A0
;    JSR    (lbC026728,PC)
;lbC022B5E    MOVEM.L    (SP)+,D2/D7/A3
;    RTS

QuitFDO
    rts

FreeDosObject
    move.l    D2,D0
    beq.b    QuitFDO
    moveq    #6,D0
    cmp.l    D0,D1
    bcc.b    QuitFDO
    subq.l    #3,D1
    beq.b    Free1FDO
    subq.l    #1,D0
    bne.b    Free2FDO
    moveq    #0,D0
    move.l    D2,A0
    bra.w    lbC026728
Free1FDO
    moveq    #$14,D0
    sub.l    D0,D2
Free2FDO
    move.l    D2,A1
    bra.w    FreeVec

and FindDosEntry:

Code:

; _LVOFindDosEntry (final version)
; input   D1/D2/D3
; output  D0
; changed D0/D1/A0/A1

;FindDosEntry    MOVEM.L    D2/D3/A2/A3,-(SP)    ; _LVOFindDosEntry
;    MOVEA.L    D2,A3
;    MOVEA.L    D1,A2
;    MOVE.L    A2,D0
;    BTST    #0,D0
;    BEQ.B    lbC02481E
;    MOVE.L    A2,D0
;    SUBQ.L    #1,D0
;    MOVEA.L    D0,A2
;    BRA.B    lbC02481E

;lbC0247EA
;    LEA    (lbB02819D),A0
;    ADDA.L    (4,A2),A0
;    MOVEQ    #0,D0
;    MOVE.B    (A0),D0
;    AND.L    D3,D0
;    BEQ.B    lbC024818
;    MOVE.L    A3,D0
;    BEQ.B    lbC024822
;    MOVE.L    ($28,A2),D0
;    ASL.L    #2,D0
;    MOVEA.L    D0,A0
;    LEA    (1,A0),A1
;    MOVEA.L    A1,A0
;    MOVEA.L    A3,A1
;    JSR    (Stricmp,PC)
;    TST.B    D0
;    BEQ.B    lbC024822
;lbC024818    MOVE.L    (A2),D0
;    ASL.L    #2,D0
;    MOVEA.L    D0,A2
;lbC02481E    MOVE.L    A2,D0
;    BNE.B    lbC0247EA
;lbC024822    MOVE.L    A2,D0
;    MOVEM.L    (SP)+,D2/D3/A2/A3
;    RTS

FindDosEntry
    move.l    D2,D0
    beq.b    QuitFDE
    move.l    A2,-(SP)
    move.l    D1,A2
    btst    #0,D1
    beq.b    EvenFDE
    subq.w    #1,A2
    bra.b    EvenFDE
NextFDE
    move.l    (A2),A2
    add.l    A2,A2
    add.l    A2,A2
EvenFDE
    move.l    A2,D0
    beq.b    ExitFDE
    move.w    4+2(A2),D1
    move.b    lbB02819D(PC,D1.W),D1
    and.b    D3,D1
    beq.b    NextFDE
    move.l    $28(A2),A0
    add.l    A0,A0
    add.l    A0,A0
    addq.w    #1,A0
    move.l    D2,A1
    bsr.w    Stricmp
    tst.l    D0
    bne.b    NextFDE
    move.l    A2,D0
ExitFDE
    move.l    (SP)+,A2
QuitFDE
    rts

    dc.b    0
lbB02819D
    dc.b    4
    dc.b    $10
    dc.b    8
    dc.b    $10
    dc.b    $10
    dc.b    0
    dc.b    0

Maybe someone want to check for my bugs or possible size optimisations?

BuZz · 28 July 2011, 22:00

Quote:

Originally Posted by Don_Adan

I don't know english and I'm too lazy.

you seem to be writing English now

the time you will save by using some source revision software will outweigh any time to set it up. the ability to roll back, extract diffs between specific versions etc, and track down when issues occurred more easily. Also things like branching off to try something and then merging back and so on.

Don_Adan · 01 August 2011, 12:34

Next version of dos library is available.

All (?) my bugs are fixed.
Library version (temporary) changed for LoadModule and ROM 3.1 users.
More size optimisation.
Every "Final version" routine has date (creation or last modification).
This version was tested a few on my A4000T from floppy drive (using
from hard drives can be dangerous, if I made something wrong or missing
something important). Seems works "as is".

_mandark_ · 01 August 2011, 21:47

Runs fine on my machine, without obvious issues so far. Well done!

Don_Adan · 02 August 2011, 12:32

Next version is available.
Next my bug fixed, thanks to meynaf for help.
Reworked AllocDosObject routine, original seems to be buggy or uses no sense code (access to GetTagData).

26 July 2011, 08:57	#42
mfilos Paranoid Amigoid Join Date: Mar 2008 Location: Athens/Greece Age: 45 Posts: 1,978	A lot better than last time but on my custom 3.9 kickstart loading Workbench 3.9 (using this new dos.library) gives the following error lines: Code: BindDrivers: Unknown command SetEnv: not enough memory available SetEnv: not enough memory available SetEnv: not enough memory available object not found object not found ... after these lines workbench boots okey but with 4 colors (instead of 16) and missing every visual customization.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Open source CLI commands	Mrs Beanbag	Coders. System	13	10 December 2016 09:50
Open-source graphics library	Don_Adan	Coders. System	32	15 January 2013 22:15
dos.library Open() hangs	MrD	Coders. Asm / Hardware	15	24 July 2012 19:55
NewsRog goes Open Source	Paul	News	0	04 December 2004 16:37
BlitzBasic - Is now open source	Djay	Amiga scene	2	08 February 2003 01:09

26 July 2011, 11:28	#43
daxb Registered User Join Date: Oct 2009 Location: Germany Posts: 3,304	Booting starts (at least some lines after SetPatch) but got MuForce hits (started in S-S) and system freeze.

26 July 2011, 12:52	#44
Don_Adan Registered User Join Date: Jan 2008 Location: Warsaw/Poland Age: 55 Posts: 1,975	Next version is available. Some changes, more routines converted to ASM.

26 July 2011, 13:42	#45
mfilos Paranoid Amigoid Join Date: Mar 2008 Location: Athens/Greece Age: 45 Posts: 1,978	Constant reboots in blank screen with the new one

27 July 2011, 01:52	#47
PeterK Registered User Join Date: Apr 2005 Location: digital hell, Germany, after 1984, but worse Posts: 3,377	@Don_Adan Guru: dos.library, file handle closed twice And I ask you again, please update the revision number of the dos.library and add your build number to Lib_ID string. Thank you! Or, do you prefer comments like Dos31_new works pretty well, but the latest Dos31_new just crashes. Let's see what the next Dos31_new will do ??

27 July 2011, 01:55	#48
BuZz Registered User Join Date: May 2002 Location: Oxford / UK Age: 47 Posts: 583	would be nice with diffs between each release. due to the "nature" of this project, you could always just use rcs on your amiga, or host a local svn server on a pc or something.

27 July 2011, 16:28	#49
Don_Adan Registered User Join Date: Jan 2008 Location: Warsaw/Poland Age: 55 Posts: 1,975	Next version is available, more routines converted to ASM, reboot problem perhaps solved.

01 August 2011, 12:34	#58
Don_Adan Registered User Join Date: Jan 2008 Location: Warsaw/Poland Age: 55 Posts: 1,975	Next version of dos library is available. All (?) my bugs are fixed. Library version (temporary) changed for LoadModule and ROM 3.1 users. More size optimisation. Every "Final version" routine has date (creation or last modification). This version was tested a few on my A4000T from floppy drive (using from hard drives can be dangerous, if I made something wrong or missing something important). Seems works "as is".

01 August 2011, 21:47	#59
_mandark_ Registered User Join Date: May 2011 Location: Funeralopolis Posts: 91	Runs fine on my machine, without obvious issues so far. Well done!

02 August 2011, 12:32	#60
Don_Adan Registered User Join Date: Jan 2008 Location: Warsaw/Poland Age: 55 Posts: 1,975	Next version is available. Next my bug fixed, thanks to meynaf for help. Reworked AllocDosObject routine, original seems to be buggy or uses no sense code (access to GetTagData).

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)