[PROJECT] ProTracker v2.3D clone for modern platforms

[8bitbubsy]

Could a mod please change the topic title to:
[PROJECT] ProTracker 2 clone for modern platforms

Thanks

[Angus]

I've just tried messing about with this, and it is brilliant. Sorry if this is a stupid question, but looking at the .ini file it should default to the program directory for disk ops, but instead it goes to C:/user/angus - I changed the directory in the .ini file but it still went to the same place and...........


.....hang on, is this an Admin user thing?

I'll have a look at that. :-) Hmmmm...... I selected properties and set the program to Admin but it still insists on using the same directory. I should probably add this is Win 10.

[8bitbubsy]

It doesn't require admin rights. I did a test myself:
DEFAULTDIR=C:\Users\Olav\Documents\hi test\modules
SMPDIR=C:\Users\Olav\Documents\hi test\samples

And it works like it should for me. When I open the PT2 clone it's initially inside that directory I wrote.
I have no idea if this is possibly an UAC kind of problem. I have always disabled UAC on my Windows 10 setups.

Are you on the latest version? And you should also not use quotes for the path in the config.

[Angus]

Yes, I just downloaded it a week or two ago. Can you make the default directory on another drive/partition apart from C? I have put your program on my M: partition with my other music stuff. But it always looks in C:/user for some reason.

I hope I'm not doing something stupid, but it is entirely possible. :-)

[8bitbubsy]

It will initially stay in the current user's directory per default, if the path(s) in the config were not present, or couldn't be accessed.

I tested with another drive in protracker.ini:
DEFAULTDIR=D:\test 2\test 3

It worked fine here.
Also yes, you're right, there's some invalid text in the config... "Comment: If it is blank, then it will use the current dir.".
This is not correct anymore. It will initially try the user's directory if no custom paths were set in the config.

What you need to do is to change DEFAULTDIR in protracker.ini. You can't just copy the EXE to a directory and have it use that dir initially.

[Angus]

Got it! :-)

Many thanks, it's working now.

Just a thought, does it accept the label rather than the device letter, like

DEFAULTDIR=DATA 2:\MUSIC\

I couldn't make that work.

I understood drive letters were dynamically assigned.

[8bitbubsy]

I don't think that works, no. This is not a normal way of accessing drives in Windows, and drives can have the same volume labels, etc.

[Angus]

Okay, thanks for your time - and very many thanks for your work on this program. :-)

[8bitbubsy]

I'm glad you like it. :>

[no9]

@8bitbubsy on Windows7 after waking up computer from sleep mode keyrepeat goes crazy fast. It gets back to normal after a while, but requires to wait until that.

[8bitbubsy]

Not sure how to fix that, but I'm pretty sure it's related to either vsync or the fake "wait for vsync" function which uses performance counters.

[8bitbubsy]

PT2 clone v1.32 released: https://16-bits.org/pt2.php | Changelog: https://github.com/8bitbubsy/pt2-clo...ases/tag/v1.32

no9: This didn't fix your issue, but I released a new version today anyway.

[8bitbubsy]

PT2 clone v1.34 released: https://16-bits.org/pt2.php | Changelog (check v1.33 and v1.34): https://16-bits.org/pt2-clone-changelog.txt

Some nice changes in v1.33 and v1.34, in my opinion.

[frakswe]

Thanks, "compiled out of the box" for OpenBSD with a mere "-DCMAKE_C_FLAGS="-I/usr/local/include". Hats off for your effort in making it multiplatform.

[no9]

Thanks for updating it 8bitbubsy!

I have issue with two monitor setup: it always starts on main screen and when I move it manually to secondary monitor it gets back to the origin after using F11 twice (when it is used to quit fullscreen mode, because it opens fullscreen on correct screen).

[8bitbubsy]

Originally Posted by no9

Thanks for updating it 8bitbubsy!

I have issue with two monitor setup: it always starts on main screen and when I move it manually to secondary monitor it gets back to the origin after using F11 twice (when it is used to quit fullscreen mode, because it opens fullscreen on correct screen).

Yes, multi-monitor setup is buggy with my tracker clones. I don't know how to fix it, it's not simple.

[paraj]

Originally Posted by 8bitbubsy

Yes, multi-monitor setup is buggy with my tracker clones. I don't know how to fix it, it's not simple.

As it's your software/time at stake and I might be missing crucial details, so fell free to disregard the below.

I think it's because toggleFullScreen in pt2_visuals.c does this in line 2307

SDL_SetWindowPosition(video.window, SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED);

SDL_WINDOWPOS_CENTERED will center the window on the first monitor (https://stackoverflow.com/a/41746429/786653)

I think if you use SDL_GetWindowPosition to save the old position before switching to fullscreen and then use the values returned there instead when calling SDL_SetWindowPosition the window should return to its old position (even on another monitor).

Again there might be good reasons you wouldn't want to do this (and it gets more complicated if you always want to center the window when returning from fullscreen), so take it FWIW.

[squidbass]

I'm a huge FreeBSD fan, they've had a Protracker clone (& a FastTracker clone) for a few years now. Both are accurate.

[8bitbubsy]

Originally Posted by paraj

As it's your software/time at stake and I might be missing crucial details, so fell free to disregard the below.

I think it's because toggleFullScreen in pt2_visuals.c does this in line 2307

SDL_SetWindowPosition(video.window, SDL_WINDOWPOS_CENTERED, SDL_WINDOWPOS_CENTERED);

SDL_WINDOWPOS_CENTERED will center the window on the first monitor (https://stackoverflow.com/a/41746429/786653)

I think if you use SDL_GetWindowPosition to save the old position before switching to fullscreen and then use the values returned there instead when calling SDL_SetWindowPosition the window should return to its old position (even on another monitor).

Again there might be good reasons you wouldn't want to do this (and it gets more complicated if you always want to center the window when returning from fullscreen), so take it FWIW.

Seems like you are right, so it's simple indeed. I just assumed it wasn't because multi-monitor + SDL = the horror, I've had so much bad experiences with it. I might remove the centering of the window itself, it's not hugely important.

[no9]

May I also ask to change the warning that pops up while 22khz+ sample is loaded? I think this is useful but for for samples that actually exceeds Protrackers frequency boundaries, that is above B3 note.