ReadArgs and wildcard expansion

[alancfrancis]

Hi,

Just getting back into Amiga Programming and C on my A1200/3.1.4 after almost 30 years. I have a question for more experienced hands though.

I'm working on a super minimal native git implementation, just enough to be able to add some files, commit and push/pull to GitHub for now, to make it easier to work across my Mac and Amiga with VBCC.

As I go through the many rounds of Yak shaving just figuring out *how* things work, I've hit what seemed a weird one.

git_add #?.c

. with a template of

FILES/M/A

. comes through to

ReadArgs

as a single item -

#?.c

. I can't see any obvious system function to expand wildcards relative to the

GetCurrentDir

so I figured maybe this just wasn't a thing.

I noticed that, e.g.

type #?.txt

does the right thing though.

So... either someone has to write all that code to walk the directory and PatternMatch the strings in every single tool, again and again, or there's some trick I'm missing either in the CLI or in the code to make this work the way I expect.

Any help or suggestions (or the source code for the TYPE command :-) welcomed.

Alan

[phx]

Originally Posted by alancfrancis

So... either someone has to write all that code to walk the directory and PatternMatch the strings in every single tool

This. Allocate an AnchorPath object. Then MatchFirst() and MatchNext() are your friends.
Only a Unix shell automatically expands such patterns, before passing them to the application.

[alancfrancis]

@phx. Damn. I was afraid of that. :-) Thanks.

I might try and make the code into a little reusable library cause I'll need it for some other git commands. I was spoiled by Ruby's Dir.glob

[alancfrancis]

Aha, I just reread and I didn't know about AnchorPath/MatchXXX so that's actually much easier than I was thinking with Examine and recursing and pattern matching each string myself. :lightbulb: Thanks again @phx.

[bebbo]

Originally Posted by alancfrancis

Aha, I just reread and I didn't know about AnchorPath/MatchXXX so that's actually much easier than I was thinking with Examine and recursing and pattern matching each string myself. :lightbulb: Thanks again @phx.

you might also consider

int scandir(const char *dirname,struct dirent ***namelist,
    int (*select)(const struct dirent *),
    int (*dcomp)(const struct dirent **, const struct dirent **))

https://man7.org/linux/man-pages/man3/scandir.3.html

which is provided by libnix

PS: I hope it's working^^

[alancfrancis]

Thanks @bebbo, I am trying as best I can to not rely on anything other than standard amiga APIs because I am a masochist. :-)

[nyteshade]

Not completely related to your post, but I have a small personal wiki usually used for my own purposes but did a RDArgs post you might find interesting. It’s just a way of using it that doesn’t rely on setting #defines for variable storage index markers.

Would be curious what you think. Or any pointers you might have.

https://nyteshade.com:3443/amiga-rdargs


Sent from my iPhone using Tapatalk

[thomas]

Originally Posted by nyteshade

Would be curious what you think. Or any pointers you might have.

Two comments about your "Working Example":

You do not need to allocate a RDArgs structure if you want to read args from the command line, you can supply a NULL pointer to ReadArgs. A pre-allocated RDArgs is only needed if you want to parse a string in memory.

It does not make much sense to create a memory pool if you allocate only one chunk of memory. And of course the arguments array can be held on the stack, you do not need to allocate it.

[nyteshade]

Thanks for the feedback. I was going to do an extra piece on the extra help portion as well to indicate how you can print out additional usage info if you supply a second ? to template string prompt in the shell.

You’re right that the pool of memory is wasteful here; it’s a habit of mine to play with pools of late.


Sent from my iPhone using Tapatalk