FS-UAE Launcher crashes while scanning for files

[Dic_Ray]

Under Windows 7 this version crashes every time I scan my folder with all Amiga files. 2.1.27dev2 crashes too. Mac OS X version seems to run fine. Could you imagine to also support the Amiga Forever rp9 format? All the best for you.

[FrodeSolheim]

Originally Posted by Dic_Ray

Under Windows 7 this version crashes every time I scan my folder with all Amiga files. 2.1.27dev2 crashes too. Mac OS X version seems to run fine.

Perhaps it doesn't technically crash? Do you get an error message? If so, can you post a screenshot or something? And please also attach Launcher.log.txt to a post!

[Dic_Ray]

In the attachement, there is the error message, which says, that FS-UAE Launcher doesn't react anymore and that the program isn't executed right caused by a problem. (and ... "The prgram will be closed an you will be informed, when a solution is available.")

Also I attached my Launcher.log.txt. Under Mac OS X 10.8.2 I didn't get an error. Scanning my whole folder with Amiga related data worked.

Perhaps there are corrupted files, Windows version can't handle.

I look forward, to see a further great version from you.

Best regards

Originally Posted by FrodeSolheim

Perhaps it doesn't technically crash? Do you get an error message? If so, can you post a screenshot or something? And please also attach Launcher.log.txt to a post!

[FrodeSolheim]

Does the Germain error message correspond to:
- "The program does not respond any more"..., (i.e. it hangs) or
- "The program has performed an illegal operation" (it has crashed)
?

Does it seem like it crashes/hangs in the exact same spot every time? (The same file, or is it random how far in the scan process it gets?).

[TCD]

"This program doesn't function anymore" -> It will be closed.

[FrodeSolheim]

Actually, I did understand the German more or less, but it wasn't really clear from the text along when this message appears in Windows/German (When the program does not respond anymore and will be closed, or when the program has done something illegally and will be closed). But it sounds a bit more like that latter!

[TCD]

The latter indeed. The 'program doesn't respond' -> hangs message is different.

[Dic_Ray]

Originally Posted by FrodeSolheim

Does the Germain error message correspond to:
- "The program does not respond any more"..., (i.e. it hangs) or
- "The program has performed an illegal operation" (it has crashed)
?

Does it seem like it crashes/hangs in the exact same spot every time? (The same file, or is it random how far in the scan process it gets?).

After scanning a lot of data it doesn't respond anymore, but every time on different files. So it is random how far in the scan process. Any glue?
In Mac OS X version it scans the same data with success.

Thank you soo much, you are a genius.

[TCD]

Here it works with over 80k files:



That's on Windows 8 64-bit. How long does it take before that error message appears?

[Dic_Ray]

Originally Posted by TheCyberDruid

Here it works with over 80k files:



That's on Windows 8 64-bit. How long does it take before that error message appears?

Sorry for my late reply.

Here you can see, how long it takes and that it crashes randomly, but always on lha files. So I guess, there could be something wrong with the lha-scan code in the fs-uae windows version, couldn't it?

Please Frode could you help with that.

Btw. please would you add Hard'n Heavy and Twin World?

Best

[FrodeSolheim]

I've tried to make it crash but without success. It looks like it crashes when scanning WHDLoad-installers, so I donwload a couple and scanned them on Windows XP... it worked.

It could of course be a crash in the LHA library if the file cannot be opened or something like that, perhaps it's not readable by you user? I'll check in the code if that could be a problem.

(PS: Heard 'n' Heavy is added to the database now, Twinworld was already there )

[Dic_Ray]

Hello Frode,

I tried it again, set file permissions to full access, but got same result. Wonder why it works under Mac OS X?

Thanks for Hard 'n' Heavy.

Best

Originally Posted by FrodeSolheim

I've tried to make it crash but without success. It looks like it crashes when scanning WHDLoad-installers, so I donwload a couple and scanned them on Windows XP... it worked.

It could of course be a crash in the LHA library if the file cannot be opened or something like that, perhaps it's not readable by you user? I'll check in the code if that could be a problem.

(PS: Heard 'n' Heavy is added to the database now, Twinworld was already there )

[Dic_Ray]

Dear Frode,

after a very long time, I could find a lha file, which let fs-uae crash under Windows. This only happens under Windows, but not under Mac OS X.

Hope, this helps you to solve this little problem.

Best
Dic

[FrodeSolheim]

Hi Dic_Ray, and thanks for the file It actually does not cause a crash here (on Windows either), but with some types of bugs it can be a bit circumstantial whether it crashes or not.

I ran FS-UAE Launcher through valgrind (a great tool by the way), and it does report a couple of invalid memory reads in lzhlib while processing this file. I'll investigate more thoroughly (=debug lzhlib).

[FrodeSolheim]

@Dic_Ray, thanks, your test file helped nail the problem Also, your theory about what the problem was (by PM) was almost spot on. The crashes happen when FS-UAE Launcher tries to extract a directory entry (which is supposed to fail gracefully -- not crash), but a bug in lzhlib caused a crash instead (sometimes).

Can you try the replacement file attached? Find lzlib.pyd in your FS-UAE Launcher installation on Windows and replace with the one in the attached zip file. Hopefully the crashes should be history then

(For packagers, updated lhafile/lzhlib can be found here: https://github.com/FrodeSolheim/lhafile).

[Dic_Ray]

Yes, it's working now with all my files. Thank you soo much.

[FrodeSolheim]

Thanks for confirming I'll make sure the fix is included in the next build!