DataTypes - "remapping" - sometimes not working

[peceha]

Hi,
I've been playing with Blitz, and wanted to have a picture in the window on my own screen. So I used datatypes and all is fine as long as I keep PTDA_Remap=False.

I don't know if there is a bug in the system DataTypes or my way of doing this is wrong.

And here is my way:
- there is a WB screen (32 colors)
- there is my screen (workbench like)
- there is a backdrop|borderless window on my screen (covering whole)
- I load the picture (PDTA_Remap=True, PDTA_Screen points to WB screen)
- I use SetRGB24() to copy from PDTA_GRegs to my screen
- and finally BlitBitMapRastPort (from PTDA_DestBitMap to my window\RPort)
- the result is .. horrible
- to fix it I need to copy all the colors from WB screen to my screen - but as per manual PDTA_GRegs should already have correct palette..

I won't post anything in Blitz here but there is a link with short C listing.
https://github.com/asman2000/dtwb/blob/main/src/gfx.c.

What am I doing wrong (in my approach)?
Thanks.

[Samurai_Crow]

Try calling RethinkDisplay() to update the copper list to show the updated pallette? Just guessing.

[thomas]

Originally Posted by peceha

- I use SetRGB24() to copy from PDTA_GRegs to my screen

You should either remap the picture to your screen or change the colors of the screen to those of the picture, but not both.

PDTA_Screen has to point to the destination screen (your screen, not the Workbench screen).

And you have to call PDTA_PROCLAYOUT to do the actual remapping before you can get PTDA_DestBitMap and do BlitBitMapRastPort.

[peceha]

@Samurai_Crow
doesn't help...

@thomas

PDTA_Screen has to point to the destination screen (your screen, not the Workbench screen).
You should either remap the picture to your screen or change the colors of the screen to those of the picture, but not both.

So this is my mistake...
I was sure that putting WB screen into PDTA_Screen will remap as per WB colors and then I would take these colors onto my screen and have picture displayed correctly (because I copied the colors from the screen that was pointed in PDTA_Screen into my screen)

And you have to call PDTA_PROCLAYOUT to do the actual remapping before you can get PTDA_DestBitMap and do BlitBitMapRastPort.

I really do, the listing in the link was not written by me (no C here.. ) and I don't quite understand what I'm seeing there - actually I do but I need time to go through it.

[thomas]

Originally Posted by peceha

I really do

You didn't mention it. I was not looking at the code, only at your list.

Attached is an example in C written after your description.

[peceha]

Thanks.

So there are 2 solution to have a picture on my screen and with colors that fit WB:
- set PDTA_Screen to WB, remap, copy the wb colors over to my screen
- copy from WB to my screen following colors: 0,1,2,3,17,18,19, set PDTA_Screen to my screen and do remapping

[thomas]

You should not tie your program to the Workbench screen if you open your own screen. Datatypes.library allocates shared pens on the screen pointed to by PDTA_Screen. For this to work you at least have to assure that the screen does not go away while your DT object is connected to the screen, so you have to LockPubScreen(NULL).

If you open your own screen anyway, which covers the whole display and hides the Workbench screen, you should allow the WB screen to close and not stick it to your program.

And no, it's probably more complicated than to copy fixed pens. The user can select different pens for different purposes in the Palette prefs.

You should rather either copy all WB screen properties which can easily be done using SA_LikeWorkbench, or you should make your own properties for your screen independent from the WB screen.

[peceha]

I agree with all what you wrote here but anyway I need to think about it a little bit more