Anyone know what would cause a crash in AmigaOS 3.X (from Cloanto's Amiga Forever)

[meynaf]

Originally Posted by Nightfox

texteditor.gadget is a big one. It's not even fully implemented in its AmigaOS 3.2 form. Some features in the autodocs I dont think are even implemented yet like for example it says you can use escape sequences to change the pen but I can't get that to work at all

I dont think regular gadtools has anything super cool like layout.gadget either

Problematic indeed. This is still possible to do by hand and is much less work than doing whole own GUI library, but...

Do you know which gadget causes the issue ? You may want to remove them all, then put them back one by one to find out.

[Minuous]

As Nightfox surmised, that feature is currently unimplemented in texteditor.gadget.

[Don_Adan]

Originally Posted by Minuous

Alas not, see screenshot...

Exactly, I mean about kick 3.X (handmade, perhaps with Remus). Which was identical to kick 3.9 (again handmade kick) plus some fixes (?) from Aminet. Except some hand edited texts in exec.library. For system files You can have what You want, this is not important, You can copy files from OS 3.9 if You need. If any system files crashes then program can check for version of these files. Or patch loaded system file.

[Nightfox]

Originally Posted by Don_Adan

Then perhaps can be trashing memory problem. You can alloc more memory that is necessary for work.
f.e alloc 2MB fast, if You need only 100KB.
Fill this memory with ID, f.e "WTWT" And save to file when quit from program.
Later look at this memory.

I went to every call of AllocVec() and allocated 10x than what was needed. Still the same crash unfortunately.

Also sorry but can you clarify what you mean by "Fill this memory with ID, f.e "WTWT" And save to file when quit from program." If this is a tool then I'd like to learn about it.

[Nightfox]

Originally Posted by meynaf

Problematic indeed. This is still possible to do by hand and is much less work than doing whole own GUI library, but...

Do you know which gadget causes the issue ? You may want to remove them all, then put them back one by one to find out.

I think it's a problem with clicktab.gadget and how it handles pages. I created a test tab with just a single button on the page that it loads up.. and crash

[Nightfox]

You can see in the screenshot attached. This tab is supposed to open just a page with a single button but when I click it, the system freezes and no button is shown before the freeze

[Don_Adan]

Originally Posted by Nightfox

I think it's a problem with clicktab.gadget and how it handles pages. I created a test tab with just a single button on the page that it loads up.. and crash

OK, then this is not kick 3.X problem. But OS 3.X problem. This is different thing. Perhaps this is possible to overwrite clicktab.gadget with version from OS 3.9 and check effects.

[Nightfox]

Here are some relevant parts of the code if anyone sees an error:

modeSelectionTabList = AllocVec(sizeof(struct List), MEMF_CLEAR);
	NewList(modeSelectionTabList);
	chatTabNode = AllocClickTabNode(TAG_DONE);
	SetClickTabNodeAttrs(chatTabNode,
	 TNA_Number, MODE_SELECTION_TAB_CHAT_ID,
	 TNA_Text, "Chat",
	 TNA_TextPen, isPublicScreen ? ObtainBestPen(screen->ViewPort.ColorMap, 0x00000000, 0x00000000, 0x00000000, OBP_Precision, PRECISION_GUI, TAG_DONE) : 1,
	 #ifdef __AMIGAOS4__
	 TNA_HintInfo, "Have a text conversation with ChatGPT",
	 #endif
	  TAG_DONE);
	imageGenerationTabNode = AllocClickTabNode(TAG_DONE);
	SetClickTabNodeAttrs(imageGenerationTabNode,
	 TNA_Number, MODE_SELECTION_TAB_IMAGE_GENERATION_ID,
	 TNA_Text, "Image Generation",
	 TNA_TextPen, isPublicScreen ? ObtainBestPen(screen->ViewPort.ColorMap, 0x00000000, 0x00000000, 0x00000000, OBP_Precision, PRECISION_GUI, TAG_DONE) : 1,
	 #ifdef __AMIGAOS4__
	 TNA_HintInfo, "Generate an image from a text prompt",
	 #endif
	  TAG_DONE);
	AddTail(modeSelectionTabList, chatTabNode);	
	AddTail(modeSelectionTabList, imageGenerationTabNode);

if ((chatModeLayout = NewObject(LAYOUT_GetClass(), NULL,
		LAYOUT_Orientation, LAYOUT_ORIENT_HORIZ,
		LAYOUT_SpaceInner, TRUE,
		LAYOUT_SpaceOuter, TRUE,
		LAYOUT_AddChild, conversationsLayout,
		CHILD_WeightedWidth, 30,
		LAYOUT_AddChild, chatTextBoxesLayout,
		CHILD_WeightedWidth, 70,
		TAG_DONE)) == NULL) {
			printf("Could not create main layout\n");
			return RETURN_ERROR;
	}

	if ((imageGenerationInputLayout = NewObject(LAYOUT_GetClass(), NULL,
		LAYOUT_Orientation, LAYOUT_ORIENT_VERT,
		LAYOUT_SpaceInner, TRUE,
		LAYOUT_SpaceOuter, TRUE,
		LAYOUT_AddChild, openSmallImageButton,
		CHILD_WeightedHeight, 10,
		LAYOUT_AddChild, openMediumImageButton,
		CHILD_WeightedHeight, 10,
		LAYOUT_AddChild, openLargeImageButton,
		CHILD_WeightedHeight, 10,
		LAYOUT_AddChild, openOriginalImageButton,
		CHILD_WeightedHeight, 10,
		LAYOUT_AddChild, saveCopyButton,
		CHILD_WeightedHeight, 10,
		LAYOUT_AddChild, textInputTextEditor,
		CHILD_WeightedHeight, 40,
		CHILD_NoDispose, TRUE,
		LAYOUT_AddChild, createImageButton,
		CHILD_WeightedHeight, 10,
		TAG_DONE)) == NULL) {
			printf("Could not create image generation input layout\n");
			return RETURN_ERROR;
	}

	if ((imageGenerationTextBoxesLayout = NewObject(LAYOUT_GetClass(), NULL,
		LAYOUT_Orientation, LAYOUT_ORIENT_VERT,
		LAYOUT_SpaceInner, TRUE,
		LAYOUT_SpaceOuter, TRUE,
		LAYOUT_AddChild, imageGenerationInputLayout,
		CHILD_WeightedHeight, 90,
		LAYOUT_AddChild, statusBar,
		CHILD_WeightedHeight, 10,
		CHILD_NoDispose, TRUE,
		TAG_DONE)) == NULL) {
			printf("Could not create chat layout\n");
			return RETURN_ERROR;
	}

	if ((imageGenerationModeLayout = NewObject(LAYOUT_GetClass(), NULL,
		LAYOUT_Orientation, LAYOUT_ORIENT_HORIZ,
		LAYOUT_SpaceInner, TRUE,
		LAYOUT_SpaceOuter, TRUE,
		LAYOUT_AddChild, imageHistoryButtonsLayout,
		CHILD_WeightedWidth, 30,
		LAYOUT_AddChild, imageGenerationTextBoxesLayout,
		CHILD_WeightedWidth, 70,
		TAG_DONE)) == NULL) {
			printf("Could not create image generation layout\n");
			return RETURN_ERROR;
	}

	if ((modeClickTab = NewObject(CLICKTAB_GetClass(), NULL,
		GA_ID, CLICKTAB_MODE_SELECTION_ID,
		GA_RelVerify, TRUE,
		CLICKTAB_Labels, modeSelectionTabList,
		CLICKTAB_AutoFit, TRUE,
		CLICKTAB_PageGroup, NewObject(PAGE_GetClass(), NULL,
            PAGE_Add,       chatModeLayout,
            PAGE_Add,       imageGenerationModeLayout,
        TAG_DONE),
		TAG_DONE)) == NULL) {
			printf("Could not create mode click tab\n");
			return RETURN_ERROR;
	}

	if ((mainLayout = NewObject(LAYOUT_GetClass(), NULL,
		LAYOUT_Orientation, LAYOUT_ORIENT_VERT,
		LAYOUT_DeferLayout, TRUE,
		LAYOUT_SpaceInner, TRUE,
		LAYOUT_SpaceOuter, TRUE,
		LAYOUT_AddChild, modeClickTab,
		TAG_DONE)) == NULL) {
			printf("Could not create main layout\n");
			return RETURN_ERROR;
	}

	idcmpHookMainWindow.h_Entry = (HOOKFUNC)processIDCMPMainWindow;
	idcmpHookMainWindow.h_Data = NULL;
	idcmpHookMainWindow.h_SubEntry = NULL;

	idcmpHookCreateImageWindow.h_Entry = (HOOKFUNC)processIDCMPCreateImageWindow;
	idcmpHookCreateImageWindow.h_Data = NULL;
	idcmpHookCreateImageWindow.h_SubEntry = NULL;

	appPort = CreateMsgPort();

	#ifdef __AMIGAOS4__
	refreshOpenAIMenuItems();
	#endif

	if ((mainWindowObject = NewObject(WINDOW_GetClass(), NULL,
		WINDOW_Position, WPOS_CENTERSCREEN,
		WA_Activate, TRUE,
		WA_Title, "AmigaGPT",
		WA_Width, (WORD)(screen->Width * 0.8),
		WA_Height, (WORD)(screen->Height * 0.8),
		WA_CloseGadget, TRUE,
		WA_DragBar, isPublicScreen,
		WA_SizeGadget, isPublicScreen,
		WA_DepthGadget, isPublicScreen,
		WA_NewLookMenus, TRUE,
		WINDOW_AppPort, appPort,
		WINDOW_IconifyGadget, isPublicScreen,
		WINDOW_Layout, mainLayout,
		WINDOW_SharedPort, NULL,
		WINDOW_Position, isPublicScreen ? WPOS_CENTERSCREEN : WPOS_FULLSCREEN,
		WINDOW_NewMenu, amigaGPTMenu,
		WINDOW_IDCMPHook, &idcmpHookMainWindow,
		WINDOW_InterpretIDCMPHook, TRUE,
		WINDOW_IDCMPHookBits, IDCMP_IDCMPUPDATE,
		WA_IDCMP, IDCMP_CLOSEWINDOW | IDCMP_GADGETUP | IDCMP_GADGETDOWN | IDCMP_MENUPICK | IDCMP_RAWKEY,
		WA_CustomScreen, screen,
		TAG_DONE)) == NULL) {
			printf("Could not create mainWindow object\n");
			return RETURN_ERROR;
	}

	if ((mainWindow = (struct Window *)DoMethod(mainWindowObject, WM_OPEN, NULL)) == NULL) {
		printf("Could not open mainWindow\n");
		return RETURN_ERROR;
	}

[Olaf Barthel]

Originally Posted by Nightfox

Here are some relevant parts of the code if anyone sees an error:

The error, or rather the combined collection of errors, is likely found in the ClassAct and ReAction classes which you intend to make good use of.

We spent years (wish I was kidding, wish I hadn't been knuckle-deep in code that nobody seemed to have had enough love for) fixing bugs in the ReAction classes which shipped with AmigaOS 3.2, etc. just so that the handful of programs which made use of them did not crash or stumble into a cascade of undefined behaviour for no apparent reason.

You may get lucky with AmigaOS 3.2, etc. but you may need more than luck, perhaps providence, to run the same code on AmigaOS 68k and AmigaOS 4 and not have it let you down because the ReAction class foundations are not as robust as they may appear to be. The further back you go from ReAction in the direction of ClassAct, the less robust these foundations will become.

Please take the advice given by Minuous, who is one of the AmigaOS 3.2 developers and whose work on the ReAction classes was essential in getting them into a sufficiently stable state. Your code might work with AmigaOS 3.2 and AmigaOS 4: check the class library version numbers and reject those versions which are older than what shipped with AmigaOS 3.2 and AmigaOS 4. If you want your program to be stable, you will likely have to pick and choose which class libraries you can safely use. It is that bad

[Minuous]

Olaf is right; I would just add that the OS3.9+BB2 version of ReAction is mostly OK too (though inferior to 3.2 of course), H&P fixed a lot of bugs. It's just the earlier ones than that (eg. the ones in "AmigaOS 3.X") that are really problematic.

[Nightfox]

I tried adding the 3.2 clicktab.gadget to the 3.X environment as an experiment and it crashes immediately. I'm guessing it needs a newer ROM to work.

I've given up on this. I'm going to instead detect if the user is on 3.X and display a popup letting the user choose which mode to run in. If they want to switch modes they won't have a clicktab for it so they will just have to quit and select the other mode

[Don_Adan]

You tried wrong attempt. OS 3.X is OS3.9 clone/copy, not OS 3.2. Then You can try using clicktab.gadget from OS 3.9, not from OS 3.2. But if this is real bug in old ReAction code and simple copy file(s) from OS 3.9 to OS 3.X does not help/work.
Then You can use:
1. different method for handling OS 3.X buggy gadgets.
2. Search net (Aminet mostly) if fixed version of ReAction buggy gadget(s) are already available
3. Ask Cloanto to fix buggy gadgets in OS 3.X
4. Ask good coder from EAB to find and fix buggy gadget(s) and realease this later as Spatch version for Aminet.

[Nightfox]

Just released a new version of AmigaGPT which removes the clicktab if it's 3.X and will instead just let the user select a mode at startup.

Moral of the story: Dont spend too much time getting things to work for 3.X. Instead just give those users a dirty workaround.

[Don_Adan]

Originally Posted by Nightfox

Just released a new version of AmigaGPT which removes the clicktab if it's 3.X and will instead just let the user select a mode at startup.

Moral of the story: Dont spend too much time getting things to work for 3.X. Instead just give those users a dirty workaround.

Yes, but check library version is better/cleaner solution for me. OS 3.X user can have installed newest version of necessary files from OS 3.9.

[Nightfox]

Originally Posted by Don_Adan

Yes, but check library version is better/cleaner solution for me. OS 3.X user can have installed newest version of necessary files from OS 3.9.

That’s what I did do actually. It checks if the version of clicktab.gadget > 44

[Don_Adan]

Very good. I understood wrong, sorry.

[Nonefornow]

This means that a "Libs/workbench.library" file must be present on the boot disk, as detailed below."
https://www.amigaforever.com/kb/16-125

I wanted to follow up on this. I read that page and saw that the referred library can then be downloaded from here https://www.amigaforever.com/classic/download/

Now checking into the Install 3.1 diskette I can see that library is not there, but there is no space in the diskette to save a copy of it.

Does anyone have any suggestion on how to resolve this? Or what files can then be removed from the install diskette? Because are included in the 3.X ROM?

[Snoopy1234]

Originally Posted by Nonefornow

I wanted to follow up on this. I read that page and saw that the referred library can then be downloaded from here https://www.amigaforever.com/classic/download/

Now checking into the Install 3.1 diskette I can see that library is not there, but there is no space in the diskette to save a copy of it.

Does anyone have any suggestion on how to resolve this? Or what files can then be removed from the install diskette? Because are included in the 3.X ROM?

The 3.X workbench.library could be added to any disk in the WB set that has space, eg storage. The Install disk Install script would need to be edited to include the file/location. The Install disk itself doesn't have Workbench files on it iirc.

[Nonefornow]

Originally Posted by Snoopy1234

The 3.X workbench.library could be added to any disk in the WB set that has space, eg storage.

Indeed. However in the OS 3.1 set of disks, both the Install and Workbench disks are supposed to be bootable. If the workbench.library file is not in there, and you have kickstart 3.x, the disk will boot with no icons on the workbench.

[No.3]

Originally Posted by Nightfox

You can see in the screenshot attached. This tab is supposed to open just a page with a single button but when I click it, the system freezes and no button is shown before the freeze

What does Enforcer say?