30 July 2022, 00:25 | #1 |
Registered User
Join Date: Mar 2013
Location: Leipzig/Germany
Posts: 466
|
statefile format
The chunks in the statefile are aligned to 4 Byte boundary. So far - so good. But if a chunk is at this boundary already, 4 extra unnecessary bytes are added.
From statefile.cpp: len2 = 4 - (len & 3). Basically 4 minus 0 then... Next line if (len2)is totally useless as far as my non existing C coder skills teach me. Because len2 is always in the range of 1 to 4 but never zero, so the padding function is always triggered. Should be more like if len2 != 4I guess... |
30 July 2022, 14:26 | #2 |
WinUAE developer
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 49
Posts: 26,505
|
Yeah, I know that, years and years ago.. There is not much to do than leave it that way because it would break compatibility. (Perhaps some comment might be good idea..)
|
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | |
Thread Tools | |
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
68K PLCC format to DIP format | Sim085 | Hardware mods | 4 | 08 March 2020 21:06 |
load statefile in a command line is it possible ? | turrican3 | support.WinUAE | 1 | 21 February 2010 11:02 |
Statefile support improvements | Toni Wilen | request.UAE Wishlist | 3 | 02 April 2007 18:32 |
I can´t format my new HD | Firstbase | support.Hardware | 7 | 22 August 2006 11:59 |
Format cylinder 0 | stainy | support.WinUAE | 2 | 16 December 2005 00:25 |
|
|