Can't install Eagleplayer 2.03 - Script fault!

[andreas]

[mod: this belongs to *PROBLEMS - apps - sorry! TIA for moving]

When trying to install Eagleplayer 2.03 (beta) from Aminet, I get this:

"DEST: String argument expected in line 370"

This is the section in question:

(user 2)

    (set target (askdir (prompt #which-disk)
			        (help @askdir-help)
			        (default "Work:")
			        (disk)
    )
 )
(
	(makedir (tackon target "Eagleplayer")) 
	(copyfiles
		(source ("EagleplayerDir.info"))
[370]		(dest target/Eagleplayer.info)

	(set @default-dest target)
	)
)

Unfortunately, I'm not too familiar with install script syntax

I have Installer 43.3, which should be enough by far!
Have I really found a script bug which has been lurking in the package for years?

[TikTok]

At a guess I would say the target/Eagleplayer.info part should be in quotes (and possible brackets too?), just like the previous line.

[andreas]

Thanks, but I think this is not a good guess. I was assuming the same thing at first but: target is an environment variable, while "Eagleplayer.info" is a value!

[TikTok]

Ah yes, should have spotted that, sorry.

Having said that, isn't Eagleplayer.info also acting as a variable unless it is enclosed in quotes?

[DamienD]

Originally Posted by andreas

[mod: this belongs to *PROBLEMS - apps - sorry! TIA for moving]

Done

[andreas]

@Tik Tok
Yes I think so
But that's exactly my problem: I need a mix of a variable and a "hard-coded" value, and I do not know how!

[alexh]

I would suggest trying this change:

[370]		(dest (tackon target "Eagleplayer.info"))

I read a bit in this guide about copyfiles and tackon

(tackon <path> <file>)
Concatenates the filename to the pathname and returns resulting string.

That installer syntax guide is ok, but not written in very good english

If that doesnt work, try this:

[370]		(dest ("Eagleplayer.info"))

[AmigaBoy]

I know nothing about writing or debugging installer scripts so excuse me if I'm wrong with my analysis...

Try changing the line to:

(dest (tackon target "Eagleplayer.info"))

From what I can see, tackon seems like an append function which returns a string of the 2 values joined together.

Of course, even with that done, you've got 2 other problems to worry about...

"EagleplayerDir.info" doesn't exist in the archive. So the install will fail there. Assuming you did what I did and decide you'll get any .info file for a directory and call it EagleplayerDir.info. Good thinking, except it does little good because right after the copy, we have a:

(exit)

Now, like I said, I don't know much about Installer scripts but I believe this exits, and sure enough, it did when I tried my "fixes".

I then tried removing the exit and reran. Another bug pops up. Somewhere else in the script it complains about tackon. I don't know where as my installer didn't give me a line number (I guess I should update my installer, eh?).

That's where I've stopped.
It may be a simple fix, or the script may be riddled with bugs. Any install script experts around?

[AmigaBoy]

Simultaneous posting by alexh. Mine's more right though, cause mine contains the word assuming.

[amiga]

There's no need to install it. Just copy it into a directory.