icon.library 46.4 test versions

[Retrofan]

Thanks a lot.

BTW what takes care of the use of the icons in DOpus? Is somebody working on that?

[PeterK]

This is the wrong place for feature requests or bug reports concerning DOpus5.

Try this webpage, please:

http://sourceforge.net/p/dopus5allamigas/discussion/

[Ian]

I am a total newb at startup-sequences. I have copied loadresident into my c directory. (And the libs course) and then copied the loadresident section of the startup-sequence of the icondemo.adf is that all I need to do? Or do I need all that fblit stuff too?

I am doing this on a 3.1 clean install

[PeterK]

That's only the minmum and it may work already, but you won't have much fun without installing FBlit (it needs a 68020) and some of the other programs, which I have installed on IconDemoADF. If you don't have a 68020 CPU then it's the easiest to install the complete BetterWB package. http://lilliput.amiga-projects.net/BetterWB.htm

Concerning the IconDemoADF you should make a backup of your WB 3.1 S:startup-sequence and then add all the lines from the ADF that are missing into your startup-sequence. Of course, you also should "walk" through the ADF directory tree and compare it with your WB 3.1 directories and copy all missing files to your system. That's all.

You don't need to copy the drawers with the demo icons !

Download the latest icon.library from Aminet. The one on IconDemoADF is pretty old.

[Ian]

Ok will do that later. I am only using winuae. Trying to do everything myself at the moment without using packs. It's a learning process lol

[Michael]

Some updated results of my 16bit CGX/060

Ken's Icons v4 PNG icon collection
icon.library 46.4.378
Average: 10.94
----------------------------
icon.library 46.4.384
Average: 10.90
----------------------------
icon.library 46.4.385
Average: 10.84

CrystalIcons icon collection:
icon.library 46.4.378
Average: 1.52
----------------------------
icon.library 46.4.384
Average: 1.48
----------------------------
icon.library 46.4.385
Average: 1.48


Now a real life compare WB 45 v DOPUS 5.82 (icon.library 46.4.385)
from HDD = SYS:Prefs/ (~100 icons)

WB: 1.68 s
DO: 3.26 s

Interestingly enough DOPUS takes some time to draw the few drawer icons I have there (takes most of the time and you can see each drawer icon drawn) and then almost instantly draws all the prefs icons.

[Michael]

Originally Posted by daxb

1: I saw this error here one time but couldn`t reproduce it. However, I`ve changed some things already what should fix this.

3: Only the very first open/close, during all passes or the whole test?

At the moment "screen to front" works but OpenWin window is on the screen where it is lauched from.

Script from 385 release...

1. Works better, with copy to ram disabled works perfectly with WB & DO.
With the copy mode, WB test fails, and DO test kind of fails too (opens lister in text mode) But at least everything is copied correctly and an icon is added to KENS pack.

3. DO - The previous open test lister closes about second later after a new one has opened and some new icons have been displayed already! Also interesting the results for each pass are better and better for every pass. eg. 7.32, 7.24, 7.16, 7.12, 7.10, 7.08, 7.06.

4. Screen to front did not work, if it was implemented there?

[PeterK]

@Michael
Strange ??
The speed gain on your system is less than 1 %, and on my WinUAE it was nearly 20 % and compared to the previous Aminet release 374 more than 25 %. I really didn't expect such a big difference between WinUAE and a real Amiga system.

[daxb]

@Michael:
Please test all the problems you had. Should work now as expected. I don`t know what version in 385 release is. Maybe PeterK or someone else has changed it or it is just an old test version. I haven`t add automatical add icon feature, only check if exists. If DOpus opens Window/Lister in text mode then the testDir hasn`t an icon or the path is parsed wrong.

[Michael]

@daxb:
385 has version dated 12.09.2014 and it does 10 tests in a loop, also it should have had the flag for no copy to mem set as default, as it works, and copy to mem mode failed in many cases and would be a disappointment for a new user.

First start, and we fail under DO!
No (env_cached_dir_path) available -> quit

Enabled copy to ram:
And it works now, as long as an icon is present (or fails with add icon please)
So we can happily use addicon there and no need for a warning.

Also it might be good to check if we are already on the RAM: disk, and we should not copy icons to a temp dir in ram: (just checking the path for first 3 letters RAM should be ok in most cases unless you can figure a way to check for device RAM: then it will be almost fail safe)

And a big surprise...
Tried to abort the script by closing the window before the loops finish,
and something gone wrong, since the icon window closed but the script is looped busy,
can't even ctrl+c it. But the system seems to be ok and cpu is 50% busy.
I guess something got interrupted and stuck somewhere (hopefully not the icon.lib).

[PeterK]

Update to icon.library 46.4.386:

Removed the multiplication from the direct drawing again, but this time without inserting a subraction in one of the loops instead.

[Michael]

Snapshoting a window in WB snapshots the disk icon position too.
IMHO it should not do that. Should save only the window settings unless snapshot all is used.
icon.lib bug or wb ?

[PeterK]

The behaviour of the icon.library v45.1 is the same. I don't know if I should change that. But I guess, you are right, it would be more logical to snapshot the window frame position and size only and not its icon, too.

It's probably done both together, because the whole DiskObject-structure is simply written back from memory onto the disk, and not just the particular data.

[daxb]

Michael, it seems you refer to the old verion (12.09). Please use the latest version from post #1090.

Originally Posted by Michael

Also it might be good to check if we are already on the RAM: disk, and we should not copy icons to a temp dir in ram: (just checking the path for first 3 letters RAM should be ok in most cases unless you can figure a way to check for device RAM: then it will be almost fail safe)

Therefore we have the switch var "dest = 0" in the script: Set to "0" if you want to test from Ram: (icons will be copied to it) If set to "1" test runs from the place you chose via requester. So if you copy icons manually to Ram: then use "dest = 1".

"closing the window":
You can close the OpenWin window while test is running? Here (DOpus5) I can only close the window when test is finished. CTRL+C cancel OpwnWin.rexx if you want to break it. On the other hand, after test started you should "freeze" (don`t touch keyboard, mouse, computer), else you manipulate the test results what is not the goal. Closing the test window while test is running isn` a good idea.

[Michael]

Originally Posted by daxb

Michael, it seems you refer to the old verion (12.09). Please use the latest version from post #1090.

No, the one in v385 pack works only with dest=1
And the newer one in #1090 works only with dest=0
and as reported fails on a cold stated system when nothing was copied to ram yet, by the script or manually.
Also funny, the WB test icon window gets resized to the smallest size.
This did not happen before.

Originally Posted by daxb

"closing the window":
You can close the OpenWin window while test is running? Here (DOpus5) I can only close the window when test is finished. CTRL+C cancel OpwnWin.rexx if you want to break it. On the other hand, after test started you should "freeze" (don`t touch keyboard, mouse, computer), else you manipulate the test results what is not the goal. Closing the test window while test is running isn` a good idea.

Not exactly, can close the lister to abort the test.
Moving the mouse obviously effects the performance.
It was required to see that the previous window is closed after the new one has opened, otherwise they overlap.

[PeterK]

Added a special version for Amithlon systems:

This version is still using the image line based direct drawing of 376, but combines it with the new color reduction code and the zlib changes of 385.

Unfortunately, the improvements in the 46.4.385 color reduction don't have the same big impact on speed for real Amiga systems as they do on emulators like WinUAE.

[daxb]

Originally Posted by Michael

And the newer one in #1090 works only with dest=0
and as reported fails on a cold stated system when nothing was copied to ram yet, by the script or manually.

Do you get an error message? If not you can open a shell and type "tco" and "ts" or just "ts" what starts trace. With return key you can go through the script step by step until the error happens. If I see the trace output I can tell you more about what happens.

Also funny, the WB test icon window gets resized to the smallest size.
This did not happen before.

For WB the open/close of the parent drawer of testdir is a workaround. It was reported that testdir was locked.

[daxb]

I`ve add some debug stuff. Michael, you can now set "MyDebug" in the script to enable debug output. 1 for errorhandling and 2 for errorhandling + trace. Hopefully, we can fix all your issues with it.

[Michael]

Originally Posted by daxb

I`ve add some debug stuff. Michael, you can now set "MyDebug" in the script to enable debug output. 1 for errorhandling and 2 for errorhandling + trace. Hopefully, we can fix all your issues with it.

Nothing in RAM:, just booted and ran the script

        >F> "N"
 20 *-* IF MyDebug > 0 THEN
      >V> "2"
      >L> "0"
      >O> "1"
      >>> "1"
   20 *-*  DO;
     21 *-* SIGNAL ON ERROR;
     22 *-* SIGNAL ON SYNTAX;
     23 *-* SIGNAL ON NOVALUE;
     24 *-* END;
 25 *-* SIGNAL ON BREAK_C;
 27 *-* envvar = 'ENVARC:OpenWin_dir';
      >L> "ENVARC:OpenWin_dir"
      >>> "ENVARC:OpenWin_dir"
 28 *-* tempvar = 'T:OpenWin_dir';
      >L> "T:OpenWin_dir"
      >>> "T:OpenWin_dir"
 30 *-* OPTIONS RESULTS;
 30 *-* ADDRESS COMMAND;
 31 *-* CALL AddLibs();
  194 *-* AddLibs:
  194 *-* PROCEDURE;
  195 *-* libs = 'rexxsupport.library';
        >L> "rexxsupport.library"
        >>> "rexxsupport.library"
  196 *-* DO i = 1 TO WORDS(libs);
        >L> "1"
        >>> "1"
        >V> "rexxsupport.library"
        >F> "1"
          >V> "1"
    197 *-* IF ~SHOW('L',WORD(libs,i)) THEN
          >L> "L"
          >V> "rexxsupport.library"
          >V> "1"
          >F> "rexxsupport.library"
          >F> "1"
          >P> "0"
          >>> "0"
    203 *-* END;
    196 *-* DO i = 1 TO WORDS(libs);
          >V> "1"
          >O> "2"
          >>> "2"
  204 *-* RETURN;
 32 *-* myPort = GetPort();
  171 *-* GetPort:
  171 *-* PROCEDURE;
  172 *-* myPort = '';
        >L> ""
        >>> ""
  173 *-* IF SHOW('P','WORKBENCH') & SHOW('P','DOPUS.1') THEN
        >L> "P"
        >L> "WORKBENCH"
        >F> "0"
        >L> "P"
        >L> "DOPUS.1"
        >F> "1"
        >O> "0"
        >>> "0"
    182 *-* ELSE 
    182 *-* DO;
      183 *-* IF SHOW('P','WORKBENCH') THEN
            >L> "P"
            >L> "WORKBENCH"
            >F> "0"
      184 *-* IF SHOW('P','DOPUS.1') THEN
            >L> "P"
            >L> "DOPUS.1"
            >F> "1"
        184 *-*  myPort = 'DOPUS.1';
              >L> "DOPUS.1"
              >>> "DOPUS.1"
      185 *-* END;
  186 *-* IF myPort = '' THEN
        >V> "DOPUS.1"
        >L> ""
        >O> "0"
        >>> "0"
  191 *-* RETURN myPort;
        >V> "DOPUS.1"
      >F> "DOPUS.1"
      >>> "DOPUS.1"
 34 *-* ;
 35 *-* IF EXISTS(envvar) THEN
      >V> "ENVARC:OpenWin_dir"
      >F> "1"
   35 *-*  DO;
     36 *-* oldDir = GetDir(envvar);
          >V> "ENVARC:OpenWin_dir"
  119 *-* GetDir:
  119 *-* PROCEDURE;
  120 *-* file = ARG(1);
        >L> "1"
        >F> "ENVARC:OpenWin_dir"
        >>> "ENVARC:OpenWin_dir"
  121 *-* CALL OpenFile(file);
        >V> "ENVARC:OpenWin_dir"
    141 *-* OpenFile:
    141 *-* PROCEDURE;
    142 *-* file = ARG(1);
          >L> "1"
          >F> "ENVARC:OpenWin_dir"
          >>> "ENVARC:OpenWin_dir"
    143 *-* IF ~OPEN('in',file,'READ') THEN
          >L> "in"
          >V> "ENVARC:OpenWin_dir"
          >L> "READ"
          >F> "1"
          >P> "0"
          >>> "0"
    148 *-* RETURN;
  122 *-* directory = READLN('in');
        >L> "in"
        >F> ""RamDisk:kens_icons_v4/""
        >>> ""RamDisk:kens_icons_v4/""
  123 *-* CALL CLOSE('in');
        >L> "in"
        >F> "1"
  124 *-* IF WORDS(directory) >1 THEN
        >V> ""RamDisk:kens_icons_v4/""
        >F> "1"
        >L> "1"
        >O> "0"
        >>> "0"
  128 *-* directory = COMPRESS(directory,'"');
        >V> ""RamDisk:kens_icons_v4/""
        >L> """
        >F> "RamDisk:kens_icons_v4/"
        >>> "RamDisk:kens_icons_v4/"
  129 *-* IF LASTPOS(':',directory) = LENGTH(directory) THEN
        >L> ":"
        >V> "RamDisk:kens_icons_v4/"
        >F> "8"
        >V> "RamDisk:kens_icons_v4/"
        >F> "22"
        >O> "0"
        >>> "0"
  134 *-* IF ~EXISTS(STRIP(directory,'T','/') || '.info') THEN
        >V> "RamDisk:kens_icons_v4/"
        >L> "T"
        >L> "/"
        >F> "RamDisk:kens_icons_v4"
        >L> ".info"
        >O> "RamDisk:kens_icons_v4.info"
        >>> "RamDisk:kens_icons_v4.info"
        >F> "0"
        >P> "1"
        >>> "1"
    134 *-*  DO;
      135 *-* SAY 'The drawer has no icon! Please add an icon for:';
            >L> "The drawer has no icon! Please add an icon for:"
The drawer has no icon! Please add an icon for:
      136 *-* SAY STRIP(directory,'T','/');
            >V> "RamDisk:kens_icons_v4/"
            >L> "T"
            >L> "/"
            >F> "RamDisk:kens_icons_v4"
RamDisk:kens_icons_v4
      137 *-* EXIT;

[Michael]

Some updated results of my 16bit CGX/060

Ken's Icons v4 PNG icon collection
----------------------------
icon.library 46.4.385
Average: 10.84
----------------------------
icon.library 46.4.386
Average: 10.76

CrystalIcons icon collection:
----------------------------
icon.library 46.4.385
Average: 1.48
----------------------------
icon.library 46.4.386
Average: 1.40

We see more speed!