Amiga File Server

[modrobert]

Turran,

I threw together a Python script 'eab_post_count.py' to get post count of a given EAB forum user.

This is kind of hairy in the sense that it depends on counting html tags and such on a dynamic webpage, pretty far from ideal, but it works (at the moment).

#!/usr/bin/env python 

import sys, re, urllib2

version="1.0"

if len(sys.argv) < 2:
    print(sys.argv[0] + ' v' + version +' by modrobert in 2017')
    print('Function: Returns the number of posts for a given EAB forum user.')
    print('Syntax: eab_user_count.py <username> [-i]')
    print('Options: -i ignore case sensivity in user name')
    print('Result: 0 = user found, 1 = user not found, 2 = invalid option.')
    sys.exit(1)
else:
    username = sys.argv[1]
    usernameurl = re.sub('[ ]', '%20', username)

eaburl = "http://eab.abime.net/memberlist.php?do=getall&pp=1&ausername=" + usernameurl

def parseurl(url):
    if not url:
        print("Empty URL!")
        return
    headers = { 'User-Agent' : 'Mozilla/5.0' }
    request = urllib2.Request(url, None, headers)
    response = urllib2.urlopen(request)
    content = response.read()
    return content

def pagesearch(content, trigger, start, end):
    sane = 0
    needlestack = []
    while sane == 0:
        curpos = content.find(trigger)
        if curpos >= 0:
            testlen = len(content)
            content = content[curpos:testlen]
            curpos = content.find('"')
            testlen = len(content)
            content = content[curpos+1:testlen]
            curpos = content.find(end)
            needle = content[0:curpos]
            result = content[len(start):curpos]
            if needle.startswith(start):
                needlestack.append(result)
        else:
            sane = 1
    return needlestack

def unescape(s):
    s = s.replace("&lt;", "<")
    s = s.replace("&gt;", ">")
    # this has to be last:
    s = s.replace("&amp;", "&")
    return s

eabcontent = parseurl(eaburl)

countlist = pagesearch(eabcontent, 'td class', 'alt2">', '</td>')
userlist = pagesearch(eabcontent, 'member.php?', '>', '</a>')

try:
    if sys.argv[2] == '-i':
        if unescape(str.lower(''.join(userlist))) != str.lower(username):
            print("User not found: " + username)
            sys.exit(1)
    else:
        print("Invalid option. ")
        sys.exit(2)
except Exception:
    if unescape(str(''.join(userlist))) != username:
        print("User not found: " + username)
        sys.exit(1)

for item in countlist:
    stripitem = re.sub('[,]', '', item)
    try:
        print(int(stripitem))
        sys.exit(0)
    except Exception:
        continue

[Turran]

Originally Posted by modrobert

Turran,

I threw together a Python script 'eab_post_count.py' to get post count of a given EAB forum user.

This is kind of hairy in the sense that it depends on counting html tags and such on a dynamic webpage, pretty far from ideal, but it works (at the moment).

Neat, thanks I did something similar in bash but decided against it. Its far too easy to just take one of the 5000 registered member names, see who has more then <number> of posts and register an FTP account with that name, if all you want to do is download.

Thats why I wanted to move the register account page here, behind a "member only" page. Kinda like The Zone in a way. Then we ensure that the username registered on the FTP is the same as the forum username.

[modrobert]

Originally Posted by Turran

Neat, thanks I did something similar in bash but decided against it. Its far too easy to just take one of the 5000 registered member names, see who has more then <number> of posts and register an FTP account with that name, if all you want to do is download.

Thats why I wanted to move the register account page here, behind a "member only" page. Kinda like The Zone in a way. Then we ensure that the username registered on the FTP is the same as the forum username.

Yes, that makes sense.

PS: Found a bug in the script, edited previous post. Apparently a user with > 1000 posts get a ',' in their counter.

[Turran]

Originally Posted by modrobert

Yes, that makes sense.

PS: Found a bug in the script, edited previous post. Apparently a user with > 1000 posts get a ',' in their counter.

Thanks. I tried implementing it for fun but the "more then one user found" page messes it up. Not your fault but we need a function to get the exact username from the forums, not just "containing" like it is today.

For example, if I registered an EAB user called "Turbo", I can not check its post count or even existence from your script since we get a lot of users with "Turbo" in their name..

This can of course be extended in the script to check all hits found, if one is an exact match, but perhaps more work than its worth right now.

[modrobert]

Originally Posted by Turran

Thanks. I tried implementing it for fun but the "more then one user found" page messes it up. Not your fault but we need a function to get the exact username from the forums, not just "containing" like it is today.

For example, if I registered a EAB user called "Turbo", I can not check its post count or even existence from your script since we get a lot of users with "Turbo" in their name..

If there is more than one user name in the result (from the actual search at EAB), then the user name given is incomplete/invalid.

The exit codes of my Python script are:

0 = user found, 1 = user not found, 2 = more than one user found.

So, for example, if you want to use this from a Bourne shell script.

#!/bin/sh
USER="Turran"
OUTPUT=`eab_post_count.py "$USER"`
RTN=$?
if test $RTN -eq 0 ; then
    # user found, do your stuff here
    echo "Post count: $OUTPUT"
fi

Note that the user name match is case-insensitive due to the forum search function.

PS: Updated the Python script post with another bug fix, the forum allows spaces in user names, handling that now.

[Turran]

So try getting the postcount for "Turbo". You cant since the result is only "More then one user found".

We need to go through the results if its more then one, and only when it finds an exact match, report the postcount. If no exact match is found then return "user not found".

Otherwise, the user "Turbo" can never register an EAB FTP account since we can not check the postcount =)

[modrobert]

Originally Posted by Turran

So try getting the postcount for "Turbo". You cant since the result is only "More then one user found".

We need to go through the results if its more then one, and only when it finds an exact match, report the postcount. If no exact match is found then return "user not found".

Otherwise, the user "Turbo" can never register an EAB FTP account since we can not check the postcount =)

Look at my shell script example again.

EDIT:

OK, here's another example, checking of exit code is "not equal" to zero.

#!/bin/sh
USER="Turran"
OUTPUT=`eab_post_count.py "$USER"`
RTN=$?
if test $RTN -ne 0 ; then
    # user name not found or incomplete (more than one)
    echo "User not found"
    exit 1
fi
# we have a valid user name
# do your stuff here
echo "Post count: $OUTPUT"

[Turran]

I dont think we understand each other. If the user "Turbo" tries to add an EAB FTP account, he is going to be denied because eab_post_count.py is going to report
print("* Found more than one user: " + username), when he indeed has a valid EAB Forums account.
This is because there are three other usernames also containing "Turbo" (RobTurbo, Turbo2Xs & TurboCrash).


We have no way to get the postcount from the user "Turbo" using the existing script, therefor he can not create an FTP account, even though he is a valid user (Well, he does not exist right now. Its just an example).

So my suggestion would here, here. Instead of the sys.exit(2):
print("* Found more than one user: " + username)
sys.exit(2)

go through all the results we got back, check if the username is an exact match to any of the result. If it is, grab the post count and return that.
If no user in all the results are a match, return
print("* User not found: " + username)
sys.exit(1)

But then again, do not spend time on this because its easy to exploit anyway by just browsing the eab member list and creating an FTP user with the same name as an existing member.

[modrobert]

Originally Posted by Turran

I dont think we understand each other. If the user "Turbo" tries to add an EAB FTP account, he is going to be denied because eab_post_count.py is going to report
print("* Found more than one user: " + username), when he indeed has a valid EAB Forums account.
This is because there are three other usernames also containing "Turbo" (RobTurbo, Turbo2Xs & TurboCrash).

No, it will report "User not found" and "exit 1", same as if the name was incorrect, in my previous edited post.

We have no way to get the postcount from the user "Turbo" using the existing script, therefor he can not create an FTP account, even though he is a valid user (Well, he does not exist right now. Its just an example).

If user "Turbo" gives more than one hit he is not a valid EAB forum user, or he entered the user name incomplete, my previous Bourne shell example handles this correctly using the exit/result code (-ne 0 / != 0).


Perhaps you posted your reply while I was editing my previous post to add another example?

[Turran]

Originally Posted by modrobert

No, it will report "User not found" and "exit 1", same as if the name was incorrect, in my previous edited post.

Wrong.
python eabpostcount.py Turbo
* Found more than one user: Turbo

That user does not exist as its just an example. Lets give a real life example:

Originally Posted by modrobert

If user "Turbo" gives more than one hit he is not a valid EAB forum user, or he entered the user name incomplete

Not correct. Check user AGN. Fully valid user.
If he tries to create an FTP account:
# python eabpostcount.py AGN
* Found more than one user: AGN

Why? There are other users that has the lettering agn in their name. All of them are valid

http://eab.abime.net/memberlist.php?...&ausername=AGN

That is because memberlist.php uses "like" instead of "=". Its not an exact match were getting but simply a "contains" search.

[modrobert]

Originally Posted by Turran

Not correct. Check user AGN. Fully valid user.
If he tries to create an FTP account:
# python eabpostcount.py AGN
* Found more than one user: AGN

Why? There are other users that has the lettering agn in their name. All of them are valid

http://eab.abime.net/memberlist.php?...&ausername=AGN

That is because memberlist.php uses "like" instead of "=". Its not an exact match were getting.

Yes, but my previous Bourne shell example adds the functionality you want by testing the result/exit code (-ne 0 / != 0) of eab_post_count.py. Here's the example again.

#!/bin/sh
USER="Turran"
OUTPUT=`eab_post_count.py "$USER"`
RTN=$?
if test $RTN -ne 0 ; then
    # user name not found or incomplete (more than one)
    echo "User not found"
    exit 1
fi
# we have a valid user name
# do your stuff here
echo "Post count: $OUTPUT"

Both incorrect and incomplete (more than one hit) user names will be rejected.

EDIT: I see what you mean now, finally, sorry for the misunderstanding. I will fix it.

[Turran]

Sweet =)

Is it possible to grab the "Last visit" as well as postcount? Then we check that as well. If the user has not been active/logged on to EAB for a while, we can deny the creation as well.

Then we might block (some of) the users just grabbing someone elses EAB Forums username to create an FTP account with..

[DannyBoy]

Damn, this was painful to read Hope you guys get them codes working

[Turran]

Perhaps we should move to PM =)

[modrobert]

No thanks, considering some of the crap posted in this thread so far, a bit of code can't hurt. Almost done.

[modrobert]

OK, edited my previous "release post" with new eab_post_count.py v1.0.

Changelog:

* Fixed bug with "more than one user", now compares given user name with output from EAB forum (thanks Turran).
* Added -i option to ignore case in user name, this has to be the last option on command line, default (no option) is now case-sensitive user name.
* User names with '<', '>' and '&' characters are now handled correctly by converting html escape codes.
* Result/exit codes are now as follows: 0 = user found, 1 = user not found, 2 = invalid option.

I skip the "Last Visit" option for now, vBulletin have these "Today", "Yesterday", "A week ago" and then "DD Month YYYY" strings, not something you can directly do math operations on, need a big table.

[Turran]

Thanks. Testing.

[Turran]

OK done. Thanks modrobert, it works fine. https://grandis.nu:444/eabadduser/ updated =)

[Dunny]

Worked perfectly, many thanks

[Turran]

Originally Posted by Dunny

Worked perfectly, many thanks :)

Postcount confirmed =)

17-10-30 17:11:24 - CensoredIP - OK Adding: User:Dunny Question:amiga PostCount:817
17-10-30 17:11:24 - CensoredIP - Result: 200 User (Dunny) successfully added.