icon.library 46.4 test versions

[mfilos]

Wrong library thread mate.
This should be moved to the Icon.library thread instead

[prowler]

Two posts moved to icon.library thread.

Thanks Marios!

[PeterK]

Thanks prowler

when I use the original icon.library and open my App on an own screen, the icon colors are wrong. When I use your lib, the icon colors are correct. Can you tell me why?

Hi AGS,
it's probably showing the correct colors only with direct drawing (that can't be wrong) but not in 8-bit or AGA screenmodes.

I guess, you didn't call LayoutIconA() for mapping the icons to your screen colors first.

	LayoutIconA -- Adapt a palette-mapped icon for display (V44)

   SYNOPSIS
	success = LayoutIconA(icon,screen,tags);
	D0                    A0   A1     A2

	BOOL LayoutIconA(struct DiskObject *icon,struct Screen *screen,
	                 struct TagItem *tags);

	success = LayoutIcon(icon,screen,...);

	BOOL LayoutIcon(struct DiskObject *icon,struct Screen *screen,...);

   FUNCTION
	This function will prepare an icon for display, either on a
	specific screen or using a default colour palette. It is
	useful only for palette mapped icons.

   INPUTS
	icon -- The icon to be remapped. This must be a palette mapped
	    icon.
	screen -- Pointer to a screen to remap the icon for or NULL
	    to remap the icon to use the system default colour palette
	    or something very similar to it (this means: four colours
	    only).
	tags -- Additional rendering options.

[AGS]

Thanks, I think I will modify my code to use this call. Or advise the users that your lib is required?

[PeterK]

No, without calling LayoutIconA() you will get the same wrong colors on all AGA screens, no matter which icon.library your users have installed. And only the direct drawing hides this missing colormapping, because it reads the RGB colors (instead of any pens) and writes them directly onto all Hi/TrueColor screens. Read the icon.library autodocs for the details, plz.

[Retrofan]

Originally Posted by PeterK

I guess, you didn't call LayoutIconA() for mapping the icons to your screen colors first.

Hi PeterK: woudn't it be possible to add a fuction like this to your library, so the icons could use some good palette like Rebel's one?

Edit: And why the colors are better if using 16 colors I just save the icon image as png? The png has better colours than the icon. Yes, newbie quesions I know.

[PeterK]

1.) LayoutIconA() is a function of the icon.library already.
Mapping to Rebel's palette is done anyway if it's defined (locked) by FullPalette.

Seems, that I miss the point in your request, where is the problem?

2.) How are you watching the PNG image, on which screen (depth) ??

It's probably because Multiview maps the RGB truecolor values in just one step and with Floyd Steinberg Dithering to the screen colors instead of reducing the number of colors first to less than 256 and then mapping without real dithering to the screen colors.

But be sure that Multiview will need much, much longer for its job !

[Retrofan]

Originally Posted by PeterK

1.) LayoutIconA() is a function of the icon.library already.
Mapping to Rebel's palette is done anyway if it's defined (locked) by FullPalette.

Seems, that I miss the point in your request, where is the problem?


2.) How are you watching the PNG image, on which screen (depth) ??

It's probably because Multiview maps the RGB truecolor values in just one step and with Floyd Steinberg Dithering to the screen colors instead of reducing the number of colors first to less than 256 and then mapping without real dithering to the screen colors.

But be sure that Multiview will need much, much longer for its job !

Look my pic. It is using a locked 16 colors palette. Perhaps am I missing the way to lock also the icons? The image 16CRebels is opened with Multiview, but it will be anyway different (more color) with PicShow from the original Utilities icon.


As I say the screen has just 16 colors, so the icons look greyed, but see how it looks just saving the icon as png (no palette used to save it). That's using PicShow.

http://imagizer.imageshack.us/v2/800...0/849/n5r4.png

[PeterK]

Post your ENV:FullPalette.prefs file, plz. Thx.

[Retrofan]

From EnvArc/Sys:


Edit: I would say the only icons that don't look good are ken's drawers, but as you know they are the most of them. I think it's a lack of blue what they have got using your library, Rebel's palette and 16C.

[AGS]

Peter, you are Icon-Library Expert. Is it required to match a GetDefDiskObject() with FreeDiskObject()?

[Retrofan]

Could you make perhaps a library just for Rebel's palette? Maybe I'm asking too much, but think that CWB and AK Real use it, and this thread has over 52.000 visits.

[PeterK]

Originally Posted by AGS

Peter, you are Icon-Library Expert. Is it required to match a GetDefDiskObject() with FreeDiskObject()?

GetIconTagList -- Retrieve an icon (V44)
This function is a superset of GetDefDiskObject(), GetDiskObject() and GetDiskObjectNew().

In any case you have to call FreeDiskObject():

A FreeList structure is allocated just after the DiskObject structure; FreeDiskObject makes use of this to get rid of the memory that was allocated.

[Michael]

We are asking to follow the standard OS prefs (borders ;-) ), as for palettes, it's not the libraries function, so you have to leave it to FullPalette, and iicon lib has a very good colour reduction/approximation algorithm, and a very fast one too. It would be nice to see an option to limit the number of free pens the icon lib can lock if it can not find a suitable available colour.

[PeterK]

Originally Posted by Retrofan

Could you make perhaps a library just for Rebel's palette? Maybe I'm asking too much, but think that CWB and AK Real use it, and this thread has over 52.000 visits.

And what should that special library do?
No screenshots please !
If there are no suitable pens for the required blue in Rebel's palette then you have to change the palette. An example FullPalette.prerfs file is attached, but you can optimize it with the preferences tool of FullPalette.


@Michael

It would be nice to see an option to limit the number of free pens the icon lib can lock ...

Icon.library locks not a single pen. These colors are all shared pens. On 256 color screens it leaves about 20 pens unused for other apps, but if I do that on low depth screens then the color mapping would give very poor results. Try to set the icon quality to a lower value in Prefs/Workbench.

[Retrofan]

Thanks PeterK. In fact I was trying that, to change the palette, but there were two things pushing me back:

-Rebel took a couple of years to make it.
-I've got deuteranopia (I confuse some greens or see as other color).

So I was waiting something like this. I will gladly try it. Thanks.

Edit: Much, much better blue on the drawer icons now (well, before there wasn't). Will try it more anyway. Thanks again.

[Retrofan]

Peter sorry if maybe it's a bit offtopic. I've got installed your Fullpalette prefs -wonderful-, and I've made six more skins to add to my version. The thing is that once using them they look marvellous. I take then a png photo with sgrab and looks the same with picboot or multiview, but when I reboot with other skin, the previous photo doesn't look as good as it was; isn't smooth. So for example with MorpheuZ that shows a preview of all the skins, only the current one will look perfect.

Do you know why?

http://imagizer.imageshack.us/v2/800...0/585/vr4x.png

Edit: On the contrary: http://imagizer.imageshack.us/v2/800x600q90/11/emuq.png

[PeterK]

This behaviour may be caused by the dithering procedure of your PNG datatype. I don't know what exactly you mean with "isn't smooth", but from my point of view the first screenshot "vr4x.png" looks a little bit better.

Check the preferences of your PNG datatype for color quality and other settings.

[PeterK]

Update to icon.library 46.4.334

Just some very small fixes:

1) Saving a tool or project icon with IconEdit in its program directory (no path) and without a name, simply as ".info", will not change the icon type to drawer anymore. This was requested by a user to create an invisible icon by deleting the first image in order to use it as a placeholder behind LimpidClock.

2) The first default color icons that are displayed by WB 3.0/3.1, like the Ram Disk or other disk icons , won't appear in 4-color mode anymore. There was no global screen defined in the icon.library settings.

[Michael]

Option to not modify OS4+ icon data during snapshot ? (Currently converts icons to OS35 icon format)

And default for frames ON if no env variable is set. (System default way) It will not heart anybody, since for normal WB you will have it set to no borders, if you like it so.