25 February 2013, 16:19 | #41 |
Amiga-based Cyborg
Join Date: Dec 2004
Location: Canada
Posts: 808
|
I noticed a problem with the replaced ("old style") scanlines - in 2.1.29:
I also noticed this when I attempted to use "old style" scanline code (from 2.1.19) in 2.1.27 - but I just assumed I screwed something up or missed something. Last edited by mr_a500; 25 February 2013 at 22:08. Reason: 2.1.27u was first version with problem |
25 February 2013, 18:17 | #42 |
Registered User
Join Date: Dec 2012
Location: Finland
Posts: 162
|
Tried scanlines-nonlinear and scanlines-classic. Both will give same error message. All other shaders I tried are working.
|
25 February 2013, 20:08 | #43 | ||
FS-UAE Developer
Join Date: Dec 2011
Location: Førde, Norway
Age: 43
Posts: 4,043
|
Quote:
Quote:
I haven't seen anything like that. But when I think of it, the scanline implemention may not work properly with (video format) rgb565. Is that what you're running? Does it work with video format rgba or bgra? |
||
25 February 2013, 21:37 | #44 | |
Amiga-based Cyborg
Join Date: Dec 2004
Location: Canada
Posts: 808
|
Quote:
Something you changed when making the scanlines as shaders is causing this problem. (It's not in scanlines.c because as I said, when using the one from 2.1.19 instead - the problem is still there.) |
|
25 February 2013, 21:39 | #45 |
FS-UAE Developer
Join Date: Dec 2011
Location: Førde, Norway
Age: 43
Posts: 4,043
|
OK, what was the last version where scanlines worked correctly for you? 2.1.19 does not work I gather, does for example 2.1.18?
|
25 February 2013, 21:54 | #46 |
Old fart
|
Strange, all shaders works for me. I just have latest intel driver.
|
25 February 2013, 22:07 | #47 |
Amiga-based Cyborg
Join Date: Dec 2004
Location: Canada
Posts: 808
|
2.1.19 was the last version with the old scanlines - working fine. 2.1.21 - 2.1.27 have the new scanlines - working fine. 2.1.27(u?) has the new scanlines re-implemented as shader. That's the first version with the problem.
|
25 February 2013, 22:33 | #48 |
FS-UAE Developer
Join Date: Dec 2011
Location: Førde, Norway
Age: 43
Posts: 4,043
|
@mr_a500. There's a couple of lines missing (for PPC), try this patch
Code:
diff --git a/libfsemu/src/emu/scanlines.c b/libfsemu/src/emu/scanlines.c index d7deb36..64849d6 100644 --- a/libfsemu/src/emu/scanlines.c +++ b/libfsemu/src/emu/scanlines.c @@ -37,6 +37,10 @@ void fs_emu_render_scanlines(uint8_t* out, fs_emu_video_buffer *buffer, continue; } for (int x = 0; x < cw; x++) { +#ifdef __BIG_ENDIAN__ + src ++; + dst ++; +#endif *dst++ = (*src++ * light_ia) / 256 + scanline_light; *dst++ = (*src++ * light_ia) / 256 + scanline_light; *dst++ = (*src++ * light_ia) / 256 + scanline_light; |
26 February 2013, 11:57 | #49 |
Old fart
|
Frode : i wonder, can you add this shader to be compatible with fs-uae?
http://www.sendspace.com/file/p8037b |
27 February 2013, 21:21 | #50 |
FS-UAE Developer
Join Date: Dec 2011
Location: Førde, Norway
Age: 43
Posts: 4,043
|
The shader language is GLSL, so the shader could perhaps work with FS-UAE with small modifications. It isn't enough that the language is OpenGL Shading Language, shaders must also know how to get the Amiga video texture (and other information) from the emulator.
FS-UAE loads shaders following the "XML Shader Format 1.1" (http://gitorious.org/bsnes/pages/XmlShaderFormat). So someone would have to rewrite the shader slightly. (Hmm, looking at the shader code, it uses two uniforms in addition to the video texture, color_texture_sz, color_texture_pow2_sz (vec2), and it is not immediately obvious what these are. FS-UAE do not provide such vec2s to shaders). |
27 February 2013, 21:34 | #51 |
Old fart
|
No problem thanks for trying
|
16 March 2013, 00:56 | #52 |
Missile Command Champion
Join Date: Aug 2005
Location: Germany
Age: 52
Posts: 12,475
|
|
17 March 2013, 22:52 | #53 |
FS-UAE Developer
Join Date: Dec 2011
Location: Førde, Norway
Age: 43
Posts: 4,043
|
@Retro-Nerd, Yes, though you can see a slightly annoying "wave pattern" in the solid color areas. See this thread on how to fix that: http://eab.abime.net/showthread.php?t=67535.
|
17 March 2013, 22:59 | #54 |
Missile Command Champion
Join Date: Aug 2005
Location: Germany
Age: 52
Posts: 12,475
|
Thanks for the custom theme settings. Looks really good now.
|
30 March 2013, 13:21 | #55 |
Registered User
Join Date: Jul 2009
Location: Middlesex, England
Posts: 141
|
After looking at this thread since I was watching a video at the same time I nicked these real scanlines from a youtube video where somebody recorded a video of an old game on his actual CRT TV.
So now we have a picture of some real scanlines maybe somebody can work on making a legit looking ones for our AMIGA emulator now and be the first emulator ever to have legit looking scanlines in the program? As you can see by the picture the legit style scanlines have large spaces in between each set and look diagonal half circle style. The real half circle scanlines also have verical scanlines going through them which are the Composite/RGB/RF/Component scanlines which come from the systems to make up the picture. So basiclly TV scanlines are oval rather than horizontal and Console/Computer scanlines are vertical both together making a real scanlines picture which it's what I gather from the picture. These oval scanlines look like a vortex into another dimension but they are at the same time actual CRT TV set ones as well. What retro beauty. I've now since last Janurary become a regular user of FS-UAE and WinUAE unless if I'm pratting about in Workbench GUI as my WinUAE hard drive files didn't want to work in it is an after thought as far as playing both disk and WHD games is concerned now so I'm a complete FS-UAE backer all the way. Last edited by TEOL; 30 March 2013 at 13:34. |
30 March 2013, 14:31 | #56 | |
FS-UAE Developer
Join Date: Dec 2011
Location: Førde, Norway
Age: 43
Posts: 4,043
|
Quote:
So this photo should not be used as basis for creating a scanline shader Btw, you'll also see similar problems in TV broadcasts if a person in a TV studio has a sweater with a detailed checkered pattern, for instance. Last edited by FrodeSolheim; 30 March 2013 at 14:41. |
|
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | |
Thread Tools | |
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Scanline modifications wanted | Retro-Nerd | support.FS-UAE | 8 | 20 August 2013 20:31 |
Scanline shader problem | TysonJacobs | support.WinUAE | 3 | 26 July 2013 09:43 |
Playing around with RGB/Scanline-Effect | lomaxx | Nostalgia & memories | 13 | 23 July 2009 14:08 |
Scanline option request | Christian | request.UAE Wishlist | 3 | 26 May 2009 22:24 |
REQ : Vistapro (Landscape Renderer) | Djay | request.Apps | 22 | 01 May 2002 22:47 |
|
|