icon.library 46.4 test versions

[PeterK]

Hi Peter, now finding fault with your library is very difficult

Never mind, Carlo.

At least the bug with overwriting the internal drawer data structure was caused by my Aros-like file type identification by using datatypes, which I implemented some years ago on your request for Aros One 68k. In that way you helped me to realize now that my assignment of internal data structures to deficons was no good idea, even if that was just a workaround for deficons with the wrong type (i.e. project icons for disks or drawers). Now these deficons will get a real copy of the drawer data structure.

[AMIGASYSTEM]

I'm glad that my little contribution helped something.

Have you seen my utmost binary and data icons for AROS one ?

https://eab.abime.net/showpost.php?p...6&postcount=30

[PeterK]

Wow, looks great! It seems that you found a nice way to kill time ...

[PeterK]

Yet another experiment with icons ...

 The 2 commands ColorIconsOff and ColorIconsOn
 should be started as the first and the last
 programs in the WBStartup drawer, if possible.

 ...

Updated, see below ...

[mfilos]

Thanks for that Peter. Seems to work just fine but haven't experienced any significant speed change on my Vampire V4SA under RTG (720p@24bit) using OS4 MasonIcons as iconset (using TC020 under OS3.2.2).
Every bit of improvement helps though so cheers again \o/

[PeterK]

The main purpose of these two commands is to get more free pens (on RTG with OS4 or PNG icons) or at least a better color selection and WB screen palette. A minimal faster booting could just be a nice side effect, but it won't be much, unless you have a huge number of icons in your WBStartup drawer.

The reduced memory consumption is also not really much, a few kB less FastMem for the chunky palette based images or even for ARGB images. This should not have any effect on free ChipMem.

[pcotter]

Hi Peter, is it working with your Dopus Magellan setup?
Here it crashes IF started from the Icon...
Regards

[PeterK]

Hi Pedro,

thanks for reporting this! Confirmed, the same happens here with DOpus5 standalone, but not if launched from Workbench, as I usually do it.

It seems that DOpus5 doesn't like my shell commands?! Maybe it ignores the "CLI" tooltype? Ok, I could do some more investigations or start it with IconX from a shell, but anyway, these two commands are not made for DOpus5, at least not yet.

Update: Starting these commands directly from a shell has no effect at all on DOpus5! That's strange, because I'm using icon.library function calls directly (IconControlA()).

[James]

Originally Posted by PeterK

Maybe one of the icon designers can create a
couple of suitable icons for these 2 commands.

Decided to have a go at this. Noticed you had my truecolour icon as an alternative, so modified it to be more suitable then reduced it down to the 4 OS colours for the ColorIconsOff icon.



Get the icons here:

https://drive.google.com/file/d/1rke...ew?usp=sharing

Might do a few more to fit different icon styles...

[PeterK]

Excellent, thanks a lot James!

Due to the problems with DOpus5 and its program launcher which doesn't support the "CLI" tooltype and just crashes with shell commands I think I have to add some WBstartup code to my programs, something I never did before.

I also tried to use project icons with WBRun or IconX, but then my "STARTPRI" tooltypes and settings seem to be ignored.

Now I have to find out how to create a minimal WBstartup code without needing any args, input and output, message port and other bloated code.

Ok, I found some short examples for a minimal WBStartup code in assembler ... but the message handling seems to be mandatory, although I don't like talking too much ...

[PeterK]

An updated version of my experiment with WBStartup code included now as a fix for DOPus5 crashes. The "CLI" tooltype is not required anymore.

ColorIconsOff and ColorIconsOn for WBStartup:

 These commands are for an icon.library v44 or
 newer and may save lots of pens on RTG screens
 with my TrueColor v51 libraries. For non-RTG
 screens or with the OS icon.library you may at
 least get better colors for the visible icons
 and applications on the Workbench instead of
 wasting pens for unused icons during WBStartup.

 On Amigas with a low number of icon and screen
 colors you may not have any noticeable benefit.
 On my RTG system with OS4, PNG and ColorIcons
 I can get 205 free pens now instead of only 95.

 The 2 commands ColorIconsOff and ColorIconsOn
 should be started as the first and the last
 programs in the WBStartup drawer, if possible.

 They are doing the same as the WB-Prefs switch
 "NoColorIcons", without using <IPrefs> for it.

 Installation: Copy BOTH icons into WBStartup !

 These commands must be started with tooltypes
 "DONOTPROMPT", "DONOTWAIT" and a very high or
 very low "STARTPRI" setting like +127 or -127.

 A minimal WBStartup code is included now, thus
 you won't need a "CLI" tooltype, because it's
 not supported by the DOpus5 program launcher.
 DOpus5 won't crash, nor has it any advantages.

 In case you have tools in WBStartup that don't
 work correctly with this "NoColorIcons" config
 then you could try to launch your tool before
 ColorIconsOff starts or after ColorIconsOn by
 adjusting your "STARTPRI" values a little bit.

 Adding these two commands can also save a few
 kB of memory and reduce the boot up time a bit
 since color mapping + C2P is not done anymore.

 If you want to check the number of shared and
 free pens then look into Scout's window list
 for the Workbench screen. Highest improvements
 are possible for a WB with TrueColor icons. A
 lot more free pens are remaining for your apps
 like IconEdit. You may get the highest number
 of free pens by using the WB-Reset menu entry,
 but nobody always wants to reset his Workbench.

 You can also find some alternative icons as a
 replacement for those in the WBStartup drawer.
 Thanks a lot to James for creating new icons.

 This is just another experiment with icons and
 you are welcome to report any problem cases.
 Maybe some AppIcons are appearing in 4 colors
 only for applications launched from WBStartup,
 but I couldn't find such an example yet.

 Have fun ...

[James]

Icons in KensV3 (256 colour) and OS3.2 style:



Download:

https://drive.google.com/file/d/1M62...ew?usp=sharing

[PeterK]

Thanks again, James!

But the typical icons of OS 3.1.4 and 3.2 are all sharing the same set of colors, a standard palette (see below) which Mason used for them. That's one reason why my attempted pen saving in WBStartup has no effect on systems with these icons. Unified icons cannot create wrong colors in the screen palette.

[mfilos]

I used a palette icon from MasonIcons collections removing color for the OFF app and using the normal one for the ON app... lol



Attaching here as well if anyone uses OS4.1 iconset

[James]

Originally Posted by PeterK

Thanks again, James!

But the typical icons of OS 3.1.4 and 3.2 are all sharing the same set of colors, a standard palette (see below) which Mason used for them. That's one reason why my attempted pen saving in WBStartup has no effect on systems with these icons. Unified icons cannot create wrong colors in the screen palette.

Then using my icon on their system will make your programs useful.
Haven't really paid too much attention to the OS3.2 icons as I am happy with my truecolour icons. Wasn't really concerned about making a real OS3.2 icon, the idea was just to make a 32 colour icon that fit with that general look - for those that might prefer that style. I doubt many people only use OS3.2 icons as there are not many available at the moment, so your programs will still be useful to most people.

[PeterK]

Originally Posted by mfilos

I used a palette icon from MasonIcons collections removing color for the OFF app and using the normal one for the ON app... lol
....
Attaching here as well if anyone uses OS4.1 iconset

Many thanks for your nice contribution, mfilos!

I will add your icons to the next update together with some of James' icons.

Btw, could you achieve a higher number of free pens on your RTG Workbench as intended? Of course, there are also other programs which may allocate pens like FullPalette or MagicMenu.

[mfilos]

Originally Posted by PeterK

Btw, could you achieve a higher number of free pens on your RTG Workbench as intended? Of course, there are also other programs which may allocate pens like FullPalette or MagicMenu.

I'm using both FullPalette and MagicMenu tbh.

FullPalette is used for locking the first 8 colors for MagicWB palette icons although under OS3.2.2 I saw that I can accomplish that by commenting FPPrefs and enabling "Set MagicWB Colors" under Workbench Prefs. While being more system friendly (and not an invasive patch) FPPrefs still has it's own pros if you for example wanna use Rebel's palette (or your modified one) for 16 color leetness (which ofc doesn't matter for RTG screens). What would you suggest in my case tbh?

MagicMenu is only used for the right click menus. I haven't ever messed with the "Colour control" tab although checking it out, I see it uses "GUI" option under "Colour matching precision" and has the "Prefer screen colours" option ticked. (I guess this is the default one)

[PeterK]

No, you don't need FPPrefs just for setting the first 8 pens to MWB colors since WB v45+ has this Preferences switch. In case that you have some MWB icons which are still using the last 4 pens of the screen palette then you could also fix that with my optional command "Reduce8PlanesTo3". This would also make these "bad looking" MWB icons smaller, when you save them.

For Rebel's 16 color palette or my HAM6/8 colors FullPalette is still required. Rebel's palette can be quite useful on low-end systems.

For MagicMenu I use the same settings as you mentioned already.

Now, you still didn't tell me how many (more) free pens you can get in Scout's window list for a Workbench TrueColor screen after booting? I hope that not only my system gets much more, but nobody has confirmed that yet.

[mfilos]

Originally Posted by PeterK

In case that you have some MWB icons which are still using the last 4 pens of the screen palette then you could also fix that with my optional command "Reduce8PlanesTo3". This would also make these "bad looking" MWB icons smaller, when you save them.

I'll be damned Peter! I never knew that sort of trick! I always used FixMWB to fix these icons that had this sort of issue (without knowing exactly what was the problem. It makes perfect sense now, and since using the optional command "Reduce8PlanesTo3" I don't have to convert anything again! Brilliant \o/

Originally Posted by PeterK

Now, you still didn't tell me how many (more) free pens you can get in Scout's window list for a Workbench TrueColor screen after booting? I hope that not only my system gets much more, but nobody has confirmed that yet.

Sorry for not answering sooner...
Using your new commands I have: 256 shareable, 228 used and 28 free on OS3.2.2 boot
Not using your commands I have: 256 shareable, 229 used and 27 free!

[PeterK]

Originally Posted by mfilos

I'll be damned Peter! I never knew that sort of trick! I always used FixMWB to fix these icons that had this sort of issue (without knowing exactly what was the problem. It makes perfect sense now, and since using the optional command "Reduce8PlanesTo3" I don't have to convert anything again! Brilliant \o/

It just removes the 5 redundant planes, all containing the same useless data, but wasting a lot of space.

Sorry for not answering sooner...
Using your new commands I have: 256 shareable, 228 used and 28 free on OS3.2.2 boot
Not using your commands I have: 256 shareable, 229 used and 27 free!

Hmm, that's not really that kind of impressive improvement as expected, just 1 more free pen?! It looks more like the result of an 8-bit chunky or 256 color planar screen, but not like a Hi/TrueColor system with OS4 or PNG icons.

On a Hi/TrueColor system the icons should not need any color mapping, nor pens. Even ColorIcons are directly drawn in their exact RGB colors on the gfx-card. (Do you have "ConvertTrueColor" enabled ?)