12 July 2011, 03:48 | #21 |
Banned
Join Date: Jan 2007
Location: France
Posts: 655
|
@Don Adan
mfilos cannot get a boot : if some removed code are really usefull, I'll put it back of course ! |
12 July 2011, 12:56 | #22 |
Registered User
Join Date: Jan 2008
Location: Warsaw/Poland
Age: 56
Posts: 2,038
|
I don't know your experience in resourcing of 68K files (especially binary), but if you think that no direct entry code, can not be called that you are wrong. Here is resourced DOS from ROM 3.0 and almost all code has access. This version is perhaps correctly resourced, but I'm not checked this exactly. You can easy found how all (?) routines are accessed.
I think similar, for me resourced version of every ROM parts must be available for check by other coders, due more bugs can be found in original or optimised code or wrong ROM resourcing. Anyway Cosmos made something, other coders are too lazy. Last edited by TCD; 12 July 2011 at 13:34. |
12 July 2011, 13:21 | #23 | |
move.l #$c0ff33,throat
Join Date: Dec 2005
Location: Berlin/Joymoney
Posts: 6,863
|
Quote:
It would be better if he wouldn't "optimise" system libraries by deleting "unused" code at will. He's not optimising, he's destroying these system libraries. But well, since I didn't want to comment here anymore, I'll stop here. |
|
12 July 2011, 13:37 | #24 | |
Registered User
Join Date: Jan 2008
Location: Warsaw/Poland
Age: 56
Posts: 2,038
|
Quote:
First step for optimise/fix Amiga ROM parts is 100% correctly resourced version of Amiga ROM. When I resourcing ROM 3.0/3.1 I found some traps for people without knowledge, of course I'm not 100% sure if my version is correctly resourced. Only a few lines of Amiga ROM is perhaps unused, all other parts has direct or hidden access to data/code. |
|
12 July 2011, 19:12 | #25 |
Banned
Join Date: Jan 2007
Location: France
Posts: 655
|
>It's especially funny considered that I often helped him with code when he had questions
WHAT ?? Few years ago, you promise me the Kickstart 3.0's sources. I sent you an A4000 Kick 3.9 on eprom for free to thanks you. And after you refused to search these sources on your CDs/DVDs... >he's destroying these system libraries C/C++ compilators produce a lot of unused code... Ask some other disassembler coder here, they'll say my same words ! Why keeping unused code ? Remember that Rom space is small on our Classic, every unused bytes removed are important : why this evidence is so hard to understand for your mind ? |
12 July 2011, 19:37 | #26 | ||
move.l #$c0ff33,throat
Join Date: Dec 2005
Location: Berlin/Joymoney
Posts: 6,863
|
Quote:
And as for your "WHAT ??", how often did you ask for help in a certain coders channel? Already forgotten, eh? Quote:
IF and only IF the code is unused, then there's no problem to remove it. But since in your world every routine that has no entry point is "unused" I wouldn't trust ANY of your disassembled code. Oh dear.... You should first learn more about disassembling and/or coding in general, then you might understand certain things. Maybe. |
||
13 July 2011, 01:38 | #27 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,383
|
OK, if there are other references to AJL_0_204E6 with D0 as argument, then, of course, this forces to use your fix. Anyway, these numbers are looking like DOS error codes, probably for IoErr() or RC2, so not really a big bug if they are wrong. But you will know that already if you really analyze the code before you change it, do you? --- Btw, DeleteVar() is only trashing memory in case of a failure. Thanks for checking that!
|
13 July 2011, 02:18 | #28 | |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,383
|
Quote:
Concerning unused or dead code: In most libraries is some dead code without any reference from any function. And if you really made a 100% correctly recoded version first and then analyzed every ASM line you will know if there are "hidden" references or not. And if not, you can safely delete it or replace it with by an Alert() message. But sometimes, there are large parts of the code without being necessary for any good reason. For example, in the icon.library 45.1 there exists some code for unlocking the AWeb Special Edition which comes bundled with OS 3.9. And there are some Easter Eggs, some gimmicks made by the author of the library, which can be removed, of course, since only the author will know how to trigger and enjoy them. |
|
13 July 2011, 03:58 | #29 |
Banned
Join Date: Jan 2007
Location: France
Posts: 655
|
StingRay play with words, end of discuss : you are not ready for anything... Go do nothing for Amiga computers and get out of my life...
|
13 July 2011, 05:18 | #30 | ||
Banned
Join Date: Jan 2007
Location: France
Posts: 655
|
@all
Some explanations of what I'm doing into this library : Original code from the v40.3 Quote:
Now in the v40.4b1 Quote:
More than two times faster... So my reworked libraries are usefull and not pointless ! Last edited by Cosmos; 13 July 2011 at 05:35. |
||
13 July 2011, 07:47 | #31 |
Protracker
Join Date: Sep 2008
Location: 8364
Posts: 381
|
|
13 July 2011, 09:51 | #32 |
move.l #$c0ff33,throat
Join Date: Dec 2005
Location: Berlin/Joymoney
Posts: 6,863
|
Go and look for a job as politician, would be the perfect job for you! First you spread LIES and then it's me who's playing with your words, classic!
Fact is, you are a LIAR and all of your patches are of dubious quality. They can be trusted as much as your words. Why don't you open a public SVN/GIT repository and commit your code for everyone to see? There might be a reason why almost only people who are no coders use your patches. 'Nuff said. That sentence is almost correct, one of us is indeed not ready to disassemble and "optimise" system libraries. Haha good joke. I do indeed prefer to do nothing instead of claiming I have "size optimised" certain libraries when I don't know what I'm doing. I could post some of your questions you asked me here so people would see how good a coder you are... I for example fondly remember how you asked about detecting expansion boards with board.library. Who was it who gave you the code after a few minutes? And I didn't have any docs about that library, just like you. But contrary to you, I know what I'm doing when it comes to disassembling certain system libraries so I didn't have any problems to give you working code which you happily took. So really, shut your mouth. How about posting the routines you have "optmised", read: removed from the library instead of boasting about your "optimising" skills Mr. "shorter code is always faster"? |
13 July 2011, 09:59 | #33 |
Banned
Join Date: Jan 2007
Location: France
Posts: 655
|
I said the thruth, you play with words, not me...
And no shame to ask silly questions sometimes, no shame to be a beginner, I started from zero... Most of the time on this thread, you don't know about what you are talking... The best way for you is : do nothing... And thank you for that ! |
13 July 2011, 10:10 | #34 | |||
move.l #$c0ff33,throat
Join Date: Dec 2005
Location: Berlin/Joymoney
Posts: 6,863
|
Ok, here we go:
That's the first of your lies. I never promised you anything, I said I'll check my backups if I still have these sources. Not more, not less. That's the second of your lies, it's indeed true that you sent me a ROM but not to thank me, you just asked if I wanted a ROM and I said "why not". Quote:
So much for "playing with words". Quote:
Quote:
You have no clue what you are doing but you don't want to admit it. So again: Why don't you open a public GIT/SVN repository so everyone can see your code? Yeah, another good joke. At least I don't release countless dubious patches and claim I have "optimised" system libraries. And I let other people comment if I do "nothing" or not. |
|||
13 July 2011, 10:17 | #35 |
Protracker
Join Date: Sep 2008
Location: 8364
Posts: 381
|
Stingray is one of the most competent Amiga reverse engineers on the planet, why would you even start some shit like that with him? He's contributed more fixes to the amiga community than you have entered ascii chars in this thread, yet I haven't seen that much by you to be honest.
Don't get me wrong, it's really nice you're doing stuff and are atleast trying to hack that lib, just don't say he's doing nothing for the Amiga and that he's not ready for it. That's just ridiculous. 2 cents deposited. |
13 July 2011, 11:10 | #36 |
Registered User
Join Date: May 2011
Location: Funeralopolis
Posts: 91
|
Isn't this thread supposed to be about the dos.library? Now it turned into a flamewar who is the better coder and who is not.
Though I am no Amiga coder I am more interested in dos.library than in idle talk from both sides... |
13 July 2011, 12:16 | #37 | |
Registered User
Join Date: Jan 2008
Location: Warsaw/Poland
Age: 56
Posts: 2,038
|
Quote:
I checked a few more my resource and DOS library has much more bugs. Seems that minimum two coders works on this library, one (worst) uses next style of coding: moveq #$69,D0 rol.l #1,D0 second (better) uses moveq #$69,D0 add.l D0,D0 The best for ROM (short code) and 68000 (fast code) is moveq #$69,D0 add.w D0,D0 One time I found only moveq #$69,Dx perhaps add.w Dx,Dx is missing and this is perhaps next bug. This routine can be also handled by D1 due before error (AJL_0_204E6) routine is also move.l D1,D0, but of course D0 version is much better (shortest/fastest). Yes, fastest, but it will be works OK if you have/use correctly resourced DOS library or will be crash due you change size and place of code. Last edited by TCD; 13 July 2011 at 12:37. |
|
13 July 2011, 16:50 | #38 | |||
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,383
|
>>...the resulting executable should be 100% identical with the original after adjusting the hunk order and the RELOC handling....
Quote:
I thought we were talking about executables, like libraries, or don't we. Libraries usually start with a MOVEQ #-1,D0 and RTS to prevent direct execution. Different assemblers should not make different opcode as long as you switch all optimization options off when you're reproducing the reference version of the code. Quote:
Quote:
|
|||
13 July 2011, 17:48 | #39 |
Join Date: Jul 2008
Location: Sweden
Posts: 2,269
|
Cosmos, don't let Stingray and the others deter you. You're doing a good thing here no matter what methods you use or how you go about it
|
13 July 2011, 17:52 | #40 |
move.l #$c0ff33,throat
Join Date: Dec 2005
Location: Berlin/Joymoney
Posts: 6,863
|
Hooray for a typical Leffmann post! Praise everything no matter how bad it is. That's what we need. \o/
|
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | |
Thread Tools | |
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Open-source dos.library | Don_Adan | Coders. System | 273 | 02 September 2020 00:42 |
execute function from dos.library | Foul | Coders. Asm / Hardware | 5 | 08 August 2012 17:56 |
dos.library Open() hangs | MrD | Coders. Asm / Hardware | 15 | 24 July 2012 19:55 |
graphics.library 40.25 beta series | Cosmos | Coders. General | 337 | 22 July 2011 18:15 |
Dos.library question. | Thorham | Coders. General | 2 | 11 January 2011 21:03 |
|
|