![]() |
![]() |
#21 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
Because it's my CF mounted on WinUAE and these are Windows disks mounted for easy transfer (without disk.info)
![]() |
![]() |
![]() |
#22 |
Registered User
Join Date: Aug 2014
Location: Brindisi (Italy)
Age: 70
Posts: 8,273
|
If you want you can make them clearly visible with "IconGhostingOff," which you can find in PeterK's IconLib package
|
![]() |
![]() |
#23 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
Yes I know mate. I don't mind having these ghosted though
![]() |
![]() |
![]() |
#24 | |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Quote:
But I don't know if I actually can properly test it because I never tried the whole long name thing, so I might end up sending you a private message with one or two alternatives. Just to keep this thread a bit cleaner. ![]() Last edited by EctoOne; 05 June 2023 at 09:31. |
|
![]() |
![]() |
#25 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
Totally agree mate. I'll try and see what I can find as well
![]() |
![]() |
![]() |
#26 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Actually give this one a try. DirII was obviously cutting of the filename so I hope the replacement works fine.
I've also merged the two archives. The version number is 9.4. 9 for IconSaver and 4 for PositionSaver. I've also removed the reboot package(MSys-1.2), but the function is still there. If there is an reboot command available of course, and I added that to PositionSaver as well. So, WB3.1 users either have to copy the reboot command from the install disk (I really don't understand why stuff like that and IconPos isn't copied by default) or get the MSys-1.2 package from Aminet. I also decided that IconPos from the Install Disk gets copied to SYS:C/ since it is an original Workbench command. I'll keep the old files in my previous post until it's confirmed that this one works. Edit: File removed. See new version below. Last edited by EctoOne; 05 June 2023 at 23:06. |
![]() |
![]() |
#27 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
New version works Fantastic man with no errors on archiving!!! Kudos!!!
![]() Only thing it needs to work ok is to add the actual empty "IconArchives", "IconPosition" drawers as there's the .info without the drawer and if it doesn't exist the script throws an error ![]() Not anything important, but at this elegant solution, one little thing to add! Thanks a lot for the wonderful job man! Bellow are some edits to the post after finding issues that thought of sharing to ya:
Last edited by mfilos; 05 June 2023 at 16:29. |
![]() |
![]() |
#28 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Geez, looks like I was to hasty releasing that version. Thanks for reporting. I hoped I have fixed most issues with this one. And yes, I added a Request Device command.
Also IconPos is back to being stored in this folder instead of C. I moved the template icons into the subfolders to avoid the problem of not having them when extracting this archive. But there's also an additional check in the scripts which will create them if they somehow disappear. I still have to look into that "object is not of required type" thing, but I wanted to release this fixed version first. Version 11.06 should fix this. Luckily it's a simple error message that I can delete with Rep. There was also different message if an info file was empty (size 0), that gets also removed. And now the stored archives/scripts have the device name as prefix to easily see which drive they belong to. Something like DH0-20230606... Edit: Removed file. Last edited by EctoOne; 06 June 2023 at 09:21. |
![]() |
![]() |
#29 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
On a first test both scripts seem to work just fine man! Fantastic!
I saw you use the extra rt_RequestDevice although OS3.2.x has it's own. Then again the external one can only select Drives (which is more appropriate than drivers and drawers). The only issue atm I'm seeing is some files in my root drive's archive named "unnamed.dat" which ofc are not present in my root drive. Will investigate more and report back. Thanks for your hard work man! I greatly appreciate it. ( Cheers for the doc mention as well \o/ ) |
![]() |
![]() |
#30 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Are you sure about the RequestDevice thing being available on 3.2? I only have the ordinary RequestFile. Which I could have used but it would probably be to much work to get just the device name. It probably would even require another optional tool. This was way easier to add. RequestFile could be useful if I wanted to add support to only save certain directorys, but I honestly don't see any need for that.
I recently spend some time messing with RequestFile for something else, and it was annoying to get a function working which was kind of failsafe. And that was just for my personal use, I don't even want to think about implementing this for anyone where I don't know how or what they are trying to select. ![]() I was considering using it to input your own file name, but that also would enable them to save it in a different directory. Which wouldn't work for the archives if CLICon wasn't installed manually. |
![]() |
![]() |
#31 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
Yes you are right. I tried a stock 3.2.2.1 installation and RequestDevice wasn't present (alas I must have got it at some point from my own stash of commands I try over the years).
I totally agree with your way of thinking and rt_reqdevice is safer and easier to use. Btw, the first time I tried the PositionSave script gave me a bunch of IconPositions/IconPos not present... I manually copied it from C: to IconPositions/IconPos drawer and worked like a charm afterwards. I checked your script and it's supposed to raise a requester in order to copy it but it doesn't work :S I don't see any problem with the script as well (dafuq). I erased it again and tried, and still the requester doesn't show... Edit: Ok if you have IconPos on C: (or in path whatsoever) then the requester doesn't show. If you rename or remove it from C: then it works just fine (and it's logical cause the "Which IconPos" returns as TRUE so it doesn't enter the WARN statement. I guess it needs another "copy IconPos IconPosition/IconPos" declaration in ELSE - but with the source as the path from Which, that you need to store) ![]() Edit 2: Trying to check the "unnamed.dat" entries of the backup but neither ILIST contains entries with "unnamed" neither my SYS: drive contains any "unnamed" entry... WTF? Edit 3: Ok I found it... I found the unnamed files after unarchiving them and from the contents of the files I assumed it was TurboCalc so I went in TurboCalc's drawer and found under a toolbars drawer that there were some .info files that had "space" on their filename. All of these unnamed files are the files with the "space". I attach them into an archive here to have a look. Can you do something for them as well? Last edited by mfilos; 06 June 2023 at 08:42. |
![]() |
![]() |
#32 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Ahh, yes. I try to run IconPos from IconPositions/IconPos when generating the script. Of course that fails. When I rewrote that part I moved IconPos from C. That's why I had no issues. I will change it back to just copy it to C. That would be the easiest solution. Or I either copy it twice or temporarily add IconPositions to PATH. I'll have a look.
I have no idea what's going on with the unnamed.dat files. Maybe it has to do with your weird long names or wildcard characters. And LhA moves them into root because it can't handle them? I don't know. |
![]() |
![]() |
#33 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
I think that best solution is would be to Copy it to C: as it's a WB command that could be used elsewhere.
Also the naming with spaces was annoying in scripts but you always solved that issue with using "". Sadly I dunno how LhA handles them (but I was rather certain that it supported it). Edit: OK I managed to bypass the issue by removing the option Qw (that disables wildcards) in the 2nd LhA declaration. Do you think that this could create other issues? I havent' seen any actual problem so far. PS. As a sidenote... what does the "4" option do (checking from your first "LHA r -axXH0ND4" declaration). I checked my LhA command and only has referece up to "3" and 1-2-3 are compression version methods. Last edited by mfilos; 06 June 2023 at 09:12. |
![]() |
![]() |
#34 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
I agree with copying to C. And I couldn't think of a good way to add it to PATH. So I just deleted two lines and changed the target. Done...
![]() I'm not speaking about spaces in names, I was talking about the brackets ([{}]). Like I posted before, the guide says LhA can handle them with a certain option but that didn't fully worked for me. Maybe you have something like that and LhA can't correctly handle the path created by Match. Do they have the same size or any size at all? Maybe you could try to use something like SimpleFind to search your drive for that particular size. Here's the updated version that copies IconPos to C. Edit: Just saw your edits. I will look into the files containing spaces. And the 4 in the LhA command is for the D in front of it. It's to show the progress bar window instead of text in the shell window. And I really don't know about the wildcard thing from LhA. I assumed that would help with the other problem I mentioned in the crossed out text. I think without it, LhA won't add files with/from paths with brackets. Edit2: Umm, I have no issues with the files you uploaded. I have extracted them into a folder in RAM, ran the script and inside the archive they are correctly placed in that folder. Last edited by EctoOne; 06 June 2023 at 14:40. |
![]() |
![]() |
#35 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
Yes the files in the archive I attached got screwed (they had space in the filename that was replaced with the underscore _ due to DOpus. If you rename the underscore TO space you can test it out correctly.
New "SavePositions" version still has issues concerning IconPos (if it's already in C:, have to copy it manually from C: to IconPosition/ drawer) ![]() I guess you have to change Code:
MATCH ${DEV} TYPE FILE NAME #?.info LFORMAT "IconPositions/ICONPOS *"%R*" >>T:IPLIST" >T:ILIST Code:
MATCH ${DEV} TYPE FILE NAME #?.info LFORMAT "C:ICONPOS *"%R*" >>T:IPLIST" >T:ILIST Example: Code:
1> ICONPOS DH0:Programs/Productivity/TurboCalc/Toolbar/Create Chart type=PROJECT 239 4 bad number 1> ICONPOS "DH0:Programs/Productivity/TurboCalc/Toolbar/Create Chart" type=PROJECT 239 4 DH0:Programs/Productivity/TurboCalc/Toolbar/Create Chart type=PROJECT 239 4 Code:
SYS:Programs/Productivity/TurboCalc/Toolbar/Create Chart type=PROJECT 239 4 Edit: Now that I thought it it's not that hard... Just replace <space>type= with "<space> type= AND $DEV with ICONPOS "$DEV" with extra caution on the quotes ![]() Concerning the "SaveArchives" and the unnamed.dat files, i'm still under heavy investigation as I have backed up icons with spaces just fine, but these specific unnamed.dat files are due to other filenames... will report back with my findings. Edit: Ok case dismissed. Turned out to be a second sub-drawer named Toolbars2/Toolbars/ with the same icons that created the issue... dunno if it's due to filename depth or same filename, but once I removed this drawer, the unnamed.dat files went away. Sorry for busting your balls... it's just that I find this script rather fascinating, and wanted to troubleshoot it as much as I could to make it worthwhile ![]() Cheers man! \o/ Last edited by mfilos; 06 June 2023 at 13:35. |
![]() |
![]() |
#36 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
If I remember correctly the files from your archive didn't have underscores, they had spaces. I might be wrong though but I actually think the path might be too long.
Ahh dang, I must have missed the command line when I tried different methods and just hit undo in my text editor instead of editing the lines. I don't think the arguments need to be quoted but I agree with adding quotes to the path. |
![]() |
![]() |
#37 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
The arguments indeed don't need to be quoted alas I said about replacing the string adding the Quote from the start up to Type
![]() |
![]() |
![]() |
#38 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Oops I have misread that. Happens when you think about one problem and start reading the next one.
![]() Edit: File removed. Last edited by EctoOne; 07 June 2023 at 14:57. |
![]() |
![]() |
#39 |
Paranoid Amigoid
Join Date: Mar 2008
Location: Athens/Greece
Age: 45
Posts: 1,978
![]() |
I think we're all set my friend.
Just checked the SaveArchive and SavePos scripts and run flawlessly! LOTSA KUDOS! I also wanted to check running a stock 3.2.2.1 environment I set in UAE to check dependencies but the experience wasn't as pleasant cause it always failed to backup. After checking the script and what it does, I realized that everything was extracted correctly so I tried troubleshooting every one of the external commands until I got to rt_ReqDevice which wasn't running for no apparent reason :S After running SnoopDOS to see what's going on... it showed that it required the ReqTools.library which isn't present in a stock 3.2.2.1 installation. After getting and extracting the library from Aminet (http://aminet.net/package/util/libs/ReqToolsLib) all went smoothly. I suggest to include this in the sources as well mate. Apart from that, everything (including restoring from backups was checked (for both SaveArchive, SavePos) and works as intended! Great job man! \o/ |
![]() |
![]() |
#40 |
Registered User
Join Date: Jun 2020
Location: Germany
Posts: 382
|
Eww for real, it does require reqtools? That sucks. I'm not too sure if I want to add a whole library. Especially one that can be configured.
Did you copy it to Libs: or the IconSaver directory? In case it needs to be in Libs: I could still have it somewhere in the IconSaver directory an make a temporary assign. Hmpf, I'll look into it but I'm not happy about that. Thanks for testing everything though. |
![]() |
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | |
Thread Tools | |
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
How can I save window positions and sizes in Workbench? | Foebane | support.Apps | 6 | 10 April 2017 15:09 |
ClassicWB Desktop icon | danko | project.ClassicWB | 3 | 09 May 2016 13:05 |
Saving icon positions, WB3.0 | EmuChicken | support.Apps | 11 | 02 October 2006 17:30 |
Utility that removes icon text box | Bloodwych | request.Apps | 4 | 12 June 2004 13:10 |
Icon utility | oldpx | request.Apps | 17 | 27 September 2002 23:22 |
|
|