Open-source dos.library

[mfilos]

Hi DonAdan,

I recently discovered errors using floppy disks under WinUAE (although I believe it must happen on real Amiga but haven't tested yet) using your module.

After having to install some multi floppy applications (like for example DPaintV) I realized that on change of disk I was getting errors in the installation.
At first I thought that was a bad script, but I saw that on other applications as well so I changed the ROM to another custom I have (but without any of your modules) and I didn't have a single issue!
So... I assumed at first that maybe the newer modules of yours (like disk.resource) might have been problematic so I tried making MANY ROMS replacing one-by-one your modules with the original ones until I found out that the problem exists with the dos.library only!

Here's is what I see once the installation script asks for disk2 of the DPaintV installation




...and once I replace disk1 with the disk2 this is the error I get




I replaced your own dos.library with the normal 42.1 library and I don't have a single issue.
Just thought to report that for you to check it out

[Don_Adan]

OK. You are very good betatester, I will return to this project and fix this problem soon, I hope.

[Minuous]

>I recently discovered errors using floppy disks under WinUAE (although I believe it must happen on real Amiga but haven't tested yet) using your module.

All these different versions of dos.library seem to be using the same version number (41.0) for some reason. Eg. V41.0 from BB4 is different from the latest version but both are called V41.0.

Does this occur with the V41.0 in BB4? If so, it will need to be removed from future versions of BB4.

[mfilos]

It's true that all version of Don Adan's modules use the same version numbering, so I always download the latest from his site to be sure (according to his announcement on EAB).
Even the latest v41.0 had issues with ToolsDaemon that were fixed using the resourced v42.1 that is now on his website.
Despite not having a single issue with v42.1 of his, I discovered that the only thing so far that It's weird concerns using of floppy as the examples I posted above.

Imho, since stability is that most important part in BoingBags, better use the original kickstart image until Don Adan finds the issue and we can all test his versions and report back for future BB4's update.

[Minuous]

@Don_Adan:

The Version command reports 42.1 as 40.3. I think you probably need to add a $VER: to the start of your version string.

[Don_Adan]

Originally Posted by Minuous

@Don_Adan:

The Version command reports 42.1 as 40.3. I think you probably need to add a $VER: to the start of your version string.

No, you must see 42.1, if you see 40.3, then 42.1 is not loaded on your config.

[emufan]

Don: did you missed a "$VER:" in your lib, before the version number?

dos42128693.MSG	dc.b	'dos 42.1 (19.7.2013)',$D,$A,0

the icon.library (peter_k) looks like this:

LibName             DC.B           "icon.library",0
                    DC.B           "$VER:"
LibId               DC.B           "icon.library 46.4.330 "

IIRC version command looks for the $VER string?

[Don_Adan]

Originally Posted by emufan

Don: did you missed a "$VER:" in your lib, before the version number?

dos42128693.MSG    dc.b    'dos 42.1 (19.7.2013)',$D,$A,0

the icon.library (peter_k) looks like this:

LibName             DC.B           "icon.library",0
                    DC.B           "$VER:"
LibId               DC.B           "icon.library 46.4.330 "

IIRC version command looks for the $VER string?

"$VER:" is unused for ROM modules.
For dos.library and other ROM modules, version is taken from module structure (14 byte), revision is taken from module base (word at $16 offset).

[emufan]

Originally Posted by Don_Adan

"$VER:" is unused for ROM modules.
For dos.library and other ROM modules, version is taken from module structure (14 byte), revision is taken from module base (word at $16 offset).

I was pretty sure, i were wrong somehow. I step back in shame

[Minuous]

It doesn't matter whether it's loaded or not. Try eg.

Version sys:libs/dos.library full

Only difference with having it loaded is that the date is shown, version is wrong in both cases.

I don't know why you would want an obsolete version number embedded in the executable (even if it was ignored by Version, which it isn't).

[Don_Adan]

Originally Posted by Minuous

It doesn't matter whether it's loaded or not. Try eg.

Version sys:libs/dos.library full

Only difference with having it loaded is that the date is shown, version is wrong in both cases.

I don't know why you would want an obsolete version number embedded in the executable (even if it was ignored by Version, which it isn't).

But you know that you are wrong?
You can't check version of module in this way, if this module is already loaded.
Rename "dos.library" for "mydos.library", later type:
Version sys:libs/mydos.library full
and check effects.
Similar like Roadshow can used roadshow.library for name for bsdsocket.library.

[Minuous]

So in some circumstances it will return the correct version number. Still better if it would return the correct version number in all circumstances.

For dos.library and other ROM modules, version is taken from module structure (14 byte), revision is taken from module base (word at $16 offset).

So why do you have incorrect inconsistent data in that structure?

[Don_Adan]

Originally Posted by Minuous

So in some circumstances it will return the correct version number. Still better if it would return the correct version number in all circumstances.



So why do you have incorrect inconsistent data in that structure?

Data are set correctly. If you want to check version/revision for file version of ROM module, you must at first load this ROM module via LoadModule or create custom ROM. Or you must understand how works Amiga OS's Version command.

[cgugl]

there are news about the bug found by mfilos?
Dos.library 42.1 is sufficiently reliable to use in my a4000?

[Don_Adan]

Originally Posted by cgugl

there are news about the bug found by mfilos?
Dos.library 42.1 is sufficiently reliable to use in my a4000?

Due some other projects are finished I will fix this bug soon.

[voxel]

^^)

[tom256]

Originally Posted by mfilos

Hi DonAdan,

I recently discovered errors using floppy disks under WinUAE (although I believe it must happen on real Amiga but haven't tested yet) using your module.

After having to install some multi floppy applications (like for example DPaintV) I realized that on change of disk I was getting errors in the installation.
At first I thought that was a bad script, but I saw that on other applications as well so I changed the ROM to another custom I have (but without any of your modules) and I didn't have a single issue!
So... I assumed at first that maybe the newer modules of yours (like disk.resource) might have been problematic so I tried making MANY ROMS replacing one-by-one your modules with the original ones until I found out that the problem exists with the dos.library only!

Here's is what I see once the installation script asks for disk2 of the DPaintV installation




...and once I replace disk1 with the disk2 this is the error I get




I replaced your own dos.library with the normal 42.1 library and I don't have a single issue.
Just thought to report that for you to check it out

I tried with dos.library from Don_Adan and A4000. I was instaling DPaint IV 4.5. No problem found. Installation was successful. Maybe one of Your patches doesn't like new dos.library???

[Don_Adan]

Mfilos, could you send to me your version of DPaint or give direct link, I will check if it works on my Amiga 4000.

BTW. I made ReadPCR routine (available on Test subpage) for 68060. Then 68060 users can give me output (PCR.bin from RAM) or put result (4 bytes value) in this thread. Thanks.

http://www.ppa.pl/forum/amiga/29981/68060-pcr

[Don_Adan]

Programs for test dos.library (v40.3/v41.0/v42.1):

[Don_Adan]

Time to back to dos.library.
Fixed versions of dos 41.0 and 42.1 are available.
Perhaps all known my bugs are fixed, then tell me if you found any bug(s).
Next version (v42.2) will be based on dos 41.0 with extensions/changes from
dos 42.1. Due it will be easiest for me and fastest to finish (dos 41.0 is
in ~90% reworked/optimised).

Dos 42.1 except compiling with better C compiler has updated next routines:

ReadArgs
SetVBuf
VFWritef (Action_T)

; Resourced version of dos library (42.1) for Amiga68k ROM 1.0
; For easy recognition all changes are done using lower cases and ";" signs
; Original code is removed with ";" signs
; New code is added using lower cases only, old/tested code is removed later
; From now some parts are moved for better/easy handling

; Originally written by:

; jesup (Randell Jesup)
; steveb (Steve Beats?)
; cdh
; kodiak (Bob Burns)
; andy (Andy Finkel)
; TJK
; Martin Richards
; krs (Ken Salomon)

; We made it...
; OS Group: Bryce Nesbitt, Michael Sinz, Peter Cherna, Darren Greenwald, Randell Jesup, Jerry Horanoff
; GFX: Allan Havemose, Barry 'Bart' Whitebook, Spence Shanson, Steve Beats, Chris Green, Ray Brand, Jim Barkley
; Special Projects: Eric Cotton, Martin Hunt, Bill Koester, Martin Taillefer, Brian Jackson, Kaori Kuwata, David Junod, Palmyra Pawlik, Kevin Klop
; NET: Brian Jackson, Greg Miller, Kenneth Dyke
; GUI: Peter Cherna, Martin Taillefer, David Junod, Kaori Kuwata
; Others: Andy Finkel, Dale 'Duck' Luck, Jim 'Jimm' Mackraz, Bob 'Kodiak' Burns, Jeff Porter, Carolyn Scheppner, David Haynie,
; Lauren Brown, CATS (Commodore Amiga Technical Support), QA (Quality Assurance), SA (Software Assurance)
; Thanks to: Bill Hawes, Software Distillery (Dave Baker, Ed Burnette, Stan Chow,
; Alan Beale, Bruce Drake, Andy Mercier, Mary Ellen Toebes, Jim Cooper, Mike Witcher,
; Jay Denebeim, John Mainwaring, Gordon Keener, Jack Rouse, John Toebes, Doug Walker)
; Better than ever.