Compileable version of Alien Breed 3D II - The Killing Grounds

[abu_the_monkey]

@grond

I don't know, I will check this when I get home this evening.

[Karlos]

I think I have a lead. There's bit of code that modifies an undefined offset in the entity structure separately for player 1 and player 2.

[abu_the_monkey]

Sounds promising

[Karlos]

Originally Posted by abu_the_monkey

Sounds promising

It's a stretch, but we'll see. If it turns out to be the cause it's going to need a big WTF comment...

[Karlos]

Originally Posted by Karlos

It's a stretch, but we'll see. If it turns out to be the cause it's going to need a big WTF comment...

Actually that particular difference I did already handle, but I've found a small number of others, too.

[abu_the_monkey]

Originally Posted by grond

If you do the same thing with one of the weapons that have the projectile travel across the room before hitting the wall, does the glitch occur when you fire or when the shot hits the wall?

just checked and it happens the moment you press fire with the projectile weapons.

[Angus]

Originally Posted by abu_the_monkey

just checked and it happens the moment you press fire with the projectile weapons.

"It's an instantaneous shot...... but it's the only lead we've got." :-)

[Karlos]

I've reintroduced a number of small divergences, one of which may have been responsible. The code in Plr1_Shot and Plr2_Shot contained a number of small, differences that I'd overlooked. In that code, "player 2" is always the remote player and not specifically master or slave. There was a bit of code that checks if it the player is the slave player and had opposite branching semantics for player 1 and 2.

I've implemented that at the smallest scope so that I didn't just end up splitting all the code back out into two completely separate paths.

Hopefully it fixes the issue.

[abu_the_monkey]

that sounds logical, hopefully it has the desired affect

[Karlos]

Hasn't broken single player so far.

[abu_the_monkey]

@Karlos

I just ran a quick test with the latest push and the map no longer has the issue (from very limited testing ie. start level A, fire off a few shots as player 2 with the map enabled on both players).

However the weapon animations no longer run for either player

I will test more thoroughly later.

[Karlos]

Whackamole...

[Karlos]

Originally Posted by abu_the_monkey

@Karlos

I just ran a quick test with the latest push and the map no longer has the issue (from very limited testing ie. start level A, fire off a few shots as player 2 with the map enabled on both players).

However the weapon animations no longer run for either player

I will test more thoroughly later.

I think this will be an animation counter thing, I bet.

[abu_the_monkey]

when you select the rocket launcher, its animation of the sight popping out does run which is odd.

[abu_the_monkey]

I think I may have found another bug.
Entering the water at the start of level F in your mod seems crash the game for me.
I will have to test this in other levels to be sure it is not just my installation of the mod.

[Karlos]

Originally Posted by abu_the_monkey

I think I may have found another bug.
Entering the water at the start of level F in your mod seems crash the game for me.
I will have to test this in other levels to be sure it is not just my installation of the mod.

That doesn't happen for me.

[abu_the_monkey]

seems to be my install. it only happens at the first water pool in level F of your mod, the second one after the teleport at the bottom of the big lift is fine. all other shallow water pools I could think of to check are fine also.

I will update my install later

edit: downloaded the latest version form git and all is fine now, panic over

[Karlos]

I'm not going to get time to dig into it, but there's a bit of code where the structure offset EntT_Timer1_w is used differently for player 1 and player 2. One adds 128 to the offset, the other adds 64. This is the place I originally spoke of, that I said I'd handled. It's possible that the handling code was wrong and worked only because of side effects of the defects that have just been fixed. I can't remember exactly where it is in the code now, but a quick grep or use of your preferred IDE's find in files should do it.

I think that handling code may already be merged in the first round of refactoring so it's not necessarily in this PR.

Here is a reference in the current PR, but I believe this one is correct: https://github.com/0xABADCAFE/alienb...player.s#L1171

If you can find it, feel free to experiment!

[abu_the_monkey]

I will have a peek tomorrow when my eyes are not so tired

probably still just go round in circles, but at least it will not hurt my brain (as much)

[Karlos]

Originally Posted by abu_the_monkey

I will have a peek tomorrow when my eyes are not so tired

probably still just go round in circles, but at least it will not hurt my brain (as much)

I'll take a quick look before bed...