English Amiga Board - req. Romance of Three Kingdoms II

English Amiga Board (https://eab.abime.net/index.php)

- support.Games (https://eab.abime.net/forumdisplay.php?f=6)

- - req. Romance of Three Kingdoms II (https://eab.abime.net/showthread.php?t=19831)

Quote:

Originally Posted by Retro-Nerd (Post 934855)

I've talked to cebulba. ... Maybe an ADF dump too, if it has manual protection only. We will see. :)

adf dump will be good, HOL says, it has hd-install, so this will be fine, i think.
he should try to create an extended adf - like dlfrsilver is doing all the time - so we can share this dump and are not restricted by CrAPS guidelines.

Quote:

Originally Posted by emufan (Post 934772)

very cool. the crash is gone - "Build Fort" responses now with "not enough gold ..." - no more crash :great
no further testing done, but you can call yourself eab h3x05 - hope you dont mind :D

Thanks! I tested the "Build Fort" entry via cheat, you need roughly 5000 gold to afford a fort. The game lets you pick a general and place it on the war map.

Thanks. It's a pretty interesting game with interesting graphics design. This series of games are probably the only Amiga games ever made in Japan, and the whole of East Asia. At least I've never seen any other Amiga games from there, so they stand out in this way, too.

thanks, modrobert - works very well so far. i tested a couple of hours and everything seems alright. will let you know if some issue arises.

btw, maybe we should document the bugfix here, so other ppl using the bad floppies can fix it with a hexeditor (just in case the fixed files disappear from the web again). iirc the problem was that the value 0x16 is written into the d0 register instead of 0x15, right ? what's the exact byte sequence one has to look for ?

On the first disk 'ROMIIA' the file to patch is: data_a/rom2

Look for:

Code:

BF EC 5F 3C 65 00 05 38 70 00

...and replace it with:

Code:

70 16 BE 80 66 04 70 15 60 04

For those who are interested, here's the assembly with some comments.

Original (with "Build Fort" bug):

Code:

        cmpa.l $5F3C(a4),a7

        bcs $80CB16A ;this will never happen, c compiler bloat?

        moveq #0,d0



        move.b $B(a5),d0 ;d0 will be #$16 when bug occurs after selecting "build fort"

        asl.l #2,d0 ;now d0 is #$58 with bug

        lea -$17B4(a4),a0 ;get jump table offset start

        movea.l 0(a0,d0.l),a0 ;bad a0 now points to string data instead of correct jump vector (which is -4)

        jsr (a0) ;the instruction causing "address error" when a0 points to memory with odd address

        unlk a5 ;a lot of this shit going on in almost every subroutine, C or Pascal?

        rts

Patched:

Code:

        moveq #$16,d0 ;bug command for "build fort"

        cmp.l d0,d7 ;check if "bad fort", register d7 includes current menu command from previous check

        bne.s foo1 ;if other command, lets skip this

        moveq #$15,d0 ;d0 was bad #$16, lets move #$15 there instead

        bra.s foo2

;end patch, byte count match



foo1    move.b $B(a5),d0

foo2    asl.l #2,d0 ;after patch, d0 will be #$54 when "build fort" was selected

        lea -$17B4(a4),a0 ;get jump table offset start

        movea.l 0(a0,d0.l),a0 ;a0 now points to the correct jump vector for "build fort"

        jsr (a0)

        unlk a5

        rts

I debugged this on my A1200 (see sig) using MonAm (the debugger for Devpac 3), since it lacks direct assembly the opcodes were entered manually using the "hex edit" window. ;)

that's really cool. thanks!

Quote:

Originally Posted by rofl0r (Post 935178)

that's really cool. thanks!

i second this, thanks again, modrobert :great

Hi does anyone know where to find this patched file?

I have access to an original dump of ROTK II

Would you please share?

yes but not yet, i'm at work.

Quote:

Originally Posted by jedvard (Post 1269485)

Hi does anyone know where to find this patched file?

Have a look on the EAB File Server, 3rd file listed: click ;)

Thanx alot in advance!

Quote:

Originally Posted by DamienD (Post 1269536)

Have a look on the EAB File Server, 3rd file listed: click ;)

Thanx alot but unfortunately they have the bug that makes the game crash when building forts :help

That's a shame, but should be easy to fix using modrobert's instructions:

Quote:

Originally Posted by modrobert (Post 935121)

On the first disk 'ROMIIA' the file to patch is: data_a/rom2

Look for:

Code:

BF EC 5F 3C 65 00 05 38 70 00

...and replace it with:

Code:

70 16 BE 80 66 04 70 15 60 04

...give me a few minutes.

Silly me; it's "Disk 1" that needs patching :blased

Take a look in The Zone!, I've put an archive named "Romance of the Three Kingdoms II (1991)(KOEI)[f AGA BSC][f Build Fort modrobert][h Aeon].zip" which contains:

... Romance of the Three Kingdoms II (1991)(KOEI)(Disk 1 of 2)[f AGA BSC][f Build Fort modrobert][h Aeon].adf
... Romance of the Three Kingdoms II (1991)(KOEI)(Disk 2 of 2)[f AGA BSC][h Aeon].adf

Please test and report back.

Vow really amazing thanx for helping me :) im at work now but cant wait to get home tonight and try the files...and report. Again Thanx!

Quote:

Originally Posted by dlfrsilver (Post 1269531)

yes but not yet, i'm at work.

Thanx and i really looking forward to compare your files to the files that damienD posted :great

Please check the zone :)

Quote:

Originally Posted by dlfrsilver (Post 1269600)

Please check the zone :)

You wouldn't happened to have an original of the first one too?