English Amiga Board


Go Back   English Amiga Board > News

 
 
Thread Tools
Old 08 August 2012, 15:57   #21
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Quote:
You never said it only crashes when running under 1.3, only that pfs3 for ks1.3 crashes in some not-that-specific media change situations.
I never test the 1.3 version on 3.1... will do it!
The official PFS3 unmount correctly on 3.1.
Gilloo is offline  
AdSense AdSense  
Old 14 August 2012, 22:53   #22
FastRobPlus
Registered User
 
Join Date: May 2007
Location: Seattle,WA
Posts: 57
Quote:
Originally Posted by Gilloo View Post
The main risk is to lose your data, and give me a trial. But I'm not of the kind to fatten the judges and lawyers. So you are warned



Thanks - this is good info. I may try a thumbdrive just to see how it works.
FastRobPlus is offline  
Old 03 September 2012, 12:49   #23
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Quote:
Originally Posted by Gilloo View Post
I never test the 1.3 version on 3.1... will do it!
The official PFS3 unmount correctly on 3.1.
Verdict:
PFS13 on 3.1 does the same thing as 1.3 when unmount, but guru #8 (guru #3 on 1.3)
Gilloo is offline  
Old 03 September 2012, 21:04   #24
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
Does attached version work better?

I noticed that removable support wasn't fully enabled (TRACKDISK define) which can explain disk change problems.

WARNING: This is test version only. Do not upload anywhere else!

Last edited by Toni Wilen; 18 September 2012 at 17:48.
Toni Wilen is offline  
Old 10 September 2012, 10:47   #25
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Quote:
Originally Posted by Toni Wilen View Post
Does attached version work better?

I noticed that removable support wasn't fully enabled (TRACKDISK define) which can explain disk change problems.

WARNING: This is test version only. Do not upload anywhere else!
Toni, I've test this version 03-Sep-2012, and it makes guru #8 when unmounting in both cases... (wb3.1 and wb1.3) (Sorry to announce bad news)
Gilloo is offline  
Old 10 September 2012, 11:29   #26
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
Quote:
Originally Posted by Gilloo View Post
Toni, I've test this version 03-Sep-2012, and it makes guru #8 when unmounting in both cases... (wb3.1 and wb1.3) (Sorry to announce bad news)
Works for me. Explain your test case _exactly_. Not just "I remove disk and it crashes".

EDIT: My test case:

Mount PFS3 floppy device (using similar mountlist used for RAD, except device and handler changed)
Format it.
Eject and insert and check that everything works. Including disk getting reported as removed, not non-dos after removal.

Previously media changes didn't work at all and it also randomly crashed after eject.
Toni Wilen is offline  
Old 11 September 2012, 10:41   #27
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Quote:
Originally Posted by Toni Wilen View Post
Works for me. Explain your test case _exactly_. Not just "I remove disk and it crashes".

EDIT: My test case:

Mount PFS3 floppy device (using similar mountlist used for RAD, except device and handler changed)
Format it.
Eject and insert and check that everything works. Including disk getting reported as removed, not non-dos after removal.

Previously media changes didn't work at all and it also randomly crashed after eject.
aah, kiitos
mount uh2:
open the uh2: icon... display image or open a text file, close the application.
unmount uh2: then guru #8

http://aminet.net/package/disk/misc/unmount-0.1
Given there is the source code, I've done the equivalent unmount for 1.3 (which works with fat95, when fat95 is decided to work )
Gilloo is offline  
Old 11 September 2012, 16:34   #28
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
So it is ACTION_DIE problem after all. Nothing to do with removing removable media..
Toni Wilen is offline  
Old 13 September 2012, 15:47   #29
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Quote:
Originally Posted by Toni Wilen View Post
So it is ACTION_DIE problem after all. Nothing to do with removing removable media..
Is it possible to got ACTION_DIE packet with pfs3_ks13 ? kiitos
Gilloo is offline  
Old 15 September 2012, 18:39   #30
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
Aminet unmount_m68k is broken, first instruction in executable is illegal instruction.
Toni Wilen is offline  
Old 17 September 2012, 11:09   #31
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Quote:
Originally Posted by Toni Wilen View Post
Aminet unmount_m68k is broken, first instruction in executable is illegal instruction.
It seems to be compiled for other thing than pure 68000...
Toni, you can use the ANAIIS unmount (seek it in bin of the following package)
http://aminet.net/package/driver/other/anaiis
Good luck
Gilloo is offline  
Old 18 September 2012, 20:37   #32
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
pfs3 unmount is now working but there is still one problem remaining: under 1.3, mounting again after unmount crashes with memory list corruption guru.

More debugging to do..

Attach source of your version of unmount, thanks.
Toni Wilen is offline  
Old 19 September 2012, 17:29   #33
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Hi Toni,
here's my unmount code with the makefile... for SASC 6.0 and up
Perhaps it's buggy. Please tell me if you find monsters

unmountc.c is the shell command source code,
unmount.c is the code to unmount function for 1.3 and for 2.04 and up.
Attached Files
File Type: c unmount.c (10.7 KB, 76 views)
File Type: c unmountc.c (1.1 KB, 63 views)
File Type: txt makefile.txt (442 Bytes, 58 views)
Gilloo is offline  
Old 19 September 2012, 18:00   #34
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
I think calling c:assign is too ugly solution..

assign dismount: internally calls RemDosEntry() which is as simple as:
Code:
    dl = DeviceNode head
    while(dl->dol_Next)
    {
        struct DosList *dl2 = BADDR(dl->dol_Next);
        if(dl2 == dlist)
	{
	    dl->dol_Next = dlist->dol_Next;
	    break;
	}
	dl = dl2;
    }
(Forbid state required of course)

You should first find the correct device node and then exit the loop because doslist may have changed and "DeviceNode = (struct DeviceNode *)BADDR(DeviceNode->dn_Next) ;" may access random memory.

It is not safe to scan doslist without forbid state. (and forbid in this code would be broken anyway during packet calls)

But I don't think this is the cause for crash.
Toni Wilen is offline  
Old 19 September 2012, 18:26   #35
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
So I can remove the Execute call to "assign dismount" (I don't think it is working with 1.3) and "assign remove" then.
Gilloo is offline  
Old 19 September 2012, 18:28   #36
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
Quote:
Originally Posted by Gilloo View Post
So I can remove the Execute call to "assign dismount" (I don't think it is working with 1.3) and "assign remove" then.
Yeah, just manually unlink the doslist entry and your done.
Toni Wilen is offline  
Old 19 September 2012, 20:56   #37
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
Ok, this one should really work.

EDIT: also includes all SVN updates since previous pfs3ks13 Aminet release.

Last edited by Toni Wilen; 27 September 2012 at 21:58.
Toni Wilen is offline  
Old 20 September 2012, 10:30   #38
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
Kiitos Toni, I will try this weekend

I don't know why I wrote a Delay(10) before RemDosEntry... it seems to be superfluous...
Attached Files
File Type: c unmount.c (10.0 KB, 77 views)
Gilloo is offline  
Old 21 September 2012, 10:56   #39
Gilloo
Registered User
 
Join Date: Nov 2010
Location: Grenoble, Isère, Rhône-Alpes, France, Europe, Earth
Posts: 159
hum... tested the new pfs_ks13

wb1.3: it freezes after unmount... (but no guru :-) )
wb3.1: guru #8

wb3.1, original PFS3 from the PFS3, guru #8 after unmount

Perhaps its my unmount in cause... so I broke the version
if (1 /*DOSBase->lib_Version < 37*/)
to activate always the 1.3 compatible code, but it is the same with pfs_ks13 and wb3.1/original PFS3 unmount correctly

Toni, do you also got the freeze in 1.3?

Last edited by Gilloo; 21 September 2012 at 12:33.
Gilloo is offline  
Old 21 September 2012, 11:38   #40
Toni Wilen
WinUAE developer
 
Join Date: Aug 2001
Location: Hämeenlinna/Finland
Age: 42
Posts: 19,924
Works perfectly here, including 1.3, using your unmount. You sure you use correct pfs3 version?

EDIT: Run mungwall, must be wrong version if you get huge amount of memory allocation errors when unmounting. (You can use -log -serlog winuae command line parameters to see serial debugging without extra utilities)

Last edited by Toni Wilen; 21 September 2012 at 11:45.
Toni Wilen is offline  
AdSense AdSense  
 


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
ANAIIS 1.09 (30 Sep 2013) Gilloo News 22 30 April 2014 16:38
Flashback 2012 Demoscene computer party 9th - 10th & 11th June 2012 - C64 - AMIGA - P reload News 0 24 April 2012 18:01
ANAIIS 1.03 - Poppy fixes. Gilloo News 15 17 April 2012 10:56
ANAIIS 1.02 - Summer fixes Gilloo News 7 05 January 2012 01:04
FAT95 (and ANAIIS) Gilloo support.Hardware 0 19 September 2011 15:53

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 04:33.


Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.
Page generated in 0.27860 seconds with 12 queries