English Amiga Board


Go Back   English Amiga Board > Coders > Coders. System

 
 
Thread Tools
Old 23 September 2014, 17:21   #1121
daxb
Registered User
 
Join Date: Oct 2009
Location: Germany
Posts: 2,094
Quote:
Originally Posted by Michael View Post
The logic in your code is faulty.
Yes, deleting the envarc variable makes the script start, but only first time until a reboot and you have to delete the variable again.
I`ve changed to not delete the envvar (not necessary). Now you should not have problems with starting the script.

Quote:
Secondly why check for an icon if the directory does not exist in the first place?
There is no check for an icon of a not existing directory.

Quote:
And now even more fun. After successful run of your script for the first time,
go and kill the drawer icon for ken_icons pack in ram. And rerun the script.
Failure, no warning that icon is missing (in DOPUS mode).
Nobody should do this but now there is a check now for this action.

Quote:
And hence when we copy the files to a temp ram folder, it's better to check for the icon, and if it's missing, add one. Then it will run nice and smooth.
There won`t be autmatically icon add. I`ve explained because why.

Last edited by daxb; 03 October 2014 at 17:11.
daxb is offline  
Old 24 September 2014, 19:16   #1122
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
@Michael
This is the wrong place for feature requests or bug reports concerning DOpus5.

Try this webpage, please:

http://sourceforge.net/p/dopus5allamigas/discussion/
PeterK is offline  
Old 29 September 2014, 21:02   #1123
Michael
A1260T/PPC/BV/SCSI/NET

Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 648
@daxb

Well, finally got to test it.
Works out of the box this time ;-)

Shame that it complains for missing drawer icon, now even under WB.

One more crazy idea! Option to select and unpack an icon pack to ram: for testing.?

Anyway I am more or less happy...
Michael is offline  
Old 30 September 2014, 05:22   #1124
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
Update to icon.library 46.4.388:

A final attempt to optimize the direct drawing a little bit, but no guarantee that it really does. I can't find it out with WinUAE and thus I need your benchmark results.
PeterK is offline  
Old 30 September 2014, 18:50   #1125
Michael
A1260T/PPC/BV/SCSI/NET

Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 648
Quote:
Originally Posted by PeterK View Post
Update to icon.library 46.4.388:

A final attempt to optimize the direct drawing a little bit, but no guarantee that it really does. I can't find it out with WinUAE and thus I need your benchmark results.
Sorry to disappoint you, same results as 385/386 for 388 - average 1.48 & 10.84 secs
Michael is offline  
Old 30 September 2014, 19:06   #1126
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
Anyhow, thanks for your results, Michael.
Maybe, somebody else has more luck, pawelek seems to be the next who may report.
PeterK is offline  
Old 01 October 2014, 00:37   #1127
pawelek
Registered User

 
Join Date: Aug 2014
Location: Poland
Posts: 39
(Blizz1260/64mhz, Radeon, exec.library 45.25.26):
Ken's Icons v4 PNG icon collection
----------------------------
icon.library 46.4.386
Total: 48.44
Average: 9.68
----------------------------
icon.library 46.4.388
Total: 48.40
Average: 9.68
----------------------------
icon.library 46.4.390
Total: 48.42
Average: 9.68


CrystalIcons icon collection:

----------------------------
icon.library 46.4.386
Total: 10.74
Average: 0.976
----------------------------
icon.library 46.4.388
Total: 10.62
Average: 0.965

Last edited by pawelek; 06 October 2014 at 02:19.
pawelek is offline  
Old 01 October 2014, 22:58   #1128
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
Thank you, pawelek !

Up to now, your Crystal icon set results are the only ones showing a small speed improvement. Of course, the affect of a faster direct drawing is about five to ten times smaller for PNG and OS4 icons, because most of the time is consumed by the zlib decoding and the color reduction.

Getting some feedback from other users with a different system hardware would be nice.
Please compare 385 and 388 with OpenWin.rexx from daxb. THX
PeterK is offline  
Old 02 October 2014, 00:54   #1129
Retrofan
Ruler of the Universe

Retrofan's Avatar
 
Join Date: Mar 2010
Location: Lanzarote/Spain
Posts: 5,998
I would like to make the comparison, but sadly my pcmcia CF needs to be changed, and it will take some time to get another CF for it, and also it's a pain in the ass to be changing the CF HD to the PC.

I hope the test results of OpenWin will be right now with the latest updates, as also sadly to me they looked random the last time I tried it (time ago).
Retrofan is offline  
Old 03 October 2014, 17:12   #1130
daxb
Registered User
 
Join Date: Oct 2009
Location: Germany
Posts: 2,094
tomsmart1 and me have changed openwin once again. tomsmart1 as add an automatical test which runs it <n> times (see script config sektion) and with mit min-/max- and average overall output. OpenWin should be ready now so feedback of any kind is welcome.
@Retrofan:
If any problems please let me know.
Attached Files
File Type: lha OpenWin.lha (5.8 KB, 82 views)
daxb is offline  
Old 05 October 2014, 09:41   #1131
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
Update to icon.library 46.4.389:

The icon.library supports the delayed color mapping of the 2. icon image now also for DOpus5 and the WB 3.0/3.1 on 68020+ systems.
PeterK is offline  
Old 05 October 2014, 16:41   #1132
Retrofan
Ruler of the Universe

Retrofan's Avatar
 
Join Date: Mar 2010
Location: Lanzarote/Spain
Posts: 5,998
There is some problem using DOpus. The image of the selected icon disappears.
Retrofan is offline  
Old 05 October 2014, 17:58   #1133
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
Update to icon.library 46.4.390:

The icon.library supports the delayed color mapping of the 2. icon image now also for DOpus5 and the WB 3.0/3.1 on 68020+ systems.

Delayed color mapping for DOpus5 only on Hi/TrueColor screens, not on ECS/AGA.

(Hmm, I thought this update would make at least some DOpus5 or WB 3.1 users happy? Nothing!)

Last edited by PeterK; 06 October 2014 at 13:23.
PeterK is offline  
Old 06 October 2014, 17:30   #1134
Michael
A1260T/PPC/BV/SCSI/NET

Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 648
@PeterK

Count me in!
I could not comment without thorough testing!
The new DO colour usage reduction is nice, and seems to work.

For my test case when I open same drawers of icons DO reposts more free pens then before. And it also seems to be faster too! Excellent!

Now the problem! If we look at my SYS:Prefs/ with the older version of the lib I got 40 free pens left. With the 390 update I get 47 free, and when you start selecting icons new pens are allocated. Cool. But if all icons in Prefs are selected DO free pen colour count drops to 35. I wonder why more colours are allocated in the end for the same operation ?

The other sad thing I found about DO, is it has a pathological problem with freeing pens. Looking at the source, there are around 20 points (commented with "FREE PEN") that call the same routines to free pens.
But apparently none of them actually free the pens in normal use.
eg. enter Enviroment prefs and exit them immediately.
For every entry you loose 1 pen, until you have no free pens available.
And when that happens, the pallet requester fails to update the colours :-(
The only cure so far is to refresh the whole screen (change mode or screen font) in other words, via IPrefs, then all the pens are freed again.
I guess this can be sorted out only in dopus, if someone figures out why it's not working as it should.
Michael is offline  
Old 06 October 2014, 17:33   #1135
Michael
A1260T/PPC/BV/SCSI/NET

Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 648
Quote:
Originally Posted by daxb View Post
tomsmart1 and me have changed openwin once again. tomsmart1 as add an automatical test which runs it <n> times (see script config sektion) and with mit min-/max- and average overall output. OpenWin should be ready now so feedback of any kind is welcome.
@Retrofan:
If any problems please let me know.
Nice update, but imho it would make sense to ask the user to add an icon to the drawer.
re: No icon available for drawer xxx.
Add default icon and begin test ?

Then you can just copy envarc:sys/def_drawer.info to the drawer with icons to test.

Since doing the same by hand will not make any difference, but this way it would be more user friendly and less hassle.
Michael is offline  
Old 06 October 2014, 19:50   #1136
Michael
A1260T/PPC/BV/SCSI/NET

Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 648
My feeling regarding speed improvements were right!

DO 16bit CGX
v388 - Kens - 16.244s
v390 - Kens - 14.420s

v388 - Crystal - 7.210s
v390 - Crystal - 5.440s

v388 free pen count after tests 23
v390 free pen count after tests 21

Icons were not selected!
Actually selecting all icons does not eat any more pens, I guess there were enough already plus 2 more then before!

PS: One more thing, when DO and WB are running together, with v390 lib you get a small penalty for WB tests, +0.60s (eg. Crystal 1.50s v 2.10s)
But I guess it's a small price to pay and DO improvement was worth every bit of code. (No performance drops if WB is running alone)

Last edited by Michael; 06 October 2014 at 20:04.
Michael is offline  
Old 06 October 2014, 19:51   #1137
Retrofan
Ruler of the Universe

Retrofan's Avatar
 
Join Date: Mar 2010
Location: Lanzarote/Spain
Posts: 5,998
PeterK is there any problem in deleting the old icons (Edit sorry I mean Old image) from each Ken's icon in the remapped version I am making?

Edit: I will leave just the ones of the volumes, as it is the image they use when you format them.
And I've seen there is no problem deleting them; a point appears later inside and I save around 300 bytes deleting the bigger old images.

Last edited by Retrofan; 06 October 2014 at 21:00.
Retrofan is offline  
Old 06 October 2014, 21:05   #1138
PeterK
Registered User
 
Join Date: Apr 2005
Location: Hangover
Posts: 2,377
@Michael

That's a speed improvement as on my AmiKit installation.

Concerning the remaining free pens, the difference may be caused by my setting for the pen precision, which - I think - is "Best" atm for the delayed color mapping. I have to check whether it's possible to preserve the original choice until the icon is selected or not.

The problem with WB and DOpus5 running together is that atm I'm only checking whether DOpus5 is running at all and not which task is trying to do the color mapping. I guess, this could be improved in a way that the DOpus5 patch won't slow down the WB calls. Thanks for this hint.

@Retrofan

Should be posiible with ProcessIcon from Stephan Rupprecht to batch delete the planar images.
PeterK is offline  
Old 07 October 2014, 16:10   #1139
daxb
Registered User
 
Join Date: Oct 2009
Location: Germany
Posts: 2,094
Quote:
Originally Posted by Michael View Post
Nice update, but imho it would make sense to ask the user to add an icon to the drawer.
re: No icon available for drawer xxx.
Add default icon and begin test ?

Then you can just copy envarc:sys/def_drawer.info to the drawer with icons to test.

Since doing the same by hand will not make any difference, but this way it would be more user friendly and less hassle.
I understand what you mean and I`ve thought about it once again but you forgot the problem: If the script adds an icon the size of the window isn`t known or it is too small or it isn`t proper for the test. So in most cases the user has to change the window size and save it. Further, this must be done each time you launch the test on a drawer without icon. The better/easier solution is the user add an icon manually (only once), resize the window if necessary and save it. Do you see the difference? However, if you still really want it you just have to remove the icon check in GetDir() and change the icon check in IconsToRamAndSetAsDir().
daxb is offline  
Old 07 October 2014, 17:32   #1140
Michael
A1260T/PPC/BV/SCSI/NET

Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 648
@daxb:
For me the default icon is correct, since it is saved in the state that I like for most new drawers and it is always the same and repeatable. I have no idea what type of setting you think of as preferred for testing (minimal window size?). In that respect it would be ideal to have a special icon for adding from the OpenWin dir (or decode it from the script in UUE/BinHex fashion )
In that case we can level out everybodies tests to use the same window config.
Michael is offline  
 


Currently Active Users Viewing This Thread: 3 (1 members and 2 guests)
fatbob_gb
Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
ClassicWB Full and icon.library 46.4 Retroplay project.ClassicWB 8 05 August 2018 14:57
WB library conflict/versions Akira support.Apps 3 22 July 2010 19:47
PNG Icon to Color Icon Converter? Leandro Jardim request.Apps 1 24 May 2010 05:39
What's the latest version of icon.library for OS3.9? NovaCoder support.Apps 3 30 June 2009 16:43
Requesting icon.library v44+... nikvest request.Other 2 16 September 2007 02:58

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 15:42.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2018, vBulletin Solutions Inc.
Page generated in 0.08888 seconds with 13 queries