Very Basic Scripting. Confused.

[marduk_kurios]

Hi,

I've been lurking here for a while, it's a great board.

So I have this text editor which ignores a given filename as parameter if the file does not yet exist. So I wrote this simple wrapper:

.key file
.bra {
.ket }

if "{file}" eq ""
    skip blank
endif

if not exists {file}
    echo >{file}.control ""     ; create empty file for later comparison
    echo >{file} ""             ; create dummy file for editor to open
endif

genam3 {file}
skip check

lab blank
    genam3 

lab check
if exists {file}.control
    cmp {file} {file}.control      ; compare with empty file
    if not warn                    ; if it's the same, delete again (nothing was edited)
        delete {file}
    endif
    delete {file}.control          ; otherwise only delete control file
endif

This should work fine, however it does not delete the .control file and complains that there is an ENDIF missing. I stared on this too long, I don't know what's wrong. Can anyone help?

TIA.

[thomas]

It works correctly for me. Which version of AmigaDOS do you use?

Can you attach the original file? I used cut & paste from there, but maybe the original file contains some strange character which was removed by the web browser.

Note that your script will fail badly if the file name contains space characters.

[marduk_kurios]

I checked for strange characters but will provide the file anyway. I am on AmigaOS 1.3 (kickstart 34.5) This still gives the same error to me (endif missing).

The files do NOT contain identical datas.
ENDIF missing
if failed returncode 20

EDIT: Also, I am aware that it would break for filenames with spaces. Not planning to break it

[marduk_kurios]

Found the problem:

Apparently IF/ELSE/ENDIF statements must not be indented.

[thomas]

Originally Posted by marduk_kurios

Found the problem:

Apparently IF/ELSE/ENDIF statements must not be indented.

No, this is not true. Indention is allowed.

The problem is that the last line did not end with a newline character. If you had added an empty line to the end of the file it would have worked.

[marduk_kurios]

Oh?

Interesting. I did not realize that. I removed all indenting on a hunch, must have fixed that issue while doing so.