App for Creating Installer Scripts (InstallerGen)

[Daedalus]

Hi all,
Not sure if you've seen this already, but just thought I'd post it here too in case anyone was interested. I've released a beta version of InstallerGen, my utility for creating installer scripts using a fairly simple GUI, and thought some developers here might find it useful. You can download it here!

I'd be interested in any feedback you had, and also if anyone wanted to make an icon for the executable itself, I'd really appreciate that because I suck at making icons!

Thanks!

[Daedalus]

Full version now released on Aminet and on my website for anyone interested...

[gulliver]

Wow, I have waited for a very long time for a program like this.

Thank you!

[Daedalus]

@Gulliver

You're very welcome!

[daxb]

Just had a short test on A1200 OS3.1 MUI3.8. Some GUI bugs occur. Switches between different "Step Type" let the GUI refrehs several times (1 to 6 times). One refresh should be enough. Next is a "BYTE READ from 00000000" when open file requester from "File List" window (no problems with "Script Properties" filerequester). There might be more places. I haven`t checked.

[Daedalus]

@daxb

Thanks very much for the feedback. That byte read is a little worrying, I'll check it out! What software did you use that gave you that message?

As for the refresh thing, it's something that I'm aware of but haven't been able to solve yet. The problem is that it makes different gadgets visible or invisible depending on the step type, and I don't know how to disable refreshing while these properties are updated. Perhaps someone here might know if there's an MUI method for updating multiple objects without a refresh after each one?

[daxb]

MuForce catched the hits. Here they are:

04-Sep-14   21:26:18 
BYTE READ from 00000000                        PC: 00FF03FC
USP : 022FD476 SR: 0010  (U0)(-)(-)  TCB: 022ED438
Data: 0000000F 00000000 00000008 022FD4A8 00000000 01EE6910 FFFFFFFD 0000FFFF
Addr: 00000000 00000000 00000000 0232515D 00000000 022FD47C 010A7A4C 010826EC
Stck: 00FF02FC 000F01B5 2BA00000 0008022F D4A80000 000001EE 6910FFFF FFFD0000
Stck: FFFF022F D4C40232 515D0000 000000FF 05D0FFFF FFFE0250 819A0250 49D00000
Stck: 00000250 49E4024F 39F00000 0000024E 07BE0000 00200000 0276024D 57A00000
Stck: 00000000 00000000 00000000 00000000 00000000 00000000 0000024D 57A00000
Stck: 00000000 00000000 00000000 0000022E D4380000 0000024F 6548024D 57A600FE
Stck: C3260001 0000496E 7374616C 6C657247 656E0000 00000000 00000230 44880000
----> 00FF03FC - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 00004688
----> 00FF02FC - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 00004588
PC-8: 220C6100 DE5099CC 4A836606 24056000 FF182004 4E5D4CDF 1CFC4E75 20412248
PC *: 4A1866FC 91C12208 203C0000 00FFB280 6F022200 2E1F2801 53444681 D28F0241
00ff03dc :  220c                       move.l a4,d1
00ff03de :  6100 de50                  bsr $fee230
00ff03e2 :  99cc                       suba.l a4,a4
00ff03e4 :  4a83                       tst.l d3
00ff03e6 :  6606                       bne.s $ff03ee
00ff03e8 :  2405                       move.l d5,d2
00ff03ea :  6000 ff18                  bra $ff0304
00ff03ee :  2004                       move.l d4,d0
00ff03f0 :  4e5d                       unlk a5
00ff03f2 :  4cdf 1cfc                  movem.l (a7)+,d2-d7/a2-a4
00ff03f6 :  4e75                       rts
00ff03f8 :  2041                       movea.l d1,a0
00ff03fa :  2248                       movea.l a0,a1
00ff03fc : *4a18                       tst.b (a0)+
00ff03fe :  66fc                       bne.s $ff03fc
00ff0400 :  91c1                       suba.l d1,a0
00ff0402 :  2208                       move.l a0,d1
00ff0404 :  203c 0000 00ff             move.l #$ff,d0
00ff040a :  b280                       cmp.l d0,d1
00ff040c :  6f02                       ble.s $ff0410
00ff040e :  2200                       move.l d0,d1
00ff0410 :  2e1f                       move.l (a7)+,d7
00ff0412 :  2801                       move.l d1,d4
00ff0414 :  5344                       subq.w #$1,d4
00ff0416 :  4681                       not.l d1
00ff0418 :  d28f                       add.l a7,d1
00ff041a :  0241 fffc                  andi.w #-$4,d1
Name: "InstallerGen"  


04-Sep-14   21:26:18 
BYTE READ from 00000000                        PC: 00FF0426
USP : 022FD478 SR: 0014  (U0)(-)(-)  TCB: 022ED438
Data: 000000FF 022FD478 00000008 022FD4A8 00000000 01EE6910 FFFFFFFD 00FF02FC
----> 00FF02FC - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 00004588
Addr: 022FD479 00000000 022FD478 0232515D 00000000 022FD47C 010A7A4C 010826EC
Stck: 00FC000F 01B52BA0 00000008 022FD4A8 00000000 01EE6910 FFFFFFFD 0000FFFF
Stck: 022FD4C4 0232515D 00000000 00FF05D0 FFFFFFFE 0250819A 025049D0 00000000
Stck: 025049E4 024F39F0 00000000 024E07BE 00000020 00000276 024D57A0 00000000
Stck: 00000000 00000000 00000000 00000000 00000000 00000000 024D57A0 00000000
Stck: 00000000 00000000 00000000 022ED438 00000000 024F6548 024D57A6 00FEC326
Stck: 00010000 496E7374 616C6C65 7247656E 00000000 00000000 02304488 00002F30
----> 00FF0426 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 000046B2
----> 00FC000F - "ROM - intuition 40.85 (5.5.93)"  Hunk 0000 Offset 00017F37
----> 00FF05D0 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 0000485C
----> 0250819A - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 000329FA
----> 025049D0 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 0002F230
----> 025049E4 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 0002F244
----> 024F39F0 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 0001E250
----> 024E07BE - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 0000B01E
----> 024D57A0 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 00000000
----> 024D57A0 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 00000000
----> 024F6548 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 00020DA8
----> 024D57A6 - "Ram:InstallerGen/InstallerGen"  Hunk 0000 Offset 00000006
----> 00FEC326 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 000005B2
PC-8: 000000FF B2806F02 22002E1F 28015344 4681D28F 0241FFFC 2E41244F 204F10C4
PC *: 10D951CC FFFC2247 4ED12041 22427202 20199098 660451C9 FFF84E75 48E73E00
00ff0406 :  0000 00ff                  ori.b #-$1,d0
00ff040a :  b280                       cmp.l d0,d1
00ff040c :  6f02                       ble.s $ff0410
00ff040e :  2200                       move.l d0,d1
00ff0410 :  2e1f                       move.l (a7)+,d7
00ff0412 :  2801                       move.l d1,d4
00ff0414 :  5344                       subq.w #$1,d4
00ff0416 :  4681                       not.l d1
00ff0418 :  d28f                       add.l a7,d1
00ff041a :  0241 fffc                  andi.w #-$4,d1
00ff041e :  2e41                       movea.l d1,a7
00ff0420 :  244f                       movea.l a7,a2
00ff0422 :  204f                       movea.l a7,a0
00ff0424 :  10c4                       move.b d4,(a0)+
00ff0426 : *10d9                       move.b (a1)+,(a0)+
00ff0428 :  51cc fffc                  dbra d4,$ff0426
00ff042c :  2247                       movea.l d7,a1
00ff042e :  4ed1                       jmp (a1)
00ff0430 :  2041                       movea.l d1,a0
00ff0432 :  2242                       movea.l d2,a1
00ff0434 :  7202                       moveq.l #$2,d1
00ff0436 :  2019                       move.l (a1)+,d0
00ff0438 :  9098                       sub.l (a0)+,d0
00ff043a :  6604                       bne.s $ff0440
00ff043c :  51c9 fff8                  dbra d1,$ff0436
00ff0440 :  4e75                       rts
00ff0442 :  48e7 3e00                  movem.l d2-d6,-(a7)
Name: "InstallerGen"

[ancalimon]

Is it possible to modify existing Install scripts?

[Daedalus]

@daxb

Originally Posted by daxb

MuForce catched the hits. Here they are:

Thanks for that, I'll check it out over the weekend and see what I can do.

@ancalimon
No, I'm afraid you can't modify existing scripts. That would be quite a tricky job to be honest, but I might give it a bash at a later date.

[Daedalus]

@daxb

Okay, I've fixed the muforce hits. It only happened when the file requester was opened before a working directory was chosen - the null string wasn't handled properly there. I've also sorted out the redrawing, thanks to some pointers from Thomas on here.

Thanks for the feedback, I'll release an update soon with those and other fixes.

[Daedalus]

@thread

New version of InstallerGen released, sorry about the delay. Fixes the enforcer hits, adds Locale support, fixes some bugs with some step types (delete, exists), fixes the GUI jittering, during redraw, adds context-sensitive help, and lots of other fixes and improvements. Can be downloaded now from Aminet and from my website: http://www.robthenerd.com/projects/i...ergen/download

[daxb]

I get some (attached) hits when start InstallerGen, choose OS3.0/3.1 icon and then click on Generate script.

[Daedalus]

Hmmm, that's interesting, I wasn't getting any hits when I tested it. I'll check them out, thanks very much!

Edit: Does it happen if you choose other icons instead, or with no icon selected?

[daxb]

If I choose OS4 Icon then the GUI freeze. Script file is created but hasn`t an icon. With 3.0/3.1 icon selection also no icon. I guess the icon should copied and changed when saving the script? If so that is the cause.

[Daedalus]

Yes, the appropriate icon should be copied in all cases except when "None" is selected. That's very strange indeed, I'll check it out tonight when I'm home.

[Daedalus]

@daxb

I've been looking at this and I can't reproduce the problem. I've tried on 4.1, 3.9 and a bare 3.1 install and all work fine with no hits and no freezes or crashes. What's interesting though is that your hit log seems to show that wizard.library is involved. That library isn't required for InstallerGen, and it runs fine on my bare 3.1 setup with just MUI 3.8 and the latest NList.mcc installed. Blitz Basic does indeed put a check for wizard.library at the start of the executable, but it shouldn't use it. What version of wizard.library do you have? I'm using 42.100 (20/04/2000) on my 3.9 setup, 51.3 (15/11/2005) on my 4.1 setup, and (I've just checked) it is definitely not installed on my 3.1 setup at all.

Another thing that shows up is dos.library, which is used for copying the icons, but that's very straightforward and seems to work for all my combinations. Perhaps there's an incompatibility with some filesystem or patch or something... I've checked with both SFS and FFS partitions so I can't see that being a problem either. Can you check the icons in the Icons/ drawer please and make sure they all have the normal permissions? Maybe the r flag got lost in the unarchiving or something.

The only problem that I did notice is that a buggy lha module for UnArc replaces the spaces in file names with underscores causing the installer script problems, but standard LhA doesn't do that, and the latest module doesn't either. That still doesn't explain the crashing/hits though... Could you give me the exact script you were trying to generate? I've tried with a blank project, with the example project, and with a bunch of random steps, and all work fine with all icon settings...

[amigakit.com]

That looks like a really useful utility. Thanks for your hard work on this.

[daxb]

I`m just guessing but "SegList is invalid!!!" maybe means that all the stuff from SegTracker are pointless. However, wizard.library 42.100 (20/04/2000) here. The icons seem ok (on DOpus5.82) with "rwd" protection flags. I use LhA 2.15 68040+; SFS.

Example script:
I just start InstallerGen and chose an icon type, then click on "Generate script". This I did after I first noticed the crash. So I tried to isolate the causer what was when only a script icon is active. The "InstallerGen Project" also throw hits.

I tried InstallerGen with less patches what gives a different PC (reffers to ROM exec) but the same hit point (move.l $10(a1),d1) "LONG WRITE to 66F64E75" what is not a vailed address. Last address here is 0x02FFFFFF.

09-Dez-14   12:26:59 
LONG WRITE to  66F64E75        data=019A73A8   PC: 00F824CE
USP : 019A73A0 SR: 0010  (U0)(-)(D)  TCB: 019A6920
Data: 018874F4 018874DC 000003EE 00664463 00000000 00445D85 00000000 0000000F
----> 018874F4 - "System:Libs/wizard.library"  Hunk 0000 Offset 0000006C
----> 018874DC - "System:Libs/wizard.library"  Hunk 0000 Offset 00000054
Addr: 66F64E75 018874DC 019A697C 00000000 00000000 019A73EC 01080CB0 010826EC
Stck: 00FEC50E 00FEBBFC 018874F4 66F64E75 0500019A 73BC0000 019A6920 019A73A8
Stck: 019A697C 000003EE 00F81E82 00F94DFA 00664463 00000000 00445D85 00000000
Stck: 0000000F 00000007 00000001 019A743C 018874DC 0199118C 010A7A4C 00FF1732
Stck: 000003EE 000003EE 00000000 FFFFFFFF 00000000 80000001 00000000 019A6920
Stck: 00FEF38C 00000000 0199118C 01117614 00000000 01990EFC 016F042C 019A7498
Stck: 00FF1620 000003ED 0187A888 00FEF8D4 0187A9D4 01990EA4 00000000 00000000
----> 00F824CE - "ROM - exec 40.10 (15.7.93)"  Hunk 0000 Offset 00002418
----> 00FEC50E - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 0000079A
----> 00FEBBFC - "ROM - expansion 40.2 (9.3.93)"  Hunk 0000 Offset 000015EC
----> 018874F4 - "System:Libs/wizard.library"  Hunk 0000 Offset 0000006C
----> 00F81E82 - "ROM - exec 40.10 (15.7.93)"  Hunk 0000 Offset 00001DCC
----> 00F94DFA - "ROM - utility 40.1 (10.2.93)"  Hunk 0000 Offset 00000176
----> 018874DC - "System:Libs/wizard.library"  Hunk 0000 Offset 00000054
----> 00FF1732 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 000059BE
----> 00FEF38C - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 00003618
----> 00FF1620 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 000058AC
----> 00FEF8D4 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 00003B60
PC-8: 00DFF09A 522E0126 13400008 58882028 00042149 0004C188 48D10101 20892241
PC *: 22290010 67161029 000EC07C 00036728 B03C0001 66162241 4EAEFF4C 532E0126
00f824aa :  33fc 4000 00df f09a        move.w #$4000,$dff09a
00f824b2 :  522e 0126                  addq.b #$1,$126(a6)
00f824b6 :  1340 0008                  move.b d0,$8(a1)
00f824ba :  5888                       addq.l #$4,a0
00f824bc :  2028 0004                  move.l $4(a0),d0
00f824c0 :  2149 0004                  move.l a1,$4(a0)
00f824c4 :  c188                       exg.l d0,a0
00f824c6 :  48d1 0101                  movem.l d0/a0,(a1)
00f824ca :  2089                       move.l a1,(a0)
00f824cc :  2241                       movea.l d1,a1
00f824ce : *2229 0010                  move.l $10(a1),d1
00f824d2 :  6716                       beq.s $f824ea
00f824d4 :  1029 000e                  move.b $e(a1),d0
00f824d8 :  c07c 0003                  and.w #$3,d0
00f824dc :  6728                       beq.s $f82506
00f824de :  b03c 0001                  cmp.b #$1,d0
00f824e2 :  6616                       bne.s $f824fa
00f824e4 :  2241                       movea.l d1,a1
00f824e6 :  4eae ff4c                  jsr -$b4(a6)
00f824ea :  532e 0126                  subq.b #$1,$126(a6)
Name: "Background CLI"  CLI: ""  SegList is invalid!!!

While testing I also started until behind SetPatch and then start InstallerGen. So no MUI. Normaly nobody does this but the exception that happens shouldn`t (maybe a simple check lacks?):

09-Dec-14  12:16:30 
Exception !!   00000020     TCB: 015AB2A8     CTX: 011E0E00     SSP: 01082720
USP : 015BB324 SR: 0010  (U0)(-)(-)  TCB: 015AB2A8
Data: 015A5F34 015A3322 015C0C98 00008020 0000FFFF 00000000 00000000 00000000
----> 015A5F34 - "InstallerGen"  Hunk 0000 Offset 000353F4
----> 015A3322 - "InstallerGen"  Hunk 0000 Offset 000327E2
Addr: 00F8008F 015A3322 015A22EE 015A231E FFFFFFE8 01577E40 01080CB0 01082720
Stck: 01113968 015A6760 015A6760 01080CB0 01597D54 01570B46 000002A2 01570B40
Stck: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 01570B40
Stck: 00000000 00000000 00000000 00000000 015AB2A8 00000000 01597BF6 01570B46
Stck: 00FEC326 00010000 496E7374 616C6C65 7247656E 00000000 00000000 00008028
Stck: 015C33CC 011E58B0 0A0A00F8 23650000 015C0F70 015BB3C8 015C33C8 00002458
Stck: 00000000 00000000 015BB3E0 00000000 015C0DB0 E0E0E0E0 00000000 015BBF70
----> 015A5F34 - "InstallerGen"  Hunk 0000 Offset 000353F4
----> 015A6760 - "InstallerGen"  Hunk 0000 Offset 00035C20
----> 015A6760 - "InstallerGen"  Hunk 0000 Offset 00035C20
----> 01597D54 - "InstallerGen"  Hunk 0000 Offset 00027214
----> 01570B46 - "InstallerGen"  Hunk 0000 Offset 00000006
----> 01570B40 - "InstallerGen"  Hunk 0000 Offset 00000000
----> 01570B40 - "InstallerGen"  Hunk 0000 Offset 00000000
----> 01597BF6 - "InstallerGen"  Hunk 0000 Offset 000270B6
----> 01570B46 - "InstallerGen"  Hunk 0000 Offset 00000006
----> 00FEC326 - "ROM - dos 40.3 (1.4.93)"  Hunk 0000 Offset 000005B2
PC-8: 00000000 00040000 00000000 00A00000 00000000 70014E40 203C015A 5F344E40
PC *: 4D554920 496E6974 69616C69 7A617469 6F6E2045 52524F52 21212100 01577E40
015a5f14 :  0000 0000                  ori.b #$0,d0
015a5f18 :  0004 0000                  ori.b #$0,d4
015a5f1c :  0000 0000                  ori.b #$0,d0
015a5f20 :  00a0 0000 0000             ori.l #$0,-(a0)
015a5f26 :  0000 7001                  ori.b #$1,d0
015a5f2a :  4e40                       trap #$0
015a5f2c :  203c 015a 5f34             move.l #$15a5f34,d0
015a5f32 :  4e40                       trap #$0
015a5f34 : *4d55                       ??? ;illegal opcode
015a5f36 :  4920                       chk.l -(a0),d4 ;extended opcode
015a5f38 :  496e                       ??? ;illegal opcode
015a5f3a :  6974                       bvs.s $15a5fb0
015a5f3c :  6961                       bvs.s $15a5f9f
015a5f3e :  6c69                       bge.s $15a5fa9
015a5f40 :  7a61                       moveq.l #$61,d5
015a5f42 :  7469                       moveq.l #$69,d2
015a5f44 :  6f6e                       ble.s $15a5fb4
015a5f46 :  2045                       movea.l d5,a0
015a5f48 :  5252                       addq.w #$1,(a2)
015a5f4a :  4f52                       ??? ;illegal opcode
015a5f4c :  2121                       move.l -(a1),-(a0)
015a5f4e :  2100                       move.l d0,-(a0)
015a5f50 :  0157                       bchg d0,(a7)
015a5f52 :  7e40                       moveq.l #$40,d7
Name: "InstallerGen"  Hunk 0000 Offset 000353F4

[Daedalus]

Yep, starting it without MUI will result in a crash. I should probably do a check for it, but I'm not sure if that would be enough since AmiBlitz opens these libraries before a single line of my code is executed. I'll look into it and see if it's possible to implement a clean exit somehow...

You're probably right about the Seglist, but it's still strange that wizard.library is involved at all. Could you try it without wizard.library please? Maybe rename it and reboot. What sort of patches do you have installed?

It is very strange that it's writing to that address if you've no memory mapped up that high. I can't think of how that might be happening, or how that value ended up in A0. Could you run InstallerGen in debug mode and send me the output please? You need to run it from the shell like so:

installergen debug >debug-output.txt

and that might help me to see what it's doing when it crashes. Also, if you could please check if it crashes when launched from Workbench instead of DOpus, just in case something's happening there. And finally, could you try it with an increased stack? It never ran out of stack during my testing, but perhaps something has affected it differently on your system.

Thanks again, and sorry for the trouble!

[daxb]

I could shrink the problem a bit. wizard.library "running". Unfortunately really strange behaviour. After some tests the hits/crash only occur when I start InstallerGen exactly under this conditions from DOpus5.82:

Function : AmigaDOS   WBRun Work:InstallerGen/InstallerGen

   Flags : Output to Window

No problems:
- If I only remove "WBRun".
- If I only remove the flag "Output to Window".
- If start from Shell "WBRun Work:InstallerGen/InstallerGen >CON:" (KingCON shell)

So WBRun + InstallerGen + "Output to Window" flag from DOpus are responsible.

I always use WBRun to start programs this way and I never had problems and they work fine. The "Output to Window" flag is just for possible error output. In normal case no window will open.
I guess there could be something with DOpus "Output to Window" in conjunction with InstallerGen I/O handling. It might be worth a look.