AmiModRadio - All of Aminet modules at your fingertips - Page 29

Retrofan · 18 July 2021, 18:22

Quote:

Originally Posted by tygre

...Let's try

Bruce Abbott · 01 August 2021, 06:43

Quote:

Originally Posted by tygre

Hi all and thanks for your feedback!

My thoughts exactly: a ReAction GUI should be lighter than MUI but possibly at the cost of customisation...

...and compatibility.

I stopped using this program because after figuring out how to avoid the bugs I then discovered it uses a shareware program that brings up an annoying nag requester - too often.

It's 2021 and I thought we would be over that crap by now. But hey - thanks for creating an authentic retro experience!

AMIGASYSTEM · 01 August 2021, 11:37

Quote:

Originally Posted by Bruce Abbott

...and compatibility.
I then discovered it uses a shareware program that brings up an annoying nag requester - too often.

What would be this shareware software, i never had any request from shareware programs !

tygre · 03 August 2021, 21:42

Hi Bruce and AmigaSystem!

Thanks for your swift answer AmigaSystem, you expressed my thoughts exactly

What bugs and requester are you talking about Bruce?

Without some screenshots, steps to reproduce, etc., there is nothing much that I can do!

Take care,
Tygre

Bruce Abbott · 04 August 2021, 23:58

AmiModRadio README

Quote:

AmiModRadio is composed essentially of four parts:...

- A XAD client (http://aminet.net/package/util/arc/xadmaster020) to unarchive the downloaded archives;...

xadmaster020.readme

Quote:

The XAD system is for file extraction from archives...

This software is Shareware.

The bugs mostly relate to how AmiModRadio handles missing resources. I will check again with the lastest version and give you a report.

tygre · 05 August 2021, 00:04

Hey!

I fail to see the problem with the XAD system being shareware. I'm using its library, of course, to not reinvent the wheel. Besides, using the XAD library does not produce any requester, in my experience and (it seems) that of many others: could you share a screenshot or something so that I could investigate?

Take care!
Tygre

AMIGASYSTEM · 05 August 2021, 08:04

Quote:

Originally Posted by Bruce Abbott

The XAD system is for file extraction from archives...

This software is Shareware.

Free XAD system keyfile !!!

https://aminet.net/package/util/arc/xadmaster-key

tygre · 05 August 2021, 15:31

Hi AmigaSystem!

Quote:

Originally Posted by AMIGASYSTEM

Free XAD system keyfile !!!

https://aminet.net/package/util/arc/xadmaster-key

I had forgotten about that one, I installed XAD too long ago!

Cheers!

Bruce Abbott · 05 August 2021, 23:51

Quote:

Originally Posted by AMIGASYSTEM

Free XAD system keyfile !!!

https://aminet.net/package/util/arc/xadmaster-key

Thank you!

Silly me - I didn't look for a keyfile because I figured that with a release date in 2003 the program's shareware status was probably still valid.

Bruce Abbott · 06 August 2021, 22:57

XAD keyfile worked good.

Now a bug for you to look into. I tried to save the log file, but didn't type in a filename (should I?). Result was lots of Enforcer hits like this:-

Code:

BYTE-WRITE to  0000000C        data=00         PC: 782F6C76
USP:  783215D8 SR: 0004 SW: 0711  (U0)(-)(-)  TCB: 78319DD8
Data: 00000000 00000008 00000000 00000015 00000000 00000001 00000000 00000001
Addr: 0000000D 7839DE22 7839DCE0 7839DCD8 781CB738 78293E38 7829793C --------
Stck: 00000170 781D21BC 00000000 78296590 7830C79C 7820F1C4 00000000 7830C7A8
PC-8: 20522008 4A1866FC 90884680 D0BC0000 00112600 225291C8 22032008 600610D1
PC *: 67025289 53816AF6 487A174C 42A74EB9 78318E1C 504F4A80 6636487A 173E42A7
Name: "AmiModRadio"  Hunk 0000 Offset 0000968E

BYTE-WRITE to  0000000D        data=00         PC: 782F6C76
USP:  783215D8 SR: 0004 SW: 0711  (U0)(-)(-)  TCB: 78319DD8
Data: 00000000 00000007 00000000 00000015 00000000 00000001 00000000 00000001
Addr: 0000000E 7839DE22 7839DCE0 7839DCD8 781CB738 78293E38 7829793C --------
Stck: 00000170 781D21BC 00000000 78296590 7830C79C 7820F1C4 00000000 7830C7A8
PC-8: 20522008 4A1866FC 90884680 D0BC0000 00112600 225291C8 22032008 600610D1
PC *: 67025289 53816AF6 487A174C 42A74EB9 78318E1C 504F4A80 6636487A 173E42A7
Name: "AmiModRadio"  Hunk 0000 Offset 0000968E

Looks like A0 is an uninitialized pointer. Here's a disassembly of the code around the hit:-

Code:

i0009656:
   move.l  l2000a8c,A6                    ;asl_base
   move.l  A3,A0
   suba.l  A1,A1
   jsr     _LVOAslRequest(A6)
   tst.w   D0
   beq     i0009774
   lea     8(A3),A2
   move.l  (A2),A0
   move.l  A0,D0
i0009672:
   tst.b   (A0)+
   bne.s   i0009672
   sub.l   A0,D0
   not.l   D0
   add.l   #$00000011,D0
   move.l  D0,D3
   move.l  (A2),A1
   suba.l  A0,A0
   move.l  D3,D1
   move.l  A0,D0
   bra.s   i0009692

i000968c:
   move.b  (A1),(A0)+        ; <--- Enforcer hit here???
   beq.s   i0009692
   addq.l  #1,A1
i0009692:
   subq.l  #1,D1
   bpl.s   i000968c
   pea     a000ade4(PC)                   ;"/"
   clr.l   -(A7)
   jsr     r002b834

A previous hit GURU'd and invalidated my hard drive, so I am a bit reticent to do more testing until I can save the log file without risking a crash.

Bruce Abbott · 08 August 2021, 12:09

In the source code function mui_log_save() you have this:-

Code:

	if(AslRequest(request, NULL))
	{
		length = strlen(request->rf_Dir) + 1 + strlen(LOG_FILE_NAME) + 1;
		strncpy(file_name, request->rf_Dir, length);

But in the disassembly, file_name has been coded as suba.l A0,A0 (ie. a NULL pointer). Seems you did not initialize this pointer.

I see also that in mui_controls_modules_save() you have...

Code:

// Tygre 2018/11/02: WinUAE
// Without the following six lines, WinUAE crashes, because this code would be super bad!
	default_directory = malloc(length * sizeof(char));
	if(default_directory == NULL)
	{
		log_print_fatal_error( GetString( MSG_CONTROLSMUI_MUICONTROLSMODULESSAVECOULDNOTALLOCATEDIRECTORYNAME ) );
		goto _RETURN_ERROR;
	}
	strncpy(default_directory, request->rf_Dir, length);

which suggests you may have had a similar problem there too. I strongly recommend running The Enforcer or MuForce to catch low memory accesses caused by uninitialized pointers.

Bruce Abbott · 10 August 2021, 00:26

Using Delitracker as the player seems to be more stable than Hippoplayer, perhaps because its player modules are less buggy. Ran AmiModRadio for over 24 hours with no issues.

I also converted the radio and tape deck buttons to 8 colors using Art Dept. Professional, to suit my 3 bitplane Workbench screen. It's only be cosmetic, but inspires a bit more confidence seeing the images as they should look!

Lizart · 10 August 2021, 22:35

Hello all,
is there a way to enable autoplay on AmiModRadio? Or do I have to click the NEXT button after each mod?

andyhants · 11 August 2021, 11:34

Quote:

Originally Posted by andyhants

Any more news on fixing the Iconify issue ?

Bump !

Lisko · 11 August 2021, 12:18

Quote:

Originally Posted by andyhants

Bump !

The developer is working on a new version, which will make use of ReAction for the gui and maybe fix the issue.

Retrofan · 18 August 2021, 18:22

Quote:

Originally Posted by AMIGASYSTEM

... however, the problem remains Iconify and MUI_Redraw

Oh, yes. I've been playing with AmiModRadio today a bit and these are the only problems I see. This is a nice program

Lizart · 18 August 2021, 18:44

Bump!

Quote:

Originally Posted by lizart

hello all,
is there a way to enable autoplay on amimodradio? Or do i have to click the next button after each mod?

Retrofan · 18 August 2021, 21:04

BTW, I'm seeing that if I launch AmiModRadio from Script using Run (Run >NIL: AmiModRadio ), it shows some problems:

AMIGASYSTEM · 18 August 2021, 23:13

Quote:

Originally Posted by Retrofan

BTW, I'm seeing that if I launch AmiModRadio from Script using Run (Run >NIL: AmiModRadio ), it shows some problems:

I don't have that error, but AmiModRadio can't be run from Shell with the "Run Command", you have to use the "WBRun command" !!!

WBRun >NIL: AmiModRadio

See Video:

http://eab.abime.net/zone/AmiModRadioToShell.avi

Retrofan · 19 August 2021, 00:16

Quote:

Originally Posted by AMIGASYSTEM

I don't have that error, but AmiModRadio can't be run from Shell with the "Run Command", you have to use the "WBRun command" !!!

Maybe it is SegTracker that I use. BTW I'm seeing that it's been updated this year

http://aminet.net/package/dev/debug/SegTracker . Thomas Richter is the boss (... and also the culprit of that Mui_Redraw message complaining about what he doesn't like to be made with his program).

If it had any problem with WBRun I would have told. Tell me why can't I use Run instead.

BTW, you also can run it from the Shell like CD Sys:...whatever/AmiModRadio (drawer) and then writting AmiModRadio. It will run without the Gui and the good news is that then you can iconify the Shell.

05 August 2021, 00:04	#566
tygre Returning fan! Join Date: Jan 2011 Location: Montréal, QC, Canada Posts: 1,434	Hey! I fail to see the problem with the XAD system being shareware. I'm using its library, of course, to not reinvent the wheel. Besides, using the XAD library does not produce any requester, in my experience and (it seems) that of many others: could you share a screenshot or something so that I could investigate? Take care! Tygre Last edited by tygre; 05 August 2021 at 00:04. Reason: Typos

08 August 2021, 12:09	#571
Bruce Abbott Registered User Join Date: Mar 2018 Location: Hastings, New Zealand Posts: 2,593	In the source code function mui_log_save() you have this:- Code: if(AslRequest(request, NULL)) { length = strlen(request->rf_Dir) + 1 + strlen(LOG_FILE_NAME) + 1; strncpy(file_name, request->rf_Dir, length); But in the disassembly, file_name has been coded as suba.l A0,A0 (ie. a NULL pointer). Seems you did not initialize this pointer. I see also that in mui_controls_modules_save() you have... Code: // Tygre 2018/11/02: WinUAE // Without the following six lines, WinUAE crashes, because this code would be super bad! default_directory = malloc(length * sizeof(char)); if(default_directory == NULL) { log_print_fatal_error( GetString( MSG_CONTROLSMUI_MUICONTROLSMODULESSAVECOULDNOTALLOCATEDIRECTORYNAME ) ); goto _RETURN_ERROR; } strncpy(default_directory, request->rf_Dir, length); which suggests you may have had a similar problem there too. I strongly recommend running The Enforcer or MuForce to catch low memory accesses caused by uninitialized pointers.

10 August 2021, 00:26	#572
Bruce Abbott Registered User Join Date: Mar 2018 Location: Hastings, New Zealand Posts: 2,593	Using Delitracker as the player seems to be more stable than Hippoplayer, perhaps because its player modules are less buggy. Ran AmiModRadio for over 24 hours with no issues. I also converted the radio and tape deck buttons to 8 colors using Art Dept. Professional, to suit my 3 bitplane Workbench screen. It's only be cosmetic, but inspires a bit more confidence seeing the images as they should look! Attached Thumbnails

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Which games are using modules?	1988	request.Modules	7	29 July 2016 20:24
A few modules	Rogue	request.Modules	1	31 May 2014 18:22
two modules	s2325	request.Modules	4	01 May 2010 15:23
Brain Killer Aminet links changed (and a question about Aminet links)	Korodny	HOL data problems	0	26 November 2009 21:21
Modules..	Muerto	request.Modules	2	15 December 2005 17:32

03 August 2021, 21:42	#564
tygre Returning fan! Join Date: Jan 2011 Location: Montréal, QC, Canada Posts: 1,434	Hi Bruce and AmigaSystem! Thanks for your swift answer AmigaSystem, you expressed my thoughts exactly What bugs and requester are you talking about Bruce? Without some screenshots, steps to reproduce, etc., there is nothing much that I can do! Take care, Tygre

10 August 2021, 22:35	#573
Lizart Registered User Join Date: May 2020 Location: Germany Posts: 57	Hello all, is there a way to enable autoplay on AmiModRadio? Or do I have to click the NEXT button after each mod?

18 August 2021, 21:04	#578
Retrofan Ruler of the Universe Join Date: Mar 2010 Location: Lanzarote/Spain Posts: 6,190	BTW, I'm seeing that if I launch AmiModRadio from Script using Run (Run >NIL: AmiModRadio ), it shows some problems:

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)