English Amiga Board


Go Back   English Amiga Board > Coders > Coders. System

 
 
Thread Tools
Old 03 December 2017, 07:27   #2081
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Yeah, strange! I can reproduce it with DOpus5's icon info. But CopyIcon from Stephan Rupprecht works correctly. Use that!

Last edited by PeterK; 03 December 2017 at 07:44.
PeterK is offline  
Old 03 December 2017, 20:52   #2082
Michael
A1260T/PPC/BV/SCSI/NET
 
Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 839
Another interesting case...

WB
virtual def_icon assigned to a file
icon has a tool set to an arexx script file to be run as shell process

Now, if the icon is virtual (transparent) and we click it we get an error,
tool not found please select a new one.

If we snapshot the icon to give it a real icon with same setting,
clicking it will run the rexx script and do what's required from it.

(processfile.rexx (mod by Stephan Rupprecht))
Michael is offline  
Old 03 December 2017, 22:26   #2083
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Is the type of the DefIcon "Project" and the default tool Path/ProcessFile.rexx? And where can I find "ProcessFile.rexx"?

I've tried a DefIcon ENVARC:Sys/def_amigaguide.info with the default tool "Multiview" and that works at least for ghosted icons, but never tried an Arexx script yet. It's probably not a bug in icon.library, looks more like a problem in the AmigaOS and Arexx concept ?!
PeterK is offline  
Old 05 December 2017, 21:01   #2084
Michael
A1260T/PPC/BV/SCSI/NET
 
Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 839
Solved!
Looks like the CLI argument did not stick the last time I have tried it, since in workbench mode it gives an error but works ok now with the proper settings saved in ENVARC:
Michael is offline  
Old 08 December 2017, 14:10   #2085
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Icon.library 46.4.464 has been released on Aminet now.
PeterK is offline  
Old 10 December 2017, 00:52   #2086
indigolemon
Bit Copying Bard
 
indigolemon's Avatar
 
Join Date: Jan 2017
Location: Kelty, Fife, Scotland
Age: 41
Posts: 1,293
Installed - trying your new variation (SB020) - no problems so far. Thanks for all the work you put into this
indigolemon is offline  
Old 10 December 2017, 11:47   #2087
Retrofan
Ruler of the Universe
 
Retrofan's Avatar
 
Join Date: Mar 2010
Location: Lanzarote/Spain
Posts: 6,185
Excuse me: LD020 and SB020. I don't see what are they in the instructions.
Retrofan is offline  
Old 10 December 2017, 12:55   #2088
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
LD = Line by line direct Drawing
SB = Soft Borders with 50 % transparent pixels
The differences to the 68020 version are restricted to the direct drawing on Hi/TrueColor screens.
http://eab.abime.net/showpost.php?p=...postcount=2009

And NO, it's not a new 68k CPU type !!

Last edited by PeterK; 10 December 2017 at 13:02.
PeterK is offline  
Old 03 January 2018, 14:15   #2089
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Update to icon.library 46.4.465:

1.) For drawer names with an appended "/" the slash will be removed before the ".info" extension for the icon names is added, because nobody wants to access "drawer/.info" which would be mapped to "ENVARC:Sys/def_drawer.info". This sometimes has happened with ContextMenu, for example.

2.) Calling IconControlA(GetImageData2) will now also create the delayed planar image which is required by the original PowerIcons patch 1.06 for icon dragging. You don't need to call "NoDelayedImage2" anymore and after disabling PowerIcons the delay is immediately working again. Greetings to Elena

Last edited by PeterK; 06 January 2018 at 19:56.
PeterK is offline  
Old 09 January 2018, 21:53   #2090
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Update to icon.library 46.4.466:

Some experiments with the color reduction of OS4 and PNG icons. I hope that the quality is minimal better in some cases and that the code could also be a little faster on real Amiga CPUs, because I have replaced -(Ax) predecrement addressing by (Ax)+ postincrement instructions in the main loops. This makes no difference under emulation like UAE, of course. Feedback is welcome.
PeterK is offline  
Old 10 January 2018, 18:37   #2091
Michael
A1260T/PPC/BV/SCSI/NET
 
Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 839
PeterK, we have a big Bug!

Trash icon types are broken.

ProcessIcon, DO5 icon info what ever, convert Drawer to Trash type results in crap ;-)
Michael is offline  
Old 10 January 2018, 20:26   #2092
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Hi Michael,

this seems to be a problem of DOpus5 icon information, because it creates a trashcan icon in T: like DOpus-12345678-tmp.info, but it also wants to access the drawer DOpus-12345678-tmp, which it can't find when calling edit.

Strange thing: it works with a drawer icon under DOpus and it also works for trashcan icons with OS 3.9 WB icon information. Looks like another goodie of DOpus5.

Last edited by PeterK; 14 January 2018 at 21:05.
PeterK is offline  
Old 11 January 2018, 17:07   #2093
Michael
A1260T/PPC/BV/SCSI/NET
 
Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 839
40 prefs icons for OS4 loaded from disk CGX 8bit test

v465 - 4.60 sec
v466 - 4.20 sec

I'll say a good noticeable improvement.
Michael is offline  
Old 11 January 2018, 17:17   #2094
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Thank you for posting your results. You're the first, Michael !

Which CPU is that? I think the highest improvements are possible with 020/030 and less with 040/060. Nothing with WinUAE or Amithlon.
PeterK is offline  
Old 11 January 2018, 20:25   #2095
Michael
A1260T/PPC/BV/SCSI/NET
 
Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 839
That was on 060, and under DO5, which is also important to note.
In 16 bit modes the difference is 0.02 (within error tolerance)
Obviously the algorithm is not required there.
Michael is offline  
Old 11 January 2018, 20:45   #2096
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Quote:
Originally Posted by Michael View Post
In 16 bit modes ... Obviously the algorithm is not required there.
No, the color reduction for OS4 and PNG icons is always required by my library, but not under AfA_OS.
PeterK is offline  
Old 14 January 2018, 20:16   #2097
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Update to icon.library 46.4.467:

Two small bugfixes: A different size of the first and second image of PNG icons was not detected. The second image is dropped now and replaced by a darker copy of the first image with a glowing effekt. - Editing trashcan icons from the information menu under DOpus5 didn't work because the icon type of the temporary file in T: was set to 0 instead of 5. Loading failed with a "wrong type" error.
PeterK is offline  
Old 14 January 2018, 21:45   #2098
Michael
A1260T/PPC/BV/SCSI/NET
 
Michael's Avatar
 
Join Date: Jan 2013
Location: Moscow / Russia
Posts: 839
Nice work.

Some new benchmarks, 16bit test CGX/DO5

v465 - 4.88 sec
v467 - 4.72 sec
v467SB - 5.00 sec

So there is some speed-up on 16bit too, just not as noticeable
Michael is offline  
Old 14 January 2018, 22:54   #2099
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Quote:
Originally Posted by Michael View Post
Some new benchmarks, 16bit test CGX/DO5
v465 - 4.88 sec
v467 - 4.72 sec
Thanks again, these results are much closer to what I've expected than the unbelievable 10 % speedup that you've posted for your 8 bit benchmarks before.

I'm still waiting for some benchmarks from 68020/030 CPUs for PNG or OS4 icons. I think these CPUs should gain more relative speedup than 040/060. (Uploaded 46.4.465 again, just for comparison)
PeterK is offline  
Old 20 January 2018, 23:08   #2100
PeterK
Registered User
 
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,365
Update to icon.library 46.4.468:

The Ram Disk icon is now automatically copied to ENV:Sys/def_RAM.info and ENVARC:Sys/def_RAM.info as soon as any changes to the icon position or to the window settings are made. Icon Information (RAWBInfo and SwazInfo) is supported too, but needs DefIcons running. It's not required to use MakeLink. But this works only on OS 3.5/3.9. The ghosting for the Ram Disk is always off now.
PeterK is offline  
 


Currently Active Users Viewing This Thread: 2 (0 members and 2 guests)
 
Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
ClassicWB Full and icon.library 46.4 Retroplay project.ClassicWB 8 05 August 2018 13:57
WB library conflict/versions Amiga1992 support.Apps 3 22 July 2010 18:47
PNG Icon to Color Icon Converter? Leandro Jardim request.Apps 1 24 May 2010 04:39
What's the latest version of icon.library for OS3.9? NovaCoder support.Apps 3 30 June 2009 15:43
Requesting icon.library v44+... nikvest request.Other 2 16 September 2007 01:58

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 21:23.

Top

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.
Page generated in 0.22639 seconds with 16 queries