VBCC and enums

[PR77]

Does anyone know if VBCC supports enum types? I'm using the following version;

vbcc V0.9f (c) in 1995-2017 by Volker Barthelmann
vbcc code-generator for m68k/ColdFire V1.11 (c) in 1995-2017 by Volker Barthelmann

And trying to compile this code as part of my Flash Kickstart CPU Relocator combo project;

https://github.com/PR77/68000_Relocator_FLASH_Kickstart

When compiling I get the following error;

>tFlashCommandStatus checkFlashStatus(ULONG address)
warning 57 in line 58 of "FlashKickstart.c": , expected
>tFlashCommandStatus
warning 126 in line 59 of "FlashKickstart.c": no declarator in prototype
>tFlashCommandStatus
warning 126 in line 59 of "FlashKickstart.c": no declarator in prototype
>tFlashCommandStatus unlockFlashDevice(ULONG address)
warning 57 in line 59 of "FlashKickstart.c": , expected
>tFlashCommandStatus
warning 126 in line 60 of "FlashKickstart.c": no declarator in prototype
>tFlashCommandStatus
warning 126 in line 60 of "FlashKickstart.c": no declarator in prototype
>tFlashCommandStatus readManufactureID(ULONG address,
warning 57 in line 60 of "FlashKickstart.c": , expected
>tFlashCommandStatus readManufactureID(ULONG address, UWORD *
warning 57 in line 60 of "FlashKickstart.c": , expected
>tFlashCommandStatus readManufactureID(ULONG address, UWORD *
error 20 in line 60 of "FlashKickstart.c": no declarator and no identifier in prototype
aborting...

Any ideas?

[deimos]

I’m sure I’ve used enums with vbcc. Maybe it’s the typedef that’s the problem. What happens if you give the enum a name (after the enum keyword) and then change the prototypes to refer to enum thatname?

[Leffmann]

The enum and typedef is fine, but the rest of the program is completely broken; undefined types, usage of undeclared variables, function-calls that don't match the prototype etc.

[phx]

As far as I can see your are using AmigaOS typedefs (like ULONG) and AmigaOS system calls, without including any AmigaOS header files.

The errors are due to ULONG being undefined. It is defined in exec/types.h. And I would also recommend to include <proto/exec.h> and <proto/expansion.h>, but I didn't check the whole source...

[PR77]

Originally Posted by Leffmann

The enum and typedef is fine, but the rest of the program is completely broken; undefined types, usage of undeclared variables, function-calls that don't match the prototype etc.

It is the very first cut of the code. I have no expectation that it will compile, I just cant seem to get past the issue with the compile complaining about the function prototypes.

[PR77]

Originally Posted by phx

As far as I can see your are using AmigaOS typedefs (like ULONG) and AmigaOS system calls, without including any AmigaOS header files.

The errors are due to ULONG being undefined. It is defined in exec/types.h. And I would also recommend to include <proto/exec.h> and <proto/expansion.h>, but I didn't check the whole source...

I had that but for some reason NULL seems to be redefined;

C:\Users\Paul\Documents\Amiga\FLASH_KICKSTART\Rev1\Software>vc FlashKickstart.c
>#define        NULL    0
error 272 in line 30 of "exec\types.h": macro 'NULL' redefined unidentically
        included from file "C:\vbcc\targets\m68k-kick13\include/proto\exec.h":5
        included from file "FlashKickstart.c":5
1 error found!
vbccm68k -c99 -quiet -hunkdebug "FlashKickstart.c" -o= "C:\Users\Paul\AppData\Local\Temp\vbcc068c.asm"  -O=1 -no-cpp-warn -I"C:\vbcc\targets\m68k-kick13\include" -I"C:\vbcc\ndk13\include_h" failed

The code is really the first cut, and I can't seem to get past the enum issue.

[deimos]

I reckon Phx is right. Errors about things being redefined are due to incorrect ordering of the includes. At least in my experience.

[phx]

The problem is Commodore's exec/types.h and stdlib.h both define NULL. But unidentically. exec/types.h assigns 0L, while the standard headers use (void *)0, which is better because it causes an error when NULL is assigned to integers.

Usually including both, exec/types.h and stdlib.h, shouldn't be a problem, because stdlib.h does an #undef NULL before redefining it, and the official AmigaOS NDK3.1 and 3.9 headers do an #ifndef NULL check.

So you are probably using old Commodore headers (Kickstart 1.3 maybe?). Then you should try to include the standard headers behind them.

[PR77]

Thanks PHX! Now compiles but fails to link;

C:\Users\Paul\Documents\Amiga\FLASH_KICKSTART\Rev1\Software>vc FlashKickstart.c
>        printf("cd_BoardAddr = %lx\n", myCD->cd_BoardAddr);
warning 214 in line 320 of "FlashKickstart.c": suspicious format string
>        printf("cd_BoardSize = %lx (%ldK)\n", myCD->cd_BoardSize,((ULONG)myCD->
warning 214 in line 321 of "FlashKickstart.c": suspicious format string
>        print("Could not open specific Kickstart image [%s]", argv[1]);
warning 161 in line 361 of "FlashKickstart.c": implicit declaration of function <print>
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l73":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x28e): Reference to undefined symbol _OpenLibrary.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l77":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x2bc): Reference to undefined symbol _FindConfigDev.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l79":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x2d8): Reference to undefined symbol _CloseLibrary.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l88":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x37e): Reference to undefined symbol _CloseLibrary.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l93":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x3e4): Reference to undefined symbol _CloseLibrary.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l99":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x420): Reference to undefined symbol _CloseLibrary.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l95":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x400): Reference to undefined symbol _Open.
\Users\Paul\AppData\Local\Temp\vbcc068c.o: In "l98":
Error 21: \Users\Paul\AppData\Local\Temp\vbcc068c.o (CODE+0x416): Reference to undefined symbol _print.
vlink -bamigahunk -x -Bstatic -Cvbcc -nostdlib -Z -mrel "C:\vbcc\targets\m68k-kick13\lib\startup.o" "C:\Users\Paul\AppData\Local\Temp\vbcc068c.o"   -s -L"C:\vbcc\targets\m68k-kick13\lib" -L"C:\vbcc\ndk13\lib" -lvc -o a.out failed

EDIT: Building for KS 1.2/1.3 as the base.

[phx]

I guess you didn't include <proto/exec.h> and <proto/expansion.h>, but just <clib/...> from the Commodore headers, so function calls are not inlined but done via stub routines from amiga.lib.

You have to link with "-lamiga".

"print" is probably a typo. Did you mean "printf"?

[PR77]

Originally Posted by phx

I guess you didn't include <proto/exec.h> and <proto/expansion.h>, but just <clib/...> from the Commodore headers, so function calls are not inlined but done via stub routines from amiga.lib.

You have to link with "-lamiga".

"print" is probably a typo. Did you mean "printf"?

Thanks! Now compiled and linked. Will start debugging when I get some time. Thanks for your help phx!

[PR77]

Anyway know why VBCC throughs warning 214? Better still, what is wrong with the following printf(…)

printf("cd_BoardAddr = 0x%X\n", myCD->cd_BoardAddr);

[Leffmann]

It's probably a pointer type, casting it to ULONG or formatting with %p should get rid of the warning.