VGA mode resolution autoswitch problem

[mark_k]

I noticed a problem with the VGA mode resolution autoswitch option.

My HDF boots into Workbench with HIGHGFX:Super High Res Laced (1024×768) mode.

The attached config has VGA mode resolution autoswitch enabled, resolution set to Hires (normal), resolution autoswitch disabled. After booting the HDF to Workbench I can run a program which opens a PAL high res screen and switching between screens works fine; no double-width pixels when the PAL screen is frontmost.

To demonstrate the problem:
- Load config. Notice resolution is set to Hires (normal).
- Start emulation, HDF boots to HighGfx Workbench.
- Press F12, notice resolution is set to Superhires now.
- Save the (should-be unchanged) config to test1.uae then click OK or Cancel to continue emulation.
- Run a program that opens a PAL High res screen. It looks normal (not double-width).
- Press F12, notice resolution is set to Hires (normal) now.
- Save the (should-still-be unchanged) config to test2.uae then click OK or Cancel to continue emulation.
- Quit WinUAE. Run WinUAE again, load test1.uae. Boot the HDF. Run a program which opens a PAL high res screen. It's double-width.
- Load the test2.uae config. Boot HDF, run program which opens PAL high res screen. It's the correct non-doubled width.

So the problem appears to be, if a super-high res screen happens to be in front when you press F12 and save the config, when you next load that config, VGA mode resolution autoswitch doesn't work correctly.

However, if a high res screen happens to be in front when you save the config, next time you load the config it works fine.

[Toni Wilen]

What else could it do?

Resolution mode is decided when emulation starts, if it is superhires, you get 2xhires (and 4x lores) and there is nothing to switch.

Switching is only supported in most common mode, hires and VGA mode using shres. All other combinations are too pointless.

[mark_k]

The problem could (I think) be solved by not changing what appears in the Resolution drop-down in display settings when VGA mode resolution autoswitch is enabled. It would stay showing Hires (normal) so wouldn't be changed when the user saves their config, regardless of which screenmode happened to be showing when the user pressed F12.

[Toni Wilen]

Yes but there are too many unexpected side-effects, for example what if user wants to change the option? Another too rare use case to bother with, sorry..

[mark_k]

If the user wants to change the resolution shown in display settings they can. Just don't have WinUAE change it, otherwise whenever the user adjusts their config (changing any unrelated setting), they have to remember to manually set resolution to Hires before saving.

[Toni Wilen]

Change to hires when GUI shows hires but actual mode is shres?

Internally it is just superhires mode and graphics code should not need to know _why_ it is shres at this time. VGA autoswitch is simple hack and it stays simple hack.

[mark_k]

Well at the moment:

- Load a config with resolution set to SuperHires and VGA autoswitch box ticked. Start emulation and WinUAE doesn't use VGA autoswitch.

- Load a config with resolution set to Hires and VGA autoswitch box ticked. Start emulation and WinUAE does use VGA autoswitch (as it should).
When a superhires mode happens to be in use, press F12. Notice resolution is set to SuperHires and VGA mode autoswitch box is ticked. Continue emulation and WinUAE continues to use VGA autoswitch. So there is some kind of internal "use VGA autoswitch" flag which is set then, which doesn't get saved to the config file.

Could you just ghost out/disable the SuperHires resolution option when VGA autoswitch is checked? Since with that checked the user presumably wants to switch between Hires and SuperHires depending on the displayed mode? [Or maybe disable the resolution selection drop-down when VGA autoswitch is checked? Like you do when Resolution autoswitch is set to anything other than Disabled.]