icon.library 46.4 test versions

[Michael]

OS3.5 type (Volume = Disk in DO terms)

[PeterK]

No problems here with your def_RAM.info when copied into ENVARC:Sys.

The RAM: icon appears ghosted and opens a window with "All Files" as shown on the screenshot.

Do you use a dos.library replacement? Or do you use MakeLink for the icon? (I don't use either)

[Michael]

Same here, just the ENVARC:Sys/

But I found one important difference!

If I run WB on it's own, it works too!

But if I run WB from DO5(in WB replacement mode->
CLI->LoadWB), then it fails with v407, but works with v405.

[PeterK]

Hmm, very strange way to start the Workbench that you use!

How are you starting LoadWB exactly? As a background process? And why?

Anyhow, this unusual way to start the WB could explain the problem because the name of your Workbench task is probably not simply "Workbench" anymore, but maybe something like "Background CLI Workbench" or a similar name.

What does SnoopDOS display for the taskname when you open the RAM: window?

And indeed, for all tasks with a different taskname than "Workbench" or "Asyn"cWB the loading of a deficon for disks has changed between 404 and 407. That was done to fix the behaviour of DOpus5. Since DOpus5 doesn't use a constant taskname, I tried to exclude the tasks "Workbench" and "Asyn"cWB.

Not starting the Workbench with LoadWB from the end of the startup-sequence may also have other negative side effects if a different taskname is used.

[Michael]

Hmm... I don't follow your idea what to look at ?!

The process name in SnoopDos is the same
WB from DO5 -> [2] Workbench
WB from SS -> [9] Workbench

Looking at task names, Scout mask WB as special and hides it as Workbench [Workbench]

Xopa/SysInspector give : CLI-BGRD(11): Workbench (from DO5)
or as CLI-BGRD(9): Workbench (if started form SS)

So there is no major difference.

I use popup shell (or just CLI) and type LoadWB to load it, if I need it, if I have DO5 as WB replacement.

[PeterK]

Ok, if a different taskname is not the reason then I've no idea what else it could be. But whatever it is, you will probably have to live with this change or you should start the Workbench as usual.

And I cannot reproduce your DOS CLI environment without more detailed information (s-s, etc). So, no chance to fix it.

[Michael]

It's simple!

Run DO5 in WB replacement mode (LOADDB) from S-S

Then open a CLI window, and type LoadWB to load WB parallel on top of DO5.

So it might be the screen name or something! (if it is inherited or differs to default WB)

[PeterK]

Argh !!

I was always reading DOS instead of DO5

Now, I can reproduce it from DOpus5 CLI starting LoadWB and check it.

Update: The problem is caused by your crazy configuration, because if the Ram Disk has no icon then DOpus5 gets the def_disk.info now, no matter what type it has (this is a DOpus5 fix). But when you start LoadWB after that has happened then the WB finds a RAM:disk.info already and won't load the def_RAM.info anymore.

Solution: Copy >NIL: ENVARC:SYS/def_RAM.info RAM:disk.info

[Michael]

This has the following problems...

I prefer an empty RAM disk, so no icon copying there.

DO5 has it's own icon datatype/prefs system, so it uses those defines for disk icons here, so it's not supposed to get any def_icons by default. The same for all other file types.

I guess you are targeting DO5 to use def_icons with an extra patch to DO5 that disables it's internal filetype engine. It might be interesting to some, but it should not be made default. So a command like DO5_use_def_icons for icon.lib would make sense, so that it forces the v407 behaviour and by default icon.lib assumes v405 behaviour for DO5.

[PeterK]

Update to icon.library 46.4.408:

Totally reworked the internal "makeplanarmask" routine, which is used for old-style icons with only one image and inverse colors for the selected icon except for the background which appears transparent. Removed lots of memory allocations and freeings, many useless bitmaps and blitter calls and other trash like several Flood() calls from the original code. Tell me if something has been broken by my aggressive clean-up. It saves some hundred bytes.

When LoadWB is started after DOpus5 its tasknumber is now stored again. This should bring back the correct viewmodes for disk icons on the WB window. Better DOpus5 deficon support may come later.

[Michael]

I have a new problem!

Since v407 and 408 now I can't set default image for virtual floppy disks ;-)

DO5 has a mask for FF?: drives, and assigns a floppy icon to them when there is no icon. But now I get a default harddisk icon for them.

v405 works ok.

[PeterK]

Yes of course, I know that, my dear nagger

Better DOpus5 deficon support may come later.

Comes next, but it's hard to analyse what DOpus5 really does.

now I can't set default image for virtual floppy disks ;-)
DO5 has a mask for FF?: drives, and assigns a floppy icon to them when there is no icon.

How exactly do you setup the class assignments? I don't get it
What should I do in DOpus5 to assign def_RAM.info to RAM: (No copy or link)?
What should I do in DOpus5 to assign def_DF0.info to DFx: as default icon?

Btw, I've just noticed that the Flood() function calls, which I removed from my makePlanarMask routine now, were only used for the old WB 1.x icons to restrict the background transparency to the image surroundings.

[HanSolo]

Originally Posted by PeterK

How exactly do you setup the class assignments? I don't get it
What should I do in DOpus5 to assign def_RAM.info to RAM: (No copy or link)?
What should I do in DOpus5 to assign def_DF0.info to DFx: as default icon?

checkout amikit , there is def_RAM.info in env:sys and def_DF0.info copied as def_DF1 etc

[Michael]

My disk file types

[PeterK]

Update to icon.library 46.4.409:

Sorry, there was a small, bad bug in 408, causing crashes in some cases. This issue and the problems with DefIcons under DOpus5 should be fixed now.


I was forced to stay offline since February, 20th by the German Telekom, who disconnected my DSL line. Since I don't have a Handy and my health condition is too bad to leave the house anymore, I was totally isolated from the rest of this world for more than one month, until my sister visited me yesterday, just before I was running out of food. So finally, I could call the O2-hotline and the Telekom reconnected me to the DSL-net today.

[Retrofan]

Glad you are well man

[jbenam]

Damn, Peter, that could've been risky! You better buy a cellphone or something

Glad to know you're well

[PeterK]

Originally Posted by Michael

I have a new problem!

Since v407 and 408 now I can't set default image for virtual floppy disks ;-)

DO5 has a mask for FF?: drives, and assigns a floppy icon to them when there is no icon. But now I get a default harddisk icon for them.

v405 works ok.

Hello Michael,

is your problem solved now with 409 ?

@jbenam
Don't worry, I've ordered a simple and cheap cellphone with a prepaid sim card and also a lot of food

[Michael]

Not fully tested, but seems to be working better ;-) Virtual floppies get proper icons.

[HanSolo]

How about making your lib "localized" ?