My simple Hello World gurus on exit

[Nightfox]

Hello all


I am well experienced in C but not on Amiga. I am using the VS Code extension for a convenient dev environment.


I am merely opening a window and waiting for the user to close it. When it exits I get a software failure. Any ideas why? Thanks so much! <3

#include "support/gcc8_c_support.h"
#include <proto/exec.h>
#include <proto/dos.h>
#include <proto/graphics.h>
#include <proto/intuition.h>
#include <intuition/intuition.h>


struct ExecBase *SysBase;
struct DosLibrary *DOSBase;
struct IntuitionBase *IntuitionBase;

int main() {
    SysBase = *((struct ExecBase**)4UL);
    struct NewWindow NewWindow;
    struct Window *Window;

    IntuitionBase = (struct IntuitionBase *)OpenLibrary("intuition.library", 0);
    if (IntuitionBase == NULL)
    Exit(RETURN_ERROR);

    NewWindow.LeftEdge = 20;
    NewWindow.TopEdge = 20;
    NewWindow.Width = 300;
    NewWindow.Height = 100;
    NewWindow.DetailPen = 0;
    NewWindow.BlockPen = 1;
    NewWindow.Title = "DF0";
    NewWindow.Flags = SMART_REFRESH | ACTIVATE | WINDOWCLOSE | WINDOWDRAG;
    NewWindow.IDCMPFlags = CLOSEWINDOW;
    NewWindow.Type = WBENCHSCREEN;
    NewWindow.FirstGadget = NULL;
    NewWindow.CheckMark = NULL;
    NewWindow.Screen = NULL;
    NewWindow.BitMap = NULL;
    NewWindow.MinWidth = 0;
    NewWindow.MinHeight = 0;
    NewWindow.MaxWidth = 0;
    NewWindow.MaxHeight = 0;

    if ((Window = (structWindow *)OpenWindow(&NewWindow)) == NULL)
        Exit(RETURN_ERROR);

    Wait(1 << Window->UserPort->mp_SigBit);

    CloseWindow(Window);

    CloseLibrary(IntuitionBase);

    Exit(RETURN_OK);
}

[kamelito]

it works fine without the last Exit(RETURN_OK); after closing intuitionbase, there's a missing space in that line but I guess it is a typo.
if ((Window = (structWindow *)OpenWindow(&NewWindow)) == NULL)
Exit(RETURN_ERROR);

[jotd]

Which compiler are you using? if you're using gcc you should set -noixemul option

[alkis]

I think you are not supposed to call Exit() but exit()

[Nightfox]

Originally Posted by jotd

Which compiler are you using? if you're using gcc you should set -noixemul option

The custom gcc that comes with the Visual Studio Code extension. Using that option in the makefile just gives me:
m68k-amiga-elf-gcc: error: unrecognized command-line option '-noixemul'

Originally Posted by alkis

I think you are not supposed to call Exit() but exit()

I have to call Exit because exit is undefined. Also Exit is used in the example code

[Nightfox]

Originally Posted by kamelito

it works fine without the last Exit(RETURN_OK); after closing intuitionbase, there's a missing space in that line but I guess it is a typo.
if ((Window = (structWindow *)OpenWindow(&NewWindow)) == NULL)
Exit(RETURN_ERROR);

Yes that was an error when copying and pasting the code into this forum post. The space isnt really there

[alkis]

Originally Posted by Nightfox

I have to call Exit because exit is undefined. Also Exit is used in the example code

You shouldn't call Exit(), see http://amigadev.elowar.com/read/ADCD.../node015F.html

If the C compiler enviroment doesn't provide exit() then it is broken, as exit() is kind of fundamental.

Further more, when -- and only when -- you are inside main (as your sample is), you can replace exit(n); with return n;

[deimos]

Exit is part of dos.library, which you haven't opened. Adding

    DOSBase = (struct DOSBase *) OpenLibrary("dos.library", 0);

makes the crash go away.

[Nightfox]

Originally Posted by alkis

You shouldn't call Exit(), see http://amigadev.elowar.com/read/ADCD.../node015F.html

If the C compiler enviroment doesn't provide exit() then it is broken, as exit() is kind of fundamental.

Further more, when -- and only when -- you are inside main (as your sample is), you can replace exit(n); with return n;

Thanks, return 0 fixes the error. I normally use return n but I was following the example code that uses Exit(n) even in main().

[Hedeon]

Are you even linking to a c lib? Also where is the header file for exit()? stdlib.h