Prowiz Updates

[Asle]

Hi,

A little update regarding the depacker of SKYT Packer format in Prowiz. Was faulty when there was a track 0. Also, I rewrote the pattern list generation preventing duplicates.
Just overwrite with the attached file for a future WinUAE release .

Thanks !
Sylvain

[Asle]

Samely to the former post, here is an updated version of the ProPacker2.1 depacker. There was no real problem in there, save the pattern list generation which was way too big (same patterns were not detected). This update does that and reduces, generally, the PTK size output.
The source is attached.

Sylvain

PS: maybe this thread could be called "Prowiz : updates". It seems useless to create one entry per update.

[Toni Wilen]

Originally Posted by Asle

Samely to the former post, here is an updated version of the ProPacker2.1 depacker. There was no real problem in there, save the pattern list generation which was way too big (same patterns were not detected). This update does that and reduces, generally, the PTK size output.

Uchar *Header, *Pattern;; <- remove that duplicate ';'
"Whatever" is not declared anywhere (I assume it should have been included in above line too)

[Asle]

Originally Posted by Toni Wilen

Uchar *Header, *Pattern;; <- remove that duplicate ';'
"Whatever" is not declared anywhere (I assume it should have been included in above line too)

uh .. weird. there was a malloc on Whatever but it wasn't used anywhere. Dev-CPP didn't complain !
Anyway, it's cleaned up in the attached file.

Sylvain


PS : and I forgot a printf() .. *geee*

[Asle]

Hey,

While I was at it, I've updated the other ProPacker versions (the ones by Estrup/Static Bytes, not PhaPacker). Again, it's about pattern list generation which is now clean (i.e. no more identical patterns stored).
These are really close to PP21 and required very few effort to update, so ...

Btw, anyone interested in details should contact me. Just, don't hesitate.

Sylvain

[bLAZER]

Great with updates, I'll update BZR Player as well. I also couldn't compile with the two ;; which took me some minutes to figure out...

[Asle]

Originally Posted by bLAZER

Great with updates, I'll update BZR Player as well. I also couldn't compile with the two ;; which took me some minutes to figure out...

Hi,

I've replied in the appropriate thread, about BZR Player. See you there

Sylvain

[Asle]

About Propacker 1.0, 2.1 and 3.0 depackers;
All right, following intensive tests, I've found out that I've introduced a bug that is triggered if a patternlist contains only unique patterns (i.e. patterns are not re-used).
I've updated the sources to fix that.

All the best,
Sylvain

[Toni Wilen]

done, but had to remove some fflush (info);'s

[Asle]

Just to note that I've introduced another bug in these PP* decrunchers. However, this time I won't rush the fix. I want it clean, good and final.
Will keep you posted shortly.

Sylvain

[Asle]

OK, I've run through all my PP10 (not much), all my PP21 (~150) and all my PP30 (not much).
I found the bug almost immediately after posting here, the other day. I felt bad almost as fast .
Anyway, here are yet another set of decrunchers. Hopefully, these will be OK for everyone.

Also, Blazer sent me various files that generate problems in Prowiz. For GMC, I've found that, indeed, there was a problem when only one pattern was present in the file. This is fixed. I've also loosened up some tests a bit for some bad files in the game Jumping Jack Son (for example).
There was also a invalid test in PP30 regarding pattern break command. Fixed now.
Last, an uncleaned variable was doing damage in rare cases for Noisepacker 3 decruncher.
So thanks for this feedback !

Sylvain

PS: I'm compiling with -ansi now and it gets results, so no more fflush()

[Toni Wilen]

Any reason for "undocumented" file name changes? (GMC.c and NP3.c <> GameMusicCreator.c and NoisePacker3.c)

[Asle]

Originally Posted by Toni Wilen

Any reason for "undocumented" file name changes? (GMC.c and NP3.c <> GameMusicCreator.c and NoisePacker3.c)

Yes, well, commandline too big for Dev-CPP to link the lot. I'm sorry I didn't check WinUAE archive to verify that. I did the change quite some time ago, but failed to report/release it.
These small updates were supposed to be transparent ... ah, well.

Again, sorry. Just put the old names if it's easier for you.

Sylvain

[Toni Wilen]

I don't mind file names changing but I don't want to see original names in next update

[Asle]

Hi,

Blazer came back with some more feedback (Thanks !). He detected a few more unexpected behaviors that lead me to submit the attached updates.
It's, again, about an overzealous check (Eureka) or Patternlist with only one pattern (KSM and NP1).

All the best,
Sylvain

PS: filenames are as stored in http://github.com/tonioni/WinUAE/tre...izard/rippers/

[Asle]

Hello,

Blazer pointed again a weird behavior in Prowiz for AC1D packer. I've fixed the problem and submit now the file.

Cheers
Sylvain

[Asle]

Hello again,

As Blazer pointed out, maybe I should have submitted my updated directly on github (no account there for me yet).
Is this preferable or not to proceed that way ?

Cheers
Sylvain

[Toni Wilen]

Update will be added before next official version. It is not important enough for immediate update