Virocop AGA - Harddisk install - Page 2

DamienD · 20 March 2018, 22:37

Ok, I've now put the following in The Zone! also: ViroCopAGA_ORG.lha

Obviously this was installed using the .IPFs; went through the same procedure as detailed in post #11...

Extract to wherever you like

As an example; I just used a clean "Classic WB Lite 3.1" .HDF, extracted the archive to a folder "_EAB_", then tested. All good!!!

AMIGASYSTEM · 20 March 2018, 22:39

Damiano, when you play the game from HD you also have the floppy inserted?

DamienD · 20 March 2018, 22:39

Quote:

Originally Posted by AMIGASYSTEM

Damiano, when you play the game from HD you also have the floppy inserted?

Nope... why would you need to?

Surely that defeats the purpose of a hard drive install?

DamienD · 20 March 2018, 22:42

Quote:

Originally Posted by StingRay

Oh Jesus Bloody Christ... Found the problem and as I have guessed the file loader is buggy! move.w #MODE_OLDFILE,d2. Any coder should spot the problem immediately. I may create a fix for this game tomorrow, for now I can't stand looking at buggy code anymore.

Nice work StingRay but the "loader" is only in the Hoodlum cracked / trained disks...

Also, this version works fine here without anything being changed

Has anyone actually tried the 2 x .LHAs I created as yet?

a) ViroCopAGA.lha
b) ViroCopAGA_ORG.lha

Both work perfectly, tested numerous times

StingRay · 20 March 2018, 22:50

Quote:

Originally Posted by DamienD

Nice work StingRay but the "loader" is only in the Hoodlum cracked / trained disks...

Also, this version works fine here without anything being changed

I am referring to the file loader in the game binary! Which is buggy and DOES need to be changed as it doesn't call Open()( with the correct parameters and hence the file will not be loaded which in turn will cause the "Insert Disk 1" screen to be displayed. That it works for you is pure coincidence as d2.l apparently is cleared on your system for whatever reason.

DamienD · 20 March 2018, 22:57

Quote:

Originally Posted by StingRay

That it works for you is pure coincidence as d2.l apparently is cleared on your system for whatever reason.

You're the expert so I'm not going to dispute your findings

I do find it really weird though that I've installed both the Hoodlum cracked / trained and the original .IPFs versions now; not once have I had the issues anyone else has described.

I even blew away my .HDF and extracted both from the .LHAs many times to totally different / random folders; still no issues when running.

Nothing special about my "Classic WB Lite 3.1" .HDF; it's a clean / just installed file

AmigaBoy · 20 March 2018, 22:59

Quote:

Originally Posted by DamienD

Has anyone actually tried the 2 x .LHAs I created as yet?

a) ViroCopAGA.lha
b) ViroCopAGA_ORG.lha

Just tried ViroCopAGA_ORG.lha

Unpacked to root of DH1: (thus DH1:ViroCop/ is now in there) and ran. It asks for VIROCOP:

(Ignore graphical corruption - Probably a bad WinUAE config)

StingRay · 20 March 2018, 23:00

Quote:

Originally Posted by DamienD

I do find it really weird though that I've installed both the Hoodlum cracked / trained and the original .IPFs versions now; not once have I had the issues anyone else has described.

It's not weird at all. Code is buggy and works by pure luck as long as the upper part of register d2 is cleared. If that is not the case the file loading will not work at all.

DamienD · 20 March 2018, 23:00

Quote:

Originally Posted by AmigaBoy

Just tried ViroCopAGA_ORG.lha

Unpacked to root of DH1: and ran. It asks for VIROCOP:

(Ignore graphical corruption - Probably a bad WinUAE config)

What the???

...I really can't explain that; again my testing platform is a "Classic WB Lite 3.1" .HDF that's clean and just been installed.

AmigaBoy · 20 March 2018, 23:02

Quote:

Originally Posted by DamienD

What the???

...I really can't explain that; again my testing platform is a "Classic WB Lite 3.1" .HDF that's clean and just been installed.

Mine is a clean WB 3.1 install. Nothing on it at all.

I don't know. *shrug*

StingRay · 20 March 2018, 23:03

Quote:

Originally Posted by DamienD

...I really can't explain that

I have already explained the problem several times. The code in the game is buggy!

Seiya · 21 March 2018, 00:54

ok, i'll wait you fix.

StingRay · 21 March 2018, 08:22

I have coded a fix, start "ViroCopPatch" before running the game (add it to the script which runs the game). It will fix the "Insert Disk 1" problem.

Code:

; ViroCop Patch
; 
; patches Open() (dos.library) to accept accessMode as .w parameter
; this fixes the "Insert Disk 1" problem


START	move.l	$4.w,a6
	moveq	#0,d0			; any version will do
	lea	DOSName(pc),a1
	jsr	-408(a6)		; OpenLibrary()
	move.l	d0,a1
	tst.l	d0
	beq.b	.out

; patch Open()
	lea	-30.w,a0		; Open()
	pea	NewOpen(pc)
	move.l	(a7)+,d0
	jsr	-420(a6)		; SetFunction()
	lea	OldOpen(pc),a0
	move.l	d0,(a0)


.out	rts



NewOpen	swap	d2
	clr.w	d2
	swap	d2
	move.l	OldOpen(pc),-(a7)
	rts

	dc.b	"$VER: Virocop patch 1.0 (21.03.2018) by StingRay/[S]carab^Scoopex",10,0
	CNOP	0,2

DOSName	dc.b	"dos.library",0
	CNOP	0,2
OldOpen	dc.l	0

malko · 21 March 2018, 08:44

Thank you StingRay. I put it in my school-bag for a future reference

Seiya · 21 March 2018, 12:09

very thanks

StingRay · 21 March 2018, 12:10

You're welcome.

Seiya · 21 March 2018, 12:23

but don't work.
when i launch the patch i have this error: ViroCopPatch.68k failed returncode 363410 (but this number changes)

ross · 21 March 2018, 12:25

I can bet that coder used

move #MODE_OLDFILE,d2

syntax.
So you can expect some other .w/.l bugs..

But a simple ext.l can fix it

StingRay · 21 March 2018, 12:26

Quote:

Originally Posted by Seiya

but don't work.
when i launch the patch i have this error: ViroCopPatch.68k failed returncode 363410 (but this number changes)

You can ignore this error. I didn't feel like clearing d0 upon return. The patch is still installed nevertheless.

Edit: well, wasting 10 seconds was worth it I guess. Patch now returns an error code if it wasn't installed, otherwise it's silent.

Quote:

Originally Posted by ross

I can bet that coder used

move #MODE_OLDFILE,d2

syntax.

See my comment on page 1 of this thread.

Quote:

Originally Posted by ross

So you can expect some other .w/.l bugs..

Interestingly enough in the "SaveFile" routine the correct move.l #MODE_NEWFILE,d2 is used.

Quote:

Originally Posted by ross

But a simple ext.l can fix it

There are many ways to fix this but I deliberately didn't use ext.l just in case coder felt like using the sign bit in some Open() routine!

ross · 21 March 2018, 12:59

Quote:

Originally Posted by StingRay

See my comment on page 1 of this thread.

Quote:

There are many ways to fix this but I deliberately didn't use ext.l just in case coder felt like using the sign bit in some Open() routine!

Well, using .w and the sign bit for accessMode is a great combo!
Bugs squared

21 March 2018, 12:25	#38
ross Defendit numerus Join Date: Mar 2017 Location: Crossing the Rubicon Age: 53 Posts: 4,476	I can bet that coder used move #MODE_OLDFILE,d2 syntax. So you can expect some other .w/.l bugs.. But a simple ext.l can fix it

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Virocop AGA WHDLoad	Anakirob	support.Games	22	19 March 2015 13:04
Worms DC AGA HD install	Vollldo	support.Games	7	18 March 2011 17:43
Error trying to install civ aga to HD	dug26	support.WinUAE	2	07 June 2010 16:28
Mounting Native PC(formatted) harddisk as a Harddisk for WinUAE/E-UAE	Zetr0	support.Hardware	10	01 June 2006 14:04
Ripping - Virocop AGA	maVado	project.Sprites	2	01 August 2005 21:42

20 March 2018, 22:37	#21
DamienD Banned Join Date: Aug 2005 Location: London / Sydney Age: 47 Posts: 20,420	Ok, I've now put the following in The Zone! also: ViroCopAGA_ORG.lha Obviously this was installed using the .IPFs; went through the same procedure as detailed in post #11... Extract to wherever you like As an example; I just used a clean "Classic WB Lite 3.1" .HDF, extracted the archive to a folder "_EAB_", then tested. All good!!!

20 March 2018, 22:39	#22
AMIGASYSTEM Registered User Join Date: Aug 2014 Location: Brindisi (Italy) Age: 70 Posts: 8,252	Damiano, when you play the game from HD you also have the floppy inserted?

21 March 2018, 00:54	#32
Seiya Registered User Join Date: Nov 2014 Location: Italy Posts: 2,369	ok, i'll wait you fix.

21 March 2018, 08:44	#34
malko Ex nihilo nihil Join Date: Oct 2017 Location: CH Posts: 4,889	Thank you StingRay. I put it in my school-bag for a future reference

21 March 2018, 12:09	#35
Seiya Registered User Join Date: Nov 2014 Location: Italy Posts: 2,369	very thanks

21 March 2018, 12:10	#36
StingRay move.l #$c0ff33,throat Join Date: Dec 2005 Location: Berlin/Joymoney Posts: 6,863	You're welcome.

21 March 2018, 12:23	#37
Seiya Registered User Join Date: Nov 2014 Location: Italy Posts: 2,369	but don't work. when i launch the patch i have this error: ViroCopPatch.68k failed returncode 363410 (but this number changes)

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)