Need to extract batch of .lha archives into folders

[jPV]

Originally Posted by Foebane

The problem I'm having now is that the script, when executed from DOpus, will invariably run TWICE, causing me to abort the second run. Why is it doing this?

Maybe because it has parenthesis in its name? They are special characters in AmigaDOS, so I would advice not to use them in file names no matter if it's the reason here or not. By using them you'll end up with trouble sooner or later anyway.. especially if handling such files from scripts.


Here's what Amiga manuals tell:

Colons (:) and slashes (/) are reserved and cannot be used in file or directory names. Semicolons (;), asterisks (*), parentheses (()), question marks (?), back apostrophes (`), number or pund signs (#), square brackets ([]), angle brackets (<>), tildes (~), vertical bars (|), dollar signs ($), double quotation marks ("), and percent signs (%) are not reserved; however, we recommend that you do not use these characters in your file or directory names because they have special meaning in AmigaDOS.

[emufan]

I'm not intended to make thing more complicated and I do not use DOpus,
but Diskmaster2 - on aminet, which seems down atm.

with zip archives, I also get wrong or not-set file attributes, zip does not preserves them.

what I do with diskmaster2, I was adding menu entries.
with diskmaster2 you allways have 2 listers, one source (%n) the other destination (%d).
so I select the archives (source) and use my "Archive --> Destination" entries.
so the archives get extracted in the destination location.

the config entries - 4 entries, each deals with one type of archive,
for SYS:S/Diskmaster2.prefs looks like this:

AddMenu Archives, Lha X >Dest, StdIO "CON:0/12/640/180/DM2";Extern Lha x %n %d;StdIO CLOSE
AddMenu Archives, Lzx X >Dest, StdIO "CON:0/12/640/180/DM2";Extern Lzx x %n %d;StdIO CLOSE
AddMenu Archives, UnZip >Dest, StdIO "CON:0/12/640/180/DM2";Extern unzip %n -d %d;StdIO CLOSE
AddMenu Archives, UnRar >Dest, StdIO "CON:0/12/640/180/DM2";Extern unrar x %n %d;StdIO CLOSE

you cannot use this config with DOpus, but there must be something equally simple with DirectoryOpus.

[Foebane]

Originally Posted by daxb

You may doing something wrong. How do you start the script? Check DOpus flags that could cause it. SnoopDos can help.

If there isn't a good reason for it I would move the first line (Delete) at the end of the script.

It only happens sometimes. I ran it just now for a couple of WHDLoad games and it ran just fine, once. I set the S attribute because it's a script. I only really needed a way to abort the script if there was a problem, and it turns out Ctrl+D stops the script, according to the AmigaOS manual.

The Delete command is at the start in case there is a problem running the script, so by deleting any old script at the start then X.txt will be sure to be blank before the lists are added and then executed. I've been doing it like this for a long time, and there was never a problem with repeating executions, which have only happened very recently.

What are DOpus flags?

Originally Posted by jPV

Maybe because it has parenthesis in its name? They are special characters in AmigaDOS, so I would advice not to use them in file names no matter if it's the reason here or not. By using them you'll end up with trouble sooner or later anyway.. especially if handling such files from scripts.

Yes, I think you're right. The name change to include the brackets is recent, and now I come to think of it, coincides with the problem occurring. OK, I'll rename it without brackets and see how it goes.

EDIT: I'm surprised I didn't realise it would cause a conflict, when I already removed the brackets from .lha archives that would be used on Amiga already, only a few weeks before. D'oh!

[daxb]

Originally Posted by Foebane

What are DOpus flags?

If you are in the Functions Editor of DOpus (buttons, hotkeys, menu, datatypes) then you have {} button for arguments and below is a list of options.

[jPV]

Originally Posted by Foebane

The Delete command is at the start in case there is a problem running the script, so by deleting any old script at the start then X.txt will be sure to be blank before the lists are added and then executed.

You can optimize it a bit If you'd use ">" (single) redirection at the first list line (lha) then it'd start a new file always (no matter if there is an old file or not, it will be a fresh file always) and you don't need the delete line. Keep the ">>" (double) redirection just for the other lines (lzx and zip).

[Foebane]

Originally Posted by jPV

You can optimize it a bit If you'd use ">" (single) redirection at the first list line (lha) then it'd start a new file always (no matter if there is an old file or not, it will be a fresh file always) and you don't need the delete line. Keep the ">>" (double) redirection just for the other lines (lzx and zip).

But the source folder for the archives will not always contain .lha archives, so again, the >> and Delete line are still required.

[jPV]

Originally Posted by Foebane

But the source folder for the archives will not always contain .lha archives, so again, the >> and Delete line are still required.

No they aren't, because if there aren't any files found, the list command with > still creates a new (empty) file

[Foebane]

Originally Posted by jPV

No they aren't, because if there aren't any files found, the list command with > still creates a new (empty) file

Hmm, I never considered that. Thank you, I will make the change for the next version of the script.

[Foebane]

The latest (last?) version of my script. More efficient than ever, thanks to people here for their advice!

[daxb]

Delete the script (.txt) after executing it is still an option if you don't want to have it sitting in RAM.

[Foebane]

Originally Posted by daxb

Delete the script (.txt) after executing it is still an option if you don't want to have it sitting in RAM.

I'm guessing that a warm reset will erase it? I usually have to do those after every few games and demos anyway.

[jPV]

Maybe changing those X:%N ones to %P%N would make it easier to update it later, if you want to change the location from where files are scanned.

I couldn't resist making an über cool (tm) more complicated and feature rich version of this script, sorry Maybe it would be fine learning material for anyone who would like to go deeper into wonderful world of Amiga shell scripting :P

It shows some information while progressing and also notifies if there were any errors in archives. You can also define different source and/or destination directories.

Here it is:

.KEY SOURCE,DEST
.DEF SOURCE X:
.DEF DEST RetroStuff:X/
; ^
; User can give source and destination direcotries, but defaults are also provided.
; Note that DEST must end with : or / always!

; Let's not stop on unarchiving errors, but handle them in our script.
FAILAT 20

; Print some information in bold.
ECHO "*E[1mUnpacking archives from <SOURCE> to <DEST>*E[22m"
ECHO "Scanning dir..."

; Let's use escape sequences to print information over the same line always. We'll handle any errors too.
LIST <SOURCE> PAT=#?.lha LFORMAT="ECHO *"**E[1F**E[K%P%N*"*NLhA -q x *"%P%N*" *"<DEST>%M/*"*NIF WARN*N ECHO *"**E[1F**E[KERROR IN: %P%N**E[1E*"*N SET ERR TRUE*NENDIF" > T:X.txt
LIST <SOURCE> PAT=#?.lzx LFORMAT="ECHO *"**E[1F**E[K%P%N*"*NLZX -q x *"%P%N*" *"<DEST>%M/*"*NIF WARN*N ECHO *"**E[1F**E[KERROR IN: %P%N**E[1E*"*N SET ERR TRUE*NENDIF" >> T:X.txt
LIST <SOURCE> PAT=#?.zip LFORMAT="ECHO *"**E[1F**E[K%P%N*"*NUnZip >NIL: -o *"%P%N*" -d *"<DEST>%M*"*NIF WARN*N ECHO *"**E[1F**E[KERROR IN: %P%N**E[1E*"*N SET ERR TRUE*NENDIF" >> T:X.txt
EXECUTE T:X.txt

ECHO "*E[1F*E[KDONE."

; If there was an error, let's wait that nothing closes the window too quickly if launched from DOpus etc.
IF $ERR EQ "TRUE"
 UNSET ERR
 WAIT 10
ENDIF

[Foebane]

I like your adaptation of my script, but I'm wondering what errors there could be when extracting them. I usually test the archives on the PC side with 7-zip, to make sure there are no problems there.

[jPV]

I guess it's unlikely to see any then, but doesn't hurt to check for them either Anyway if someone wants to use this for other cases etc... will be good to see if something fails.

[Foebane]

I loved the idea of the source and destination variables so much I implemented them into my own script, which now looks like this:

.KEY SRC,DST
.DEF SRC X:
.DEF DST RetroStuff:X/
LIST <SRC> PAT=#?.lha LFORMAT="LhA x *"%P%N*" *"<DST>%M/*"" >RAM:X.txt
LIST <SRC> PAT=#?.lzx LFORMAT="LZX x *"%P%N*" *"<DST>%M/*"" >>RAM:X.txt
LIST <SRC> PAT=#?.zip LFORMAT="UnZip *"%P%N*" -d *"<DST>%M*"" >>RAM:X.txt
EXECUTE >NIL: RAM:X.txt

It looks neater, I don't have to make changes in the three main lines anymore, and I can change the variables with ease.

Have you tried your script with zip files? I notice you have a trailing slash in the UnZip command, like the other two, but it won't work with it.

[jPV]

Originally Posted by Foebane

It looks neater, I don't have to make changes in the three main lines anymore, and I can change the variables with ease.

Yeah, looks nice now

Have you tried your script with zip files? I notice you have a trailing slash in the UnZip command, like the other two, but it won't work with it.

Yes I did and it worked. Maybe it depends of the UnZip version or something, these *nix ports are plenty and different always... I'll remove the slash from my example just in case though.

[Foebane]

I discovered that the UnZip command cannot extract the .zip archives if the destination folder does not already exist, but it's no big issue. I tried to use MAKEDIR <DST> but no such luck.

Also, the "script running twice" bug is back. I thought Ctrl+D would abort it, but it didn't work. What is causing it to run twice?

[Foebane]

jPV, do you know what would happen if I use "RUN" on a script instead of "EXECUTE"?

[daxb]

It will say something like can't execute file. If you set script bit on x.txt first, then should work. Why do you want to use RUN or do you mean the script you start manually?

[Foebane]

Originally Posted by daxb

It will say something like can't execute file. If you set script bit on x.txt first, then should work. Why do you want to use RUN or do you mean the script you start manually?

I'm just wondering why, when the script is run as you describe above, it completes but then it runs once again automatically and asks if I want to overwrite the files I've just extracted! It should only run once, and sometimes it does, but sometimes it runs again immediately. Why?