"bug" in GBA 1.43 Game update [RUNME.bat in Games pack zips with paths]

[OddbOd]

Hi guys, I have just finished unpacking the 1.43 update and re-ran clrmamepro to check that all the game ADFs were now correct, to my surprise it started throwing wrong name errors on every file in the update i.e.

1869 - Erlebte Geschichte Teil I_DiskA [folder: 1869 - Erlebte Geschichte Teil I_DiskA - size: 880kb]
wrong name: D:\Downloads\ROMS\GameBase Amiga\Games\1869 - Erlebte Geschichte Teil I_DiskA\adf\1869 - Erlebte Geschichte Teil I_DiskA.adf [wrong: adf\1869 - Erlebte Geschichte Teil I_DiskA.adf] [right: 1869 - Erlebte Geschichte Teil I_DiskA.adf]

1869 - Erlebte Geschichte Teil I_DiskB [folder: 1869 - Erlebte Geschichte Teil I_DiskB - size: 880kb]
wrong name: D:\Downloads\ROMS\GameBase Amiga\Games\1869 - Erlebte Geschichte Teil I_DiskB\adf\1869 - Erlebte Geschichte Teil I_DiskB.adf [wrong: adf\1869 - Erlebte Geschichte Teil I_DiskB.adf] [right: 1869 - Erlebte Geschichte Teil I_DiskB.adf]

1869 - Erlebte Geschichte Teil I_DiskC [folder: 1869 - Erlebte Geschichte Teil I_DiskC - size: 880kb]
wrong name: D:\Downloads\ROMS\GameBase Amiga\Games\1869 - Erlebte Geschichte Teil I_DiskC\adf\1869 - Erlebte Geschichte Teil I_DiskC.adf [wrong: adf\1869 - Erlebte Geschichte Teil I_DiskC.adf] [right: 1869 - Erlebte Geschichte Teil I_DiskC.adf]

Abu Simbel Profanation [folder: Abu Simbel Profanation - size: 880kb]
wrong name: D:\Downloads\ROMS\GameBase Amiga\Games\Abu Simbel Profanation\adf\Abu Simbel Profanation.adf [wrong: adf\Abu Simbel Profanation.adf] [right: Abu Simbel Profanation.adf]

Alien Bash [folder: Alien Bash - size: 880kb]
wrong name: D:\Downloads\ROMS\GameBase Amiga\Games\Alien Bash\adf\Alien Bash.adf [wrong: adf\Alien Bash.adf] [right: Alien Bash.adf]

B.A.T. II (De)_Disk1 [folder: B.A.T. II (De)_Disk1 - size: 880kb]
wrong name: D:\Downloads\ROMS\GameBase Amiga\Games\B.A.T. II (De)_Disk1\adf\B.A.T. II (De)_Disk1.adf [wrong: adf\B.A.T. II (De)_Disk1.adf] [right: B.A.T. II (De)_Disk1.adf]

....etc...

The cause is obviously in RUNME.bat as the zips are being created without path junking enabled. I can only assume this wasn't noticed because everything still works as expected (WinUAE ignores paths in zips containing only one ADF). I have already corrected my game set with clrmamepro but would like you to change the zip switches in RUNME.bat to -j -m -q -9 which corrects the problem and also eliminates the need for the del commands, this might make it run slightly faster too.

Edit: How rude, I forgot to thank everybody for their work on GBA, so, thank you all very much

[eLowar]

Ah, this has been mentioned before, but I forgot.

And I was also lazy and just reused the same code to generate the batch file as for the old updates (so I essentially didn't even think about it). I'll fix it eventually, for now it's easy enough to fix it with CMP (or one could indeed just use CMP on the ADFs to begin with) or something of that sort.

Thanks for the report though, the last one was on IRC, I believe. Maybe now that it's on the forum I'll actually remember to change it.

[eLowar]

This issue should now be resolved. The three Game update packs have been replaced with versions with a modified script.

Thanks again to whoever reported it before on IRC and especially to OddbOd for the concrete suggestion.