ANAIIS 1.05 (28 may 2012)

[Gilloo]

You never said it only crashes when running under 1.3, only that pfs3 for ks1.3 crashes in some not-that-specific media change situations.

I never test the 1.3 version on 3.1... will do it!
The official PFS3 unmount correctly on 3.1.

[FastRobPlus]

Originally Posted by Gilloo

The main risk is to lose your data, and give me a trial. But I'm not of the kind to fatten the judges and lawyers. So you are warned

Thanks - this is good info. I may try a thumbdrive just to see how it works.

[Gilloo]

Originally Posted by Gilloo

I never test the 1.3 version on 3.1... will do it!
The official PFS3 unmount correctly on 3.1.

Verdict:
PFS13 on 3.1 does the same thing as 1.3 when unmount, but guru #8 (guru #3 on 1.3)

[Toni Wilen]

Does attached version work better?

I noticed that removable support wasn't fully enabled (TRACKDISK define) which can explain disk change problems.

WARNING: This is test version only. Do not upload anywhere else!

[Gilloo]

Originally Posted by Toni Wilen

Does attached version work better?

I noticed that removable support wasn't fully enabled (TRACKDISK define) which can explain disk change problems.

WARNING: This is test version only. Do not upload anywhere else!

Toni, I've test this version 03-Sep-2012, and it makes guru #8 when unmounting in both cases... (wb3.1 and wb1.3) (Sorry to announce bad news)

[Toni Wilen]

Originally Posted by Gilloo

Toni, I've test this version 03-Sep-2012, and it makes guru #8 when unmounting in both cases... (wb3.1 and wb1.3) (Sorry to announce bad news)

Works for me. Explain your test case _exactly_. Not just "I remove disk and it crashes".

EDIT: My test case:

Mount PFS3 floppy device (using similar mountlist used for RAD, except device and handler changed)
Format it.
Eject and insert and check that everything works. Including disk getting reported as removed, not non-dos after removal.

Previously media changes didn't work at all and it also randomly crashed after eject.

[Gilloo]

Originally Posted by Toni Wilen

Works for me. Explain your test case _exactly_. Not just "I remove disk and it crashes".

EDIT: My test case:

Mount PFS3 floppy device (using similar mountlist used for RAD, except device and handler changed)
Format it.
Eject and insert and check that everything works. Including disk getting reported as removed, not non-dos after removal.

Previously media changes didn't work at all and it also randomly crashed after eject.

aah, kiitos
mount uh2:
open the uh2: icon... display image or open a text file, close the application.
unmount uh2: then guru #8

http://aminet.net/package/disk/misc/unmount-0.1
Given there is the source code, I've done the equivalent unmount for 1.3 (which works with fat95, when fat95 is decided to work )

[Toni Wilen]

So it is ACTION_DIE problem after all. Nothing to do with removing removable media..

[Gilloo]

Originally Posted by Toni Wilen

So it is ACTION_DIE problem after all. Nothing to do with removing removable media..

Is it possible to got ACTION_DIE packet with pfs3_ks13 ? kiitos

[Toni Wilen]

Aminet unmount_m68k is broken, first instruction in executable is illegal instruction.

[Gilloo]

Originally Posted by Toni Wilen

Aminet unmount_m68k is broken, first instruction in executable is illegal instruction.

It seems to be compiled for other thing than pure 68000...
Toni, you can use the ANAIIS unmount (seek it in bin of the following package)
http://aminet.net/package/driver/other/anaiis
Good luck

[Toni Wilen]

pfs3 unmount is now working but there is still one problem remaining: under 1.3, mounting again after unmount crashes with memory list corruption guru.

More debugging to do..

Attach source of your version of unmount, thanks.

[Gilloo]

Hi Toni,
here's my unmount code with the makefile... for SASC 6.0 and up
Perhaps it's buggy. Please tell me if you find monsters

unmountc.c is the shell command source code,
unmount.c is the code to unmount function for 1.3 and for 2.04 and up.

[Toni Wilen]

I think calling c:assign is too ugly solution..

assign dismount: internally calls RemDosEntry() which is as simple as:

    dl = DeviceNode head
    while(dl->dol_Next)
    {
        struct DosList *dl2 = BADDR(dl->dol_Next);
        if(dl2 == dlist)
	{
	    dl->dol_Next = dlist->dol_Next;
	    break;
	}
	dl = dl2;
    }

(Forbid state required of course)

You should first find the correct device node and then exit the loop because doslist may have changed and "DeviceNode = (struct DeviceNode *)BADDR(DeviceNode->dn_Next) ;" may access random memory.

It is not safe to scan doslist without forbid state. (and forbid in this code would be broken anyway during packet calls)

But I don't think this is the cause for crash.

[Gilloo]

So I can remove the Execute call to "assign dismount" (I don't think it is working with 1.3) and "assign remove" then.

[Toni Wilen]

Originally Posted by Gilloo

So I can remove the Execute call to "assign dismount" (I don't think it is working with 1.3) and "assign remove" then.

Yeah, just manually unlink the doslist entry and your done.

[Toni Wilen]

Ok, this one should really work.

EDIT: also includes all SVN updates since previous pfs3ks13 Aminet release.

[Gilloo]

Kiitos Toni, I will try this weekend

I don't know why I wrote a Delay(10) before RemDosEntry... it seems to be superfluous...

[Gilloo]

hum... tested the new pfs_ks13

wb1.3: it freezes after unmount... (but no guru :-) )
wb3.1: guru #8

wb3.1, original PFS3 from the PFS3, guru #8 after unmount

Perhaps its my unmount in cause... so I broke the version
if (1 /*DOSBase->lib_Version < 37*/)
to activate always the 1.3 compatible code, but it is the same with pfs_ks13 and wb3.1/original PFS3 unmount correctly

Toni, do you also got the freeze in 1.3?

[Toni Wilen]

Works perfectly here, including 1.3, using your unmount. You sure you use correct pfs3 version?

EDIT: Run mungwall, must be wrong version if you get huge amount of memory allocation errors when unmounting. (You can use -log -serlog winuae command line parameters to see serial debugging without extra utilities)