Passing parameters to a script via WBRun

[mfilos]

Hey guys I'm stuck at some point and I need a bit of help.

I created an AmigaDOS script which gets a parameter via using the .key option.
According to what the script does I also get an output via Echo command.

For example:
Script name: test

.key input1
Echo <input1>
wait 1

- If I execute the script via the execute command (execute test HelloWorld) everything runs just fine and I get the echo output (HelloWorld) in my current shell.
- If I give an icon with IconX default tool and use the WBRun command (WBRun test HelloWorld) the script runs but my parameter doesn't pass

Since I want to use my script with BMenu (making 4 buttons for my 4 options) I'd rather use WBRun command in order to have the output window.
If I can't pass parameters in my script using WBRun is there another option of running my script via Execute command but having output as it won't run in an already open shell?

[daxb]

Try to set "WINDOW=" tooltype in your Icon with parmeter (eg. window=>con:0/20/300/100/output/wait/close) of course to get an output window.

[mfilos]

I have set that up of course.
Script is working just fine but it doesn't pass any parameter while running it with WBRun.
If I just "echo test" the output window opens just fine.


Edit: I just found out that indeed it passes the parameter, but it also adds a SYS: for some reason :S
For example I run the above script like this:

"execute test HelloWorld" I'll get normally the output window with the line "SYS:HelloWorld" !!!

I for now solved the issue by issuing "SYS:input1" instead of "input1" on the script, but I seriously dislike that solution :S

[mfilos]

Ok I found out that the .key parameter works rather strange. To be sure that it's not something of my custom ROMS I just tested it under a clean WB3.1 setup with almost the same output as well!
I even change the brakets by using .bra, .ket commands in case the <> characters create a fuss but still no difference.

So...

In my ClassicWB 3.9 setup:
- If I run the above script from a shell via: WBRun test HelloWorld, I get an output of SYS:HelloWorld.
- If I change vol to RAM: for example and run it again... I get an output of SYS:HelloWorld.

In a Stock 3.1 setup:
- If I run the above script from a shell via: WBRun test HelloWorld, I get an output of System:HelloWorld (System is the name of the system partition volume).
- If I change vol to RAM: for example and run it again... I get an output of Ram Disk:HelloWorld (Ram disk is the name of RAM: volume).

How on earth can I remove the volume name from the .key parameter?

[Bamiga2002]

How about trying WBLaunch instead of WBRun? Worth a test.

[mfilos]

I guess WBLaunch doesn't work with scripts (even with icons).
It gives a "wblaunch: object is not of required type" message one I run it.

So far, I'm doing the job ok with WBRun bit by attaching the extra "SYS:" characters to my parameter name so no problem. It's just that I don't like the behavior.

Edit: Btw I just tried also WBRun2 that just outputs the full path of the directory I'm running the script from. For example if I'm in work:temp and I run "WBRun2 test HelloWorld" I get an output of "Work:Temp/HelloWorld" LOL.

I guess the whole .key parameter is only usable correctly with Execute command. Maybe WBRun/WBRun2 can't work together with parameters using .key dunno :S

[Bamiga2002]

If you put iconx as default tool WBLaunch surely works dude.

[mfilos]

It surely doesn't for the job I want it man.

Take a glimpse for yourself if you don't believe it
https://dl.dropboxusercontent.com/u/939939/wblaunch.avi

[daxb]

I don`t know how to solve or if the problem is WBRun or IconX. At least IconX use already the current path in front of the argument. If it is parsed be WBRun or just IconX is faulty here, I can`t say but I`m not fimilar with DOS scripts.

[mfilos]

It's not such a huge problem as I solved it as I said by just checking SYS:HelloWorld instead of just HelloWorld in my IF statement. It was just awkward and that's why I expressed it here

One other solution would have been to just run it via Execute that runs just fine, and from there to output to another window (but I don't know how to open a new shell that will run the remaining script there).

Anyway, thanks for the help everyone.

[Bamiga2002]

Originally Posted by mfilos

It surely doesn't for the job I want it man.

Take a glimpse for yourself if you don't believe it
https://dl.dropboxusercontent.com/u/939939/wblaunch.avi

Yep you we're right just tested it myself too. Isn't WBRun using wbstart.library? Which version of that are you using?

[thomas]

You cannot pass parameters to a Workbench program. If you double click an icon on Workbench the only "parameters" you can pass are other icons which are shift-selected when you double click.

WBRun simulates a double click from Workbench. The arguments you pass behind the program you want to double click are other icons which are shift-selected, may they exist or not.

Those shift-selected icons are passed as pairs of directory they are in and file name. What IconX does is to connect the directory name and the file name as one path which it then passed to Execute. There is no way to remove the directory name from this mechanism. Which wouldn't make much sense anyway because the file could not be found if the directory name was removed.

[mfilos]

Yeah I understood the way it works. Thanks for the thorough clarification as always Thomas.

Just for means of knowledge... is there a way I can redirect the output of my script to a new window or shell?
For example can I just run my script via Execute and output that Echo line in a new window or shell?
I just want to press a button that will execute the script with the passing parameter, but I want the script that will run, to output to a window some info.

[daxb]

You can redirect the output of "echo" direct in the script. E.g.:
echo "bldfdf" >con:0/12/111/55/titel/close/wait

[mfilos]

Yeah I know about that. The fact is that I want to redirect more than 1 echo line.
Putting redirection to console in every line will just give me different output windows
I can also redirect to a file and then open the file for example with type <file> with the redirection you just said.

Cheers anyway

[thomas]

I don't know any way to do this with the commands supplied with AmigaOS.

However, you can use the attached program. Run it like this:

outrun con:0/0/640/200/Outrun/CLOSE/WAIT execute s:test arg1 arg2

[mfilos]

Thomas thanks a lot!!!
That was exactly what I was looking for. It works like a charm

[Bamiga2002]

Good good!
So whatcha gonna use it for?

[mfilos]

Haha. I make some scripts for Enabling/Disabling some of ClassicWB features and wanted one script for selecting different Boot Logos for my Amiga setup (or none). Of course I could have written a script for every choice but I didn't like that approach.

An example is this:
https://dl.dropboxusercontent.com/u/939939/BootLogo.avi

Now with Thomas script I don't have use WBrun along with an icon using IconX to be able to display an output window for Bloodwych scripts. Nice way to get rid of unused icons