Internal window size changes on theme change

[mark_k]

Testing on Vista SP2. On changing theme (e.g. between Aero and Classic), the WinUAE internal window size (as shown in the Display settings page) changes. I think the internal window size should not be changed when the theme changes.

In some cases this can cause the top part of the status bar to be overwritten by the emulation display. For example, testing with 2.5.1b4 (but problem happens with 2.5.0 too, the specifics might differ slightly though?):

Use Aero theme. Run WinUAE, manually set window size to 768x576 and start emulation.
Change to Classic theme: internal window size (shown on Display settings page) changes to 760x567.
Change back to Aero: internal window size says 768x576. But the actual window is too small; the top of the status bar gets overwritten by the emulation output.

[Toni Wilen]

Can't duplicate.

[mark_k]

Hmm, I just tried again (this time using a later Nvidia driver version though) with 2.5.1 and couldn't reproduce the problem either.

I did notice a related issue though. Start emulation in windowed mode, e.g. 768x576 window size. Repeatedly change theme between Aero and Classic. The window size gradually decreases the more times you change theme. But I couldn't reproduce that either after the first time! I'll try to do some more testing to see whether I can figure out what causes it to happen.

In the course of testing that, I got WinUAE 2.5.1 to crash once on changing theme. Crash dump file attached if it's of any use.