[FS-UAE] OS X Lion Full-Screen Mode

[yoki]

First, thanks a lot for doing this! Have been waiting sooo long for a proper amiga emu which runs on osx

Bug report (osx 10.7)
When resizing the window the gui breaks (https://skitch.com/m4rkus/eispd/amiga-500-fs-uae)

edit:

sorry, didn't realize i was running the old stable version would be cleaner if it wasn't possible to scale the content non-uniform though! also i think 4:3 should be the default aspect or atleast that we don't get black borders when using 4:3 windowed


Feature request
Would be awesome if Lion fullscreen-mode would be supported in the osx-build, it's very convenient when using fs-uae for developing to have a full-screened amiga on a separate screenspace

Cheers,

yonx / up rough

[yesplease]

Lion fullscreen mode, I like it too !!

[nexusle]

+1

[FrodeSolheim]

Possible "Lion fullscreen mode" support: http://fengestad.no/fs-uae/files/1.3.28u1/.

NSWindow::setCollectionBehavior is used with the NSWindowCollectionBehaviorFullScreenPrimary flag, and as I understand the documentation, this should add a fullscreen button in the upper right of the titlebar.

Note: start FS-UAE in windowed mode, not fullscreen mode!

[waal]

I launched in windowed mode and yes, the fullscreen button appears and works. I get a new fullscreen but the dimensions are not adapted, I mean the screen isn't stretched.

[FrodeSolheim]

Originally Posted by waal

I launched in windowed mode and yes, the fullscreen button appears and works. I get a new fullscreen but the dimensions are not adapted, I mean the screen isn't stretched.

OK, well it was worth a shot to check if this was enough. But it isn't practical for me to pursue this further at this time as I prefer to stick to 10.6 for now (patches are welcome if someone else fixes this, of course).

For reference, this was the patch against SDL:

--- a/src/video/quartz/SDL_QuartzVideo.m
+++ b/src/video/quartz/SDL_QuartzVideo.m
@@ -1059,6 +1059,12 @@ static SDL_Surface* QZ_SetVideoWindowed (_THIS, SDL_Surface *current, int width,
         [ window_view setFrameSize:contentRect.size ];
     }
 
+    NSWindowCollectionBehavior behavior = [ qz_window collectionBehavior ];
+    behavior |= (1 << 7);
+    [ qz_window setCollectionBehavior:behavior];
+
     /* For OpenGL, we bind the context to a subview */
     if ( flags & SDL_OPENGL ) {

[waal]

The emu crashes only if you set window_resizable = 1. Set it to 0 and you'll get the new screenspace without any problem like in the pic I've posted above. I think it's already a good option.

[FrodeSolheim]

Originally Posted by waal

The emu crashes only if you set window_resizable = 1. Set it to 0 and you'll get the new screenspace without any problem like in the pic I've posted above. I think it's already a good option.

It's nice if the feature is already useful, but it is a problem if it crashes by default. The first thought was to remove the code from the next version, but instead I have altered the SDL code so the full-screen button is available if the following environment variable is set (to anything):

SDL_WINDOW_FULLSCREEN_LION

(This applies to 1.3.29+)

[FrodeSolheim]

FS-UAE 2.3.10dev was updated to using SDL2. This changed how fullscreen works by default, and hopefully it works better - it seems it fixes problems for some(all?) users with retina displays.

But the interesting bit for this thread: I've peeked at the repository for the development version of SDL and found this commit. http://hg.libsdl.org/SDL/rev/8c0afe77a1b2 ("Added a hint SDL_HINT_VIDEO_FULLSCREEN_SPACES to specify that windows go fullscreen into their own spaces on Mac OS X.").

It looks like this commit will indeed add support for the fullscreen button in the window's title bar

Since the commit is already in the repo, I guess it will be available in SDL 2.0.2! (FS-UAE on OS X uses SDL 2.0.1).

[FrodeSolheim]

Ryan Gordon: "Just pushed a change to SDL to make it cooperate with Spaces on Mac OS X."
https://plus.google.com/103391075724...ts/TERztq6nQ94

So it seems that the new fullscreen modes in OS X are now fully supported in SDL 2

[FrodeSolheim]

SDL 2.0.2 was recently released, and I've tested building FS-UAE against that. "OS X Lion Full-Screen Mode" works nicely now, and will probably be available in a development version shortly

[amigafreak68k]

can't wait for it

[yesplease]

Me too. It will certainly be nice.