English Amiga Board


Go Back   English Amiga Board > Coders > Coders. Language > Coders. C/C++

 
 
Thread Tools
Old 26 March 2014, 03:02   #1
mritter0
Registered User

 
Join Date: Sep 2013
Location: Bettendorf, IA, USA
Age: 48
Posts: 204
Color wrong

Am I going insane?

WinUAE OS3.9 AGA 1280x1024x32 RTG

I open an icon in IconEdit that is 8bit optimized. Displays just fine. Displays fine in windows (folders).

I use Icon2C to convert icon (just need the normal image) to C source code. It says it is 8bits. Compile program. Colors ALL messed up. I am not specifying a palette since using 7 totally different images with their own palettes.

Why are the colors wrong? AGA is 256 colors. Can't GadTools handle 8bit images? Can't Icon2C handle 8bit images properly? I am banging my head against the wall on this one.
mritter0 is offline  
Old 26 March 2014, 07:46   #2
thomas
Registered User
thomas's Avatar
 
Join Date: Jan 2002
Location: Germany
Posts: 6,031
Quote:
I am not specifying a palette since using 7 totally different images with their own palettes.
That's your problem. The image structure only holds the pen numbers for each pixel. Colors for the pens are taken from the screen's palette.

So, to handle built-in images in your program you have to

- either convert all images to use the same palette before you convert them to C. In your program open a screen using this palatte, then you can directly DrawImage() the images into that screen.

- or write a routine which remaps an image from its palette to a given screen's palette. Then use this routine with each image before you draw it into your window.

Another way to use images with proper colors in your program is to keep all images as files on disk and use datatypes.library to load these images. Then datatypes will take care of the remapping.
thomas is offline  
Old 26 March 2014, 16:13   #3
mritter0
Registered User

 
Join Date: Sep 2013
Location: Bettendorf, IA, USA
Age: 48
Posts: 204
The pens dawned on me last night in bed. I am using a bare bones program just for testing. Opening in a window on Workbench, not a custom screen.

Will LockPubScreen() and GetPens() (or whatever. I will try them all) fix it? I think I am missing a simple step.
mritter0 is offline  
Old 26 March 2014, 17:12   #4
thomas
Registered User
thomas's Avatar
 
Join Date: Jan 2002
Location: Germany
Posts: 6,031
I fear there is no simple method to make this work. You have to remap your images to the screen's palette and there is no help from the OS for this, at least not before OS 4.0.

Check the pixelarray.c example on my homepage: http://thomas-rapp.homepage.t-online...les/index.html
thomas is offline  
Old 27 March 2014, 01:18   #5
mritter0
Registered User

 
Join Date: Sep 2013
Location: Bettendorf, IA, USA
Age: 48
Posts: 204
Now I am really frustrated. I used 2 of my old programs (Tool Type Editor and Icon Copier) to load/display the icons.....worked like a charm. Unfortunately, I no long have the source code. I figured it out 20 years ago. I will figure it out again.


Great web site, btw!
mritter0 is offline  
Old 27 March 2014, 07:41   #6
thomas
Registered User
thomas's Avatar
 
Join Date: Jan 2002
Location: Germany
Posts: 6,031
Erm, icons are different from images as they do not depend on a specific palette.

If you use 4-colored OS 3.1-style icons, they always look kind of right because only one color can be changed. Black and white are fixed, pen 0 is transparent and only the fourth pen can change its color.

If you use 8-colored MagicWB-style icons, they look right if you have MagicWB installed because MagicWB fixes all 8 pens.

If you use NewIcons or GlowIcons then newicon.library or icon.library (in OS 3.5+) takes care of the remapping.

But if you want to built images into your program, then nobody but you can remap the bitmaps.

The only way to let the system remap your images is if you load the images from disk with datatypes or as icons.
thomas is offline  
Old 27 March 2014, 13:11   #7
mritter0
Registered User

 
Join Date: Sep 2013
Location: Bettendorf, IA, USA
Age: 48
Posts: 204
I am using 8bit icons, so yes, icon.library is handling the palette. Sucks. I really don't want the images external.

Icons are just (struct Image *) images, same as a picture. Icon.library uses datatypes.library for 8bit and 32bit, yes? But I am still in the same boat with internal images.

Back to the drawing board....
mritter0 is offline  
Old 27 March 2014, 14:01   #8
thomas
Registered User
thomas's Avatar
 
Join Date: Jan 2002
Location: Germany
Posts: 6,031
Quote:
Icons are just (struct Image *) images, same as a picture.
No.

This is only true for OS 3.1 and below built-in icons. And similar to your internal images, they look differently on each user's palette.

Beginning with NewIcons the .info file is extended with an (undocumented) part which contains image data as well as palette data. Newicon.library transparently remaps the image into the screen's palette and pokes the remapped image into the struct Image pointed to by the struct DiskObject. But this remapped struct Image is a different one than that stored in the .info file. And the pens only stay valid until you FreeDiskObject() the icon.

In OS 3.5 icon.library was extended so that you can access the new image/palette part with OS functions. In OS 4.0 the new part was extended to understand 32bit images, too. These are not supported by OS 3.9 and below.


Quote:
Icon.library uses datatypes.library for 8bit and 32bit, yes?
No. It contains its own code to load and remap images from .info files.
thomas is offline  
Old 02 April 2014, 16:15   #9
mritter0
Registered User

 
Join Date: Sep 2013
Location: Bettendorf, IA, USA
Age: 48
Posts: 204
I tried some more hacks, but no luck. I have one more I am going to try; maybe.

I use datatypes now to load the images and it works fine. Just not my preferred method of having external images. I don't want the user to be able to change/modify them.
mritter0 is offline  
 


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
Color Saturation and Color Tint/Hue Retro-Nerd support.WinUAE 22 02 August 2018 10:38
Nasty Color-Flashing AGS Coders. System 0 18 December 2013 13:39
Printing in color with WinUAE on color laser source support.Apps 7 14 April 2013 00:32
Color difference Leandro Jardim support.WinUAE 3 16 November 2012 08:51
ISO true color to 256 color algorithm Lord Riton Coders. General 19 15 April 2011 17:49

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 15:33.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.
Page generated in 0.07833 seconds with 15 queries