English Amiga Board


Go Back   English Amiga Board > Coders > Coders. Asm / Hardware

 
 
Thread Tools
Old 19 February 2020, 17:54   #1
Wepl
Moderator
Wepl's Avatar
 
Join Date: Nov 2001
Location: Germany
Posts: 721
resourced ReSource

To improve the usability and fix bugs in ReSource 6.06 I've resourced and rebuild it.
If interested you can find it here: http://whdload.de/whdload/ReSource661.lha
Requires full 6.06 package. Source & .rs included.

Changes made: version 6.6.1 (2020-02-19) done by Wepl

* if screen height is greater than 512 pixel the height of the symbol and macro windows are enlarged to avoid scrolling in the list view gadgets
* no longer uses cmp2 instructions on 68060
* on saving an .rs file ReSource now remembers the used filepath in the environment variable ReSourceLastFileName, when ReSource is later started without a file specification it uses the remembered filepath as default original file
* clash of two variables for saveRsOriginal fixed which caused Current to be displayed in the menu but Original was active
* the save path upon start has been changed from Current to Original for saving .rs/.asm/executable
* disassembling of 'btst dn,#x' fixed for x > 7, no longer prints ???? in front of x
* some minor optimizations, some dead code/data removed

Last edited by Wepl; 19 February 2020 at 22:23.
Wepl is offline  
Old 19 February 2020, 18:16   #2
ross
Per aspera ad astra

ross's Avatar
 
Join Date: Mar 2017
Location: Crossing the Rubicon
Age: 50
Posts: 2,707
Thanks.

Original replaced
ross is offline  
Old 19 February 2020, 18:26   #3
Pyromania
Moderator

Pyromania's Avatar
 
Join Date: Jan 2002
Location: Chicago, IL
Posts: 2,452
Thanx for the updates, anywhere to buy this package new in 2020?
Pyromania is offline  
Old 19 February 2020, 18:31   #4
StingRay
move.l #$c0ff33,throat

StingRay's Avatar
 
Join Date: Dec 2005
Location: Berlin/Joymoney
Posts: 6,497
Thanks, this is very nice, I always wanted to do that as well as ReSource has some quite annoying bugs. I may use your resourced version to fix some more bugs in ReSource.

Edit: You might want to change the release date as I don't think you kept this version for a year on your hard drive.
StingRay is online now  
Old 19 February 2020, 22:22   #5
kamelito
Zone Friend
kamelito's Avatar
 
Join Date: May 2006
Location: France
Posts: 1,174
Great thanks. A shared repo would be great so everyone could submit fixes or improvements.
kamelito is offline  
Old 19 February 2020, 22:28   #6
Wepl
Moderator
Wepl's Avatar
 
Join Date: Nov 2001
Location: Germany
Posts: 721
Quote:
Originally Posted by StingRay View Post
Thanks, this is very nice, I always wanted to do that as well as ReSource has some quite annoying bugs. I may use your resourced version to fix some more bugs in ReSource.
Edit: You might want to change the release date as I don't think you kept this version for a year on your hard drive.
Ahh, changed. Although I started this somewhere in 2004 but never got it ready. I'm aware of other problems in ReSource too - so this is released in the hope that somebody else continues to fix
Wepl is offline  
Old 19 February 2020, 22:35   #7
Wepl
Moderator
Wepl's Avatar
 
Join Date: Nov 2001
Location: Germany
Posts: 721
Quote:
Originally Posted by kamelito View Post
Great thanks. A shared repo would be great so everyone could submit fixes or improvements.
I thought about github but:
1. the legal state is a bit undefined
2. there is no git client for os3
3. I think to enhance the source quality it is still advised to work on the .rs and then merge these changes into the source. At least I have done it this way in the last cycles.
Wepl is offline  
Old 19 February 2020, 23:22   #8
NorthWay
Registered User
 
Join Date: May 2013
Location: Grimstad / Norway
Posts: 660
You might want to look into the search functions as they seem to be writing over things they have no business with - try ROM disassembly.
NorthWay is offline  
Old 20 February 2020, 01:29   #9
dlfrsilver
CaptainM68K-SPS France
dlfrsilver's Avatar
 
Join Date: Dec 2004
Location: Melun nearby Paris/France
Age: 43
Posts: 8,455
Send a message via MSN to dlfrsilver
Quote:
Originally Posted by Wepl View Post
To improve the usability and fix bugs in ReSource 6.06 I've resourced and rebuild it.
If interested you can find it here: http://whdload.de/whdload/ReSource661.lha
Requires full 6.06 package. Source & .rs included.

Changes made: version 6.6.1 (2020-02-19) done by Wepl

* if screen height is greater than 512 pixel the height of the symbol and macro windows are enlarged to avoid scrolling in the list view gadgets
* no longer uses cmp2 instructions on 68060
* on saving an .rs file ReSource now remembers the used filepath in the environment variable ReSourceLastFileName, when ReSource is later started without a file specification it uses the remembered filepath as default original file
* clash of two variables for saveRsOriginal fixed which caused Current to be displayed in the menu but Original was active
* the save path upon start has been changed from Current to Original for saving .rs/.asm/executable
* disassembling of 'btst dn,#x' fixed for x > 7, no longer prints ???? in front of x
* some minor optimizations, some dead code/data removed
thank you very much wepl !!!
dlfrsilver is online now  
Old 20 February 2020, 10:29   #10
Wepl
Moderator
Wepl's Avatar
 
Join Date: Nov 2001
Location: Germany
Posts: 721
Quote:
Originally Posted by NorthWay View Post
You might want to look into the search functions as they seem to be writing over things they have no business with - try ROM disassembly.
Can you give me steps to reproduce?
Wepl is offline  
Old 20 February 2020, 13:57   #11
kamelito
Zone Friend
kamelito's Avatar
 
Join Date: May 2006
Location: France
Posts: 1,174
Quote:
Originally Posted by Wepl View Post
I thought about github but:
1. the legal state is a bit undefined
2. there is no git client for os3
3. I think to enhance the source quality it is still advised to work on the .rs and then merge these changes into the source. At least I have done it this way in the last cycles.
Maybe bugs should be listed in this thread so others people could fixed them.
kamelito is offline  
Old 21 February 2020, 17:59   #12
NorthWay
Registered User
 
Join Date: May 2013
Location: Grimstad / Norway
Posts: 660
Quote:
Originally Posted by Wepl View Post
Can you give me steps to reproduce?
You can look at http://eab.abime.net/showthread.php?t=89214 which is where I started.


I have downloaded another .rs of it earlier and looked at the search functions, and IIRC it looked like it ended up reading and writing back to the same address. Not smart if searching in ROM, nor making sense to RAM either.
NorthWay is offline  
Old 23 February 2020, 00:29   #13
NorthWay
Registered User
 
Join Date: May 2013
Location: Grimstad / Norway
Posts: 660
I think I have some more bugs stored somewhere - I'll see if I can find them.

Do you feel confident enough to do some deeper changes to ReSource? For some time now I have wished it would save out just the disassembled data/structure so you could release something without having someone roflstomp it because it contains the original binary.
Then you could load up the standalone release file and have it ask for the matching binary.
NorthWay is offline  
Old 24 February 2020, 18:01   #14
Wepl
Moderator
Wepl's Avatar
 
Join Date: Nov 2001
Location: Germany
Posts: 721
Quote:
Originally Posted by NorthWay View Post
You can look at http://eab.abime.net/showthread.php?t=89214 which is where I started.
So this a bug already present in 6.06 it seems, and not introduced by the rebuild?
I never used/tested disassembling memory.
ATM I don't have time to look on this.

Quote:
Originally Posted by NorthWay View Post
I think I have some more bugs stored somewhere - I'll see if I can find them.
It would be good to collect them at least.

Quote:
Originally Posted by NorthWay View Post
Do you feel confident enough to do some deeper changes to ReSource?
No. I have only tried to understand what was related to the changes I made. There is still many code which is not reviewed/understood.
Wepl is offline  
Old 26 February 2020, 18:29   #15
NorthWay
Registered User
 
Join Date: May 2013
Location: Grimstad / Norway
Posts: 660
Quote:
Originally Posted by Wepl View Post
It would be good to collect them at least.
Btw, do you know of this? https://www.ultimateamiga.co.uk/inde....html#msg46914

I have a bundle of hits I have gotten from ReSource at various times. I think they should all be from 6.06. Not sure if they will be of any help, but listing them can't hurt.

There is also some kind of display bug where it will (IIRC) more or less lock up if you play around with hex display and move backwards in the listing. Something about the visual presentation anyway. Haven't used it in a long time...
Attached Files
File Type: lha ReSourceBundle.lha (2.5 KB, 29 views)
NorthWay is offline  
Old 26 February 2020, 23:53   #16
Wepl
Moderator
Wepl's Avatar
 
Join Date: Nov 2001
Location: Germany
Posts: 721
Quote:
Originally Posted by NorthWay View Post
Interesting, didn't know. Are these rs-files mentioned downloadable?
A fully resourced ReSourcesyms.library.rs would be nice and allow easily to add at least some new LVOs for kick3.1 (exec, dos). I started resourcing it but lost motivation.
I never looked into ReSourcehelp.library.rs that would be win too.

Quote:
Originally Posted by NorthWay View Post
I have a bundle of hits I have gotten from ReSource at various times. I think they should all be from 6.06. Not sure if they will be of any help, but listing them can't hurt.
Thanks will collect this and hopefully review

Quote:
Originally Posted by NorthWay View Post
There is also some kind of display bug where it will (IIRC) more or less lock up if you play around with hex display and move backwards in the listing. Something about the visual presentation anyway. Haven't used it in a long time...
not of much help without steps to reproduce
Wepl is offline  
Old 27 February 2020, 14:23   #17
NorthWay
Registered User
 
Join Date: May 2013
Location: Grimstad / Norway
Posts: 660
Quote:
Originally Posted by Wepl View Post
Are these rs-files mentioned downloadable?
Yes. I registered on the forum and downloaded them. That is how I knew it was in the search functions the problems with ROM disassembly was.

Quote:
Originally Posted by Wepl View Post
not of much help without steps to reproduce
I know, but that was the closest I could remember. My 4000 is semi-borked, but that bug should be possible to find in UAE too. I'll try fishing for it one of these days.
NorthWay is offline  
 


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
ReSource 6.06 yoki request.Apps 6 04 November 2009 17:29
ReSource? gospodin request.Apps 2 30 March 2009 13:36
ReSource 6.XX MrZammler request.Apps 7 30 October 2007 14:15
ReSource v6.06 A.I request.Apps 3 08 October 2005 21:25
Resource Amigaboy request.Apps 2 16 August 2001 05:15

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 16:43.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.
Page generated in 0.09164 seconds with 16 queries