Cannot get WBStartup struct when starting from Workbench (with VBCC)

[tygre]

Dear all!

I am running into a problem and I spent my afternoon trying to fix it. I want to get the path of my program no matter if it is run from a CLI or from the Workbench. I read lots of threads here and there but, in my code, the call to WaitPort(&(process->pr_MsgPort)); never ends when I double-click on the program's icon!

What am I doing wrong? What am I missing? It must be obvious but...
Thanks in advance!

/* Includes */

#include <stdio.h>
#include <stdlib.h>
#include <proto/dos.h>
#include <proto/exec.h>
#include <time.h>
#include <exec/execbase.h>
#include <workbench/startup.h>

#include "controlscli.h"
#include "controlsmui.h"
#include "fortify.h"
#include "version.h"



/* Constants and declarations */

int main(int, int **);

BPTR path;



/* Definitions */

BPTR path = 0;

int main(int argc, int **argv)
{
    CONST_STRPTR                        arguments_template = "MUI/S,VERSION/S";
    struct { long mui; long version; }  arguments_values   = { 0 };
    struct RDArgs                      *arguments          = NULL;
    int                                 result             = RETURN_ERROR;
    struct WBStartup                   *wbstartup          = NULL;
    struct Process                     *process            = NULL;
    struct CommandLineInterface        *cli                = NULL;
    BPTR                                file               = 0;

    srand(time(NULL));

    file = Open("CON:0/40/640/150/Output0/auto/close/wait", MODE_NEWFILE);
    process       = (struct Process *)FindTask(NULL);
    FPrintf(file, "process = %ld\n", process);
    FPrintf(file, "pr_CLI  = %ld\n", process->pr_CLI);
    if(process->pr_CLI == 0)
    {
        FPrintf(file, "Here1\n");
        WaitPort(&(process->pr_MsgPort));
        FPrintf(file, "Here2\n");
        wbstartup = (struct WBStartup *)GetMsg(&(process->pr_MsgPort));
        FPrintf(file, "wbstartup = %ld\n", wbstartup);
        process   = wbstartup->sm_Message.mn_ReplyPort->mp_SigTask;
    }
    else
    {
    }
    FPrintf(file, "process = %ld\n", process);
    cli           = BADDR(process->pr_CLI);
    FPrintf(file, "cli     = %ld\n", cli);
    path          = cli->cli_CommandDir;
    FPrintf(file, "path    = %ld\n", path);

    arguments = ReadArgs(arguments_template, (APTR)&arguments_values, NULL);
    if(arguments == NULL)
    {
        PrintFault(IoErr(), NULL);
        return RETURN_ERROR;
    }
    else if(arguments_values.version)
    {
        printf("%s\n", get_version_string());
        result = RETURN_OK;
    }
    else if(arguments_values.mui || argc == 0)
    {
        result = controls_mui();
    }
    else
    {
        result = controls_cli();
    }

    FreeArgs(arguments);
    return result;
}

PS. Forgot to mention that I am using VBCC 0.98 and would like my code to run in 3.x (or even 2.x) and newer... if possible?

[hooverphonique]

does your program have an actual .info file or are you using "show all files" ?

[Toni Wilen]

You must not do any dos calls before WBStartup message has been retrieved, DOS packets and WBStartup use same message port.

[thomas]

Originally Posted by tygre

What am I missing? It must be obvious but...
Thanks in advance!

When your main() routine is called, all the WB handling has already been done by the standard startup code. The message has already been fetched, you won't get another one.

To distinct between CLI and WB usage in a standard main() routine, you can check argc. If it is 0, the program was called from WB and argv points to the wbstartup message. If argc is > 0 argv points to the standard C args.

#include <proto/dos.h>
#include <proto/intuition.h>
#include <workbench/startup.h>

int main (int argc,char **argv)
{
if (argc == 0)
	{
	struct WBStartup *wbmsg = (struct WBStartup *)argv;
	struct EasyStruct es = {
		sizeof(struct EasyStruct),
		0,
		"WB Example",
		"started from Workbench;\nprogram name = <%s>",
		"Ok"};
	ULONG idcmp = 0;
	EasyRequest (NULL,&es,&idcmp,wbmsg->sm_ArgList[0].wa_Name);
	}
else
	{
	Printf ("started from CLI; program name = <%s>\n",argv[0]);
	}
return (RETURN_OK);
}

compile with

vc wbtest1.c -o wbtest1 -lauto -lamiga

If you want to handle the WBStartup message yourself, you cannot use the standard startup code. Then you have to do everything yourself. Use -nostdlib switch to omit the standard startup code.

#define __NOLIBBASE__
#include <proto/exec.h>
#include <proto/dos.h>
#include <proto/intuition.h>
#include <workbench/startup.h>

__saveds int startup (__reg("a0") char *argstr,__reg("d0") long arglen)

{
struct Library *SysBase = *((struct Library **)4);
struct Process *pr = (struct Process *) FindTask (NULL);

if (!pr->pr_CLI)
	{
	struct WBStartup *wbmsg;
	struct Library *IntuitionBase;

	WaitPort (&pr->pr_MsgPort);
	wbmsg = (struct WBStartup *) GetMsg (&pr->pr_MsgPort);

	if (IntuitionBase = OpenLibrary ("intuition.library",36))
		{
		struct EasyStruct es = {
			sizeof(struct EasyStruct),
			0,
			"WB Example",
			"started from Workbench;\nprogram name = <%s>",
			"Ok"};
		ULONG idcmp = 0;

		EasyRequestArgs (NULL,&es,&idcmp,&wbmsg->sm_ArgList[0].wa_Name);

		CloseLibrary (IntuitionBase);
		}

	Forbid();
	ReplyMsg ((struct Message *)wbmsg);
	}
else
	{
	struct Library *DOSBase;
	if (DOSBase = OpenLibrary ("dos.library",36))
		{
		char name[256];
		APTR varargs[1];

		GetProgramName (name,sizeof(name));

		varargs[0] = name;
		VPrintf ("started from CLI; program name = <%s>\n",varargs);

		CloseLibrary (DOSBase);
		}
	}

return (RETURN_OK);
}

compile with

vc -nostdlib wbtest2.c -o wbtest2

[tygre]

Hi hooverphonique, Toni, and Thomas!

Thanks you all for your answers and your explanations!

Yes, my program has an icon but that should not make any difference, should it?

I will try again later today but, at one point, I had tried struct WBStartup *wbmsg = (struct WBStartup *)argv; and, IIRC, it returned a NULL pointer... but let me try again!

Will keep you posted and thanks again!

[tygre]

Hi again!

Ah, you were right of course

Using struct WBStartup *wbmsg = (struct WBStartup *)argv; works perfectly fine! My problem came from my (dumb?) use of WBRun: when using WBRun to run the command, wbmsg exists but the associated process is NULL.

Anyhow, now everything is great, thanks a lot!

[hooverphonique]

Originally Posted by tygre

when using WBRun to run the command, wbmsg exists but the associated process is NULL.

you mean FindTask(NULL) returns NULL?

[thomas]

That's impossible. No, he means this returns NULL (from his first listing):

process   = wbstartup->sm_Message.mn_ReplyPort->mp_SigTask;

[tygre]

@hooverphonique and @Thomas

Yes, exactly as Thomas says

It seems that WBLoad (part of CLICon) could solve this problem (and that this problem comes from WBRun, which may be fixed in a later version...)

Take care!

[thomas]

What do you need it for? It is (in the best case) the process of Workbench. There should be no reason to access it by an application.

[tygre]

Originally Posted by thomas

What do you need it for? It is (in the best case) the process of Workbench. There should be no reason to access it by an application.

Hi Thomas!

I was using it to actually test AmiModRadio from a CLI but as if running it from the Workbench... but now I realise that WBRun does not replace the real thing

Take well care