icon.library 46.4 test versions

[PeterK]

Hi Thorham,

indeed, DrawInfo and Screen are already declared as structures in intuition/screens.i, but I don't get any complains from PhxAss here. I can't say why not ?

Try option "EXE" or just rename all conflicting symbols in my code. Did you change the ordering of the include files? Try without using the debugging options "DS" or "DL".

[Thorham]

Hi PeterK,

Originally Posted by PeterK

indeed, DrawInfo and Screen are already declared as structures in intuition/screens.i, but I don't get any complains from PhxAss here. I can't say why not ?

Which version are you using?

Originally Posted by PeterK

Try option "EXE" or just rename all conflicting symbols in my code. Did you change the ordering of the include files?

Tried EXE, doesn't work, and I use your include files as is. I'll just rename the symbols. It's not many anyway.

Another thing. Programs such as IconFramesOff don't work. I've tried with and without Newicons. Because of the libloader hack I'm using I also tried changing the version for OpenLibrary in the source code, but they still don't work. Anything I'm missing?

[PeterK]

IconFramesOff needs workbench.library v44+. If you want borderless icons with v39 or v40 then have a look to my IconDemoADF which uses NewIcons, NiPrefs and NiRTGset.

Btw, I don't use the debugging options "DL" or "DS".

I'm using Phxass with the following CLI options:

ALIGN
ERRORS=10
RC=20
VERBOSE
QUIET
EXE
M=2
FPU=1
BUFSIZE=16384
SHOWOPT
ZEROPADDING
OPT=NRQBLP

But in reality I'm using PhxassGUI, which will not work
with the current versions of WinUAE.

[Thorham]

Originally Posted by PeterK

IconFramesOff needs workbench.library v44+. If you want borderless icons with v39 or v40 then have a look to my IconDemoADF which uses NewIcons, NiPrefs and NiRTGset.

Now I get it I'll just use NewIcons with the config program.

Anyway, your library assembles and works Thanks for the help

[Thorham]

Originally Posted by PeterK

Btw, I don't use the debugging options "DL" or "DS".

I'm using Phxass with the following CLI options:

ALIGN
ERRORS=10
RC=20
VERBOSE
QUIET
EXE
M=2
FPU=1
BUFSIZE=16384
SHOWOPT
ZEROPADDING
OPT=NRQBLP

But in reality I'm using PhxassGUI, which will not work
with the current versions of WinUAE.

Going to try those.

Btw, I'm not on WinUAE, but an A1200 with '030

[PeterK]

Usually, I'm compiling my library as an object file and then use PhxLnk from name.o to name DONTSHORTENSECT. This gives you short relocs, the last argument is required to let it work with custom ROMs.

PhxAssGUI may work on a real Amiga, although it has a bug, because it reads from address -4 and WinUAE returns the wrong "result" from non-existing memory (zero instead of -1).

[Thorham]

That might be it. I already tried a bunch of options, so trying the linker first seems more useful.

[PeterK]

Just change the paths in PhxAssGUI for your config. The prefs file goes into S:

[Thorham]

Thanks PeterK, much appreciated

[PeterK]

Alright, now I'm looking forward to the upcoming Thorham turbo version of my icon.library

[Thorham]

Still no luck with the original source code. Strange. Well, it doesn't really matter. Changing those two labels is not a problem, and works properly, so in the end it works, and that's what counts

[Thorham]

Originally Posted by PeterK

Alright, now I'm looking forward to the upcoming Thorham turbo version of my icon.library

LOL I'll see what I can do. Maybe PNG decoding can be sped up with meynaf's codec. I'll see what I can find

[PeterK]

If you would like to do something useful then try to finish my zlib stuff, because there is still a lot of awful compiler code left which needs to be replaced. Switch the Adler CRC on in that case.

But if you prefer to use Meynaf's code then you have to start from the beginning again. And his code is really hard to read, but he has warned me when I asked him for his sources.

ok, time to have a pizza and some red wine now, cheers

[solomani]

Originally Posted by PeterK

@solomani
First, try to boot from my IconDemoADF image to see if that works on your system. You should get all kind of different icon types correctly displayed.

Ok so I loaded the floppy, looks great. I then changed my icons and copied the start-up files to the start-up to my Amiga HD. However when I boot it, its looks meh:
http://i.imgur.com/eq6hmpq.png

I assume I missing a step somewhere? Something needs to be loaded into memory?

Originally Posted by PeterK

AND PLEASE, make smaller screenshots and just attach them, so that they are displayed as thumbnails. Thanks !

Will do, apologies and thanks for your support. Not sure how to do thumbnails so just did a link.

[PeterK]

Compare the startup-sequence of the IconDemoADF with your own, plz.

[Thorham]

Originally Posted by PeterK

But if you prefer to use Meynaf's code then you have to start from the beginning again. And his code is really hard to read, but he has warned me when I asked him for his sources.

For me the problem is French comments, but he's French, so that makes sense

Currently I've optimized two parts:

The first is the remap table generator... I think. It's the part where you have to merge _RGB with _rgb. Not very important speed wise, but it's shorter.

The second is the c2p. I replaced the 68020 part with a loop (no more jump table). Makes the code much shorter, and is also a little bit faster on 68020/30 because the whole loop now fits inside the cache. For 68000 this will be slower, so I haven't touched that. By the way, why can the 68000 part of the c2p do eight bit planes? On 68000 based machines there's a maximum of six bit planes. Seems to me that two of the eight blocks can be removed to shorten the code (haven't done that, because I don't know if it's needed).

[gulliver]

@PeterK

Is there a way to run IconFramesOFF from workbench rather than only from the startup-sequence?

[PeterK]

Yes, of course, just use XIcon or IconX or WbRun in a project-icon which calls IconFramesOff from a script with the same name that the icon has. Use the ToolType MODE=NOWINDOW

Hmm, never done something like this ?

[gulliver]

Thank you PeterK.

I have done that a few times, but my question was more if it was okay to do it after workbench has been loaded, wondering if some potential issue could arise from that. Or if there was a special tooltype I had to use to avoid problems.

[PeterK]

Alright, now I understand ...

The two instructions IconFramesON and IconFramesOFF can be used at any time, but they will only have the desired effect when workbench.library v44 is installed. The old WB 3.0 / 3.1 needs the NewIcon patch, installed as it is on my IconDemoADF, to get borderless / frameless icons.

After calling IconFramesON /OFF you will need to call WB-reset from the tools menu in order to redraw the icons (but some icons may stay unchanged even after a refresh).