17 July 2018, 19:54 | #2361 |
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
Now if you
copy 239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover78981234567899123456789112.jpg ram:239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover7898123456789912345678911234567.jpg nothing will happen (with V45 the file gets copied, using all 107 chars). WBCtrl MNL 102. Mmmh shouldn't it prevent only exceeding .info files from WB in case the file has one and fail the copy process? But if the file has no info should let you create one with 107 chars... Maybe I'm wrong, or maybe v45 was too permissive? Actually v45 could lead you to a case where file gets copied but icon not created from WB (RAMIGA+C)… With your v46 now the safety check is done before the copy actually limiting you to 102 chars files, even if limit is 107… mmh But from shell the OS should let you create 107 max char limit files (without icons). Still not sure though… (a bit tired) P.S: If you press RAMIGA+R to rename the file from WB you can still enter up to 107 chars, and at this point if you press Enter to confirm, the file will simply disappear without any warning (odd!??) P.P.S: another strange thing is that now WB screen appears early in the Startup-Sequence (icon.library in search of WB screen that as a side effect of a lock pops-up too early before LoadWB?) Last edited by hexaae; 17 July 2018 at 20:26. |
17 July 2018, 20:02 | #2362 |
Banned
Join Date: Nov 2007
Location: Trondheim, Norway
Posts: 1,893
|
I feel too dumb to follow this now... what does C:Copy have to do with icon.library and .info files? AFAIK, only Workbench (and its "clones") care about .info files, and copying jpeg files from shell doesn't do anything with .info files. What am I missing?
|
17 July 2018, 20:57 | #2363 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
Copying 102 chars to 107 works here. Not creating an icon is correct.
Renaming 102 chars to 107 with a disappearing icon is correct. The user must know what he does. What do you mean with "icon.library in search of WB screen"? What kind of lock pops up? @kolla I would think just the same about the copy instruction. |
17 July 2018, 22:02 | #2364 | ||
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
WBCtrl MNL 102, following command will result in no file in ram (does work with v45 instead):
copy 239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover78981234567899123456789112.jpg ram:239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover789812345678991234567891123.jpg (102 from HD location) to (103 in RAM) Quote:
It would be normal failing to rename the icon only (too long with +5 chars) but in this case, from WB (RAMIGA+R), without warning it works like a delete command on any file above 102 chars (EDIT: it's not actually deleted, but WB won't show it in ram!) Repro steps: - WBCtrl MNL 102 and then copy a 102 chars file (without icon) in ram: - open RAM, click on file def_icon and press RAMIGA+R to rename it - give it a 107 chars long name and press Return - the file will be vanished! Quote:
Last edited by hexaae; 18 July 2018 at 11:34. Reason: added 'opening RAM from WB', just to be clear |
||
17 July 2018, 22:42 | #2365 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
Everything just works correctly here. If you use rename for the icon on WB (RAMIGA+R) and the new name is too long for the deficon but ok for the filename, it's logical that the icon has to disappear, but the file is renamed as it should. Use the list command.
If the icon of the old file was a real icon, it also remains without the old file. You have to update the drawer to see the old icon. That's also logical. Using LoadModule or LoadResident and SetPatch v44 makes no sense, since SetPatch loads icon.library and workbench.library anyway. But I'm going to check that soon. Update: Checked that with LoadModule, but there is no early opening of the Workbench. It must be something else in your startup-sequence. Last edited by PeterK; 17 July 2018 at 22:49. |
17 July 2018, 23:27 | #2366 |
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
This is a misunderstanding: I'm working with no icons. Copy bare files without icons and in RAM rename the same file from 102 to 107 chars with RAMIGA+R from WB.
I use Deficons with Newicons but I don't think it can have something to do with this, also because it's not reproducible just switching back to icon.library v45. About WB title popping up early if I revert to V45 or old v46 the glitch disappears. The only variable changed is icon.lib v46. P.S. Of course I use LoadModule to load also other things, that's why I use it. Last edited by hexaae; 17 July 2018 at 23:32. |
18 July 2018, 00:06 | #2367 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
Sorry hexaae, it's not a misunderstanding. Of course, I have done all my tests without real icons, just with deficons, and everything works as you can see in my screenshot with the shell window.
Only a final test was done with a real icon to check how that behaves on renaming from 102 to 103+ chars. That's also ok. I think, you still don't understand that icon.library v45 causes a buffer overflow which may result in memory corruption and even a crash sometimes. I had such memory corruptions when I tried to load the renamed deficon (103+ +.info) into WB Icon Information to save it as a real icon: Bang! Icon.library is not a task and never opens the WB by itself. So what is in your startup-sequence that calls icon.library and needs access to the WB? And again, on a system with SetPatch v44 icon.library and workbench.library are loaded from Libs: anyway if SetPatch finds them there, unless you are using the option DISABLEROMMODULES "" which is not the same as SKIPROMMODULES for other libraries, handlers and devices. By default Setpatch removes icon.library and workbench.library from the resident list and thus makes LoadModule and LoadResident pointless. It seems that ThoR has changed LoadModule to work together with SetPatch DISABLEROMMODULES "" now. Some years ago he told me that this SetPatch option is not working correctly, but it works now, so he must have fixed LoadModule. You can check that in Scouts resident list. Last edited by PeterK; 18 July 2018 at 01:42. |
18 July 2018, 07:45 | #2368 |
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
With icon.library 46.4.487 + WBCtrl MNL 102, after a
copy 239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover78981234567899123456789112.jpg ram:239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover789812345678991234567891123.jpg (102 -> 103 chars in ram) When you open RAM from WB (don't use C:List from shell… that is correctly displaying the file in ram, no doubt about it) it won't display the file icon of 103 chars (using its def_icon since it has no .info file), that's what I'm saying. If you rename the file under 103 chars it will reappear in WB ram. workbench.library 45.132 (or 45.138) and no patches/hack installed. ram-handler from OS3.9 (don't use amber-ram or similar). About the annoying WB title popping up before LoadWB I'm also sure is present only when I use icon.library 46.4.487 Both issues are not reproducible using v45 or previous v46.4.481 from Aminet. Last edited by hexaae; 18 July 2018 at 08:43. |
18 July 2018, 08:59 | #2369 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
How often do I need to repeat myself? A name with 103 chars + .info or more is not a valid name and can not have an icon if you don't want to get a buffer overflow. So, it's correct that there is no (def)icon and v45 - 46.4.486 have an issue when they don't care about invalid names. 487 fixes this long-standing bug.
I just did such a rename (102 -> 103) with RAmiga-R under v45 again and I get Enforcer hits as soon as I try to save the deficon with Icon Information: You still didn't tell me which program in your startup-sequence, user-startup or WBStartup causes the early opening of the WB screen or title. I'm adding my internal sub-versions now, so that you can check when exactly this issue starts. Last edited by PeterK; 18 July 2018 at 19:20. |
18 July 2018, 09:18 | #2370 | |
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
Quote:
I have v45.5 (is this one you tested? It's a mess with all official/unofficial versions around...) and your test is impossible to do here: if I try to rename from shell (I'm in RAM directory): ren 239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover78981234567899123456789112.jpg.info 239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover789812345678991234567891123.jpg.info will result in ram:239475-brian-the-lion-starring-in-rumble-in-the-jungle-amiga-front-cover789812345678991234567891123.jpg.inf truncated, still safe within 107 chars… workbench.library 45.132 icon.library 45.5 Last edited by hexaae; 18 July 2018 at 11:40. |
|
18 July 2018, 09:46 | #2371 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
Ok, I've tested with RAWBInfo first and it caused Enforcer hits on saving. With WBInfo 45.1 there was no hit. I will check that later.
|
18 July 2018, 09:51 | #2372 | ||||
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
Quote:
Quote:
Can you please list what you did step by step (maybe I misunderstood something…)? EDIT: Oh, as I supposed you used buggy RAWBinfo, now I understand when you wrote "..I try to save the deficon with Icon Information", not present in the original WBInfo() window. Quote:
Quote:
… here is the result: with version 'b' started the strange "WB title pop-up" before LoadWB with version 'f' started the issue with file (def_icon, since it has no real icon) not shown in WB ram if >102 chars (but you can still list it from shell…) Last edited by hexaae; 18 July 2018 at 11:30. |
||||
18 July 2018, 11:10 | #2373 | |
Registered User
Join Date: Aug 2014
Location: Brindisi (Italy)
Age: 70
Posts: 8,258
|
Quote:
Another strangeness it's on your LHA archives, if dragged on the Workbench and they are active both DF0 and DF1, we will find the archive inserted in both floppies (file icon.library.46.4.487_68000 DF0 and file icon.library.46.4.487_68020 DF1), i think it depends on the type of files contained in the archive, i tried to create a file ZIP and the same thing happens I enclose a video showing the two oddities reported. Last edited by AMIGASYSTEM; 19 July 2018 at 19:36. |
|
18 July 2018, 13:24 | #2374 | |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
Quote:
I think the solution should be to enable the code in GetDiskObject() again to fix your WB problem and to remove the tag ICONGETA_GetPaletteMappedICON=0 in GetDO_NoFail_Tags only to fix the FileX problem. That your other problem with the disappearing deficons started with 487f was clear. I'm going to check that again if it might cause possible issues in other programs like the crash with RAWBInfo before I go back to 487e. @AMIGASYSTEM Are you using a tool like ArcHandler or something similar to automatically mount the contents of archive files? Which tool is that? What is your disk "pippo:" exactly, which filesystem is that? Last edited by PeterK; 18 July 2018 at 13:29. |
|
18 July 2018, 13:42 | #2375 |
Banned
Join Date: Nov 2007
Location: Trondheim, Norway
Posts: 1,893
|
|
18 July 2018, 14:34 | #2376 |
Registered User
Join Date: Apr 2005
Location: digital hell, Germany, after 1984, but worse
Posts: 3,378
|
Indeed, you can mount lha files with the WinUAE floppy drives! Hoorray!!
@AMIGASYSTEM Please eject your floppy disks from DF0: and DF1: and reboot again. Maybe you have typed some keyboard shortcuts / hotkeys that WinUAE uses to mount the floppy drives? But don't ask me which shortcuts that are. I don't know. Ask Toni. Maybe, it's a feature of uaecontrol, but I don't use that. Last edited by PeterK; 18 July 2018 at 14:52. |
18 July 2018, 14:35 | #2377 |
Bug hunter
Join Date: Jul 2006
Location: Italy
Age: 48
Posts: 2,165
|
@PeterK
RAWBinfo has always been buggy unfortunately (random memory corruption or partially incompatible with some icons), including latest (un)official versions 1.36+. Another example: if you try to drag'n'drop this big Coloricon (yes, exceeds 94x94) over another project to copy the icon it may crash or open a "Not enough memory available" warning (?). If you disable RAWBinfo, and you drag'n'drop that icon over another project using original WBInfo() window you'll see no issues… The best was SwazInfo, but even with latest patches post-OS3.5 it still has problems handling NewIcons + Coloricons… AFAIK David Swasbrook never released source code to let someone continue his great WBInfo() replacement |
18 July 2018, 15:02 | #2378 | ||
Registered User
Join Date: Aug 2014
Location: Brindisi (Italy)
Age: 70
Posts: 8,258
|
Quote:
Quote:
I attach my old video that shows how WinUAE handles many file formats including archives. [ Show youtube player ] |
||
18 July 2018, 15:07 | #2379 | ||
Registered User
Join Date: Aug 2014
Location: Brindisi (Italy)
Age: 70
Posts: 8,258
|
Quote:
Quote:
Last edited by AMIGASYSTEM; 18 July 2018 at 15:39. |
||
18 July 2018, 15:12 | #2380 |
Banned
Join Date: Nov 2007
Location: Trondheim, Norway
Posts: 1,893
|
I suspect you get more "floppies" mounted when the archive doesn't contain a root directory.
|
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests) | |
Thread Tools | |
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
ClassicWB Full and icon.library 46.4 | Retroplay | project.ClassicWB | 8 | 05 August 2018 13:57 |
WB library conflict/versions | Amiga1992 | support.Apps | 3 | 22 July 2010 18:47 |
PNG Icon to Color Icon Converter? | Leandro Jardim | request.Apps | 1 | 24 May 2010 04:39 |
What's the latest version of icon.library for OS3.9? | NovaCoder | support.Apps | 3 | 30 June 2009 15:43 |
Requesting icon.library v44+... | nikvest | request.Other | 2 | 16 September 2007 01:58 |
|
|