For games with non-analogue controls, or 8-ways direction controls: SEGA Six Button >>>>> Everything else.
For nostalgia value, I use sticks. I miss being comfortable with them, I remember when pads felt strange to me. Some of the sticks that were my favourite back then feels horrible to me now. That said, a clicky Competition Pro or a Zip Stick will always feel great.